[Openvpn-devel] [S] Change in openvpn[release/2.6]: Print DCO client stats on SIGUSR2

2023-07-17 Thread flichtenheld (Code Review)
flichtenheld has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/202?usp=email ) Change subject: Print DCO client stats on SIGUSR2 .. Print DCO client stats on SIGUSR2 Change-Id: I465febdf7ee5fe573e88255844f718ef

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Fix '--inactive 0' behavior for DCO

2023-07-17 Thread flichtenheld (Code Review)
flichtenheld has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/201?usp=email ) Change subject: Fix '--inactive 0' behavior for DCO .. Fix '--inactive 0' behavior for DCO Make sure we exit if is 0 (not set) a

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: buffer: use memcpy in buf_catrunc

2023-07-21 Thread flichtenheld (Code Review)
flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/314?usp=email ) Change subject: buffer: use memcpy in buf_catrunc .. buffer: use memcpy in buf_catrunc Since we use strlen() to determin

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-07-21 Thread flichtenheld (Code Review)
Attention is currently required from: selvanair. flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/312?usp=email ) Change subject: Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Mock openvpn_exece on win32 also for test_tls_crypt

2023-07-21 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/313?usp=email ) Change subject: Mock openvpn_exece on win32 also for test_tls_crypt ..

[Openvpn-devel] [M] Change in openvpn[release/2.6]: vcpkg-ports/pkcs11-helper: Backport MinGW series from master to relea...

2023-07-21 Thread flichtenheld (Code Review)
flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/311?usp=email ) Change subject: vcpkg-ports/pkcs11-helper: Backport MinGW series from master to release/2.6 .. vcpkg-ports/pkcs11-helper

[Openvpn-devel] [XS] Change in openvpn[master]: route: Fix overriding return value of add_route3

2023-07-28 Thread flichtenheld (Code Review)
flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/319?usp=email ) Change subject: route: Fix overriding return value of add_route3 .. route: Fix overriding return value of add_route3 The

[Openvpn-devel] [XS] Change in openvpn[master]: pkcs11_openssl: Disable unused code

2023-07-28 Thread flichtenheld (Code Review)
flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/317?usp=email ) Change subject: pkcs11_openssl: Disable unused code .. pkcs11_openssl: Disable unused code Coverity: CID 1539183 (#1 of

[Openvpn-devel] [XS] Change in openvpn[master]: options: Do not hide variables from parent scope

2023-07-28 Thread flichtenheld (Code Review)
flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/320?usp=email ) Change subject: options: Do not hide variables from parent scope .. options: Do not hide variables from parent scope msg

[Openvpn-devel] [S] Change in openvpn[master]: Fix various "Uninitialized scalar variable" warnings from Coverity

2023-07-28 Thread flichtenheld (Code Review)
flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/318?usp=email ) Change subject: Fix various "Uninitialized scalar variable" warnings from Coverity .. Fix various "Uninitialized scalar

[Openvpn-devel] [M] Change in openvpn[release/2.6]: Set WINS servers via interactice service

2023-07-31 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos, selvanair, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/321?usp=email ) Change subject: Set WINS servers via interactice service .

[Openvpn-devel] [M] Change in openvpn[release/2.6]: Set WINS servers via interactice service

2023-07-31 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos, selvanair, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/321?usp=email ) Change subject: Set WINS servers via interactice service .

[Openvpn-devel] [M] Change in openvpn[release/2.6]: Set WINS servers via interactice service

2023-08-07 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos, selvanair, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/321?usp=email ) Change subject: Set WINS servers via interactice service .

[Openvpn-devel] [M] Change in openvpn[release/2.6]: Set WINS servers via interactice service

2023-08-07 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos, selvanair, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/321?usp=email ) Change subject: Set WINS servers via interactice service .

[Openvpn-devel] [S] Change in openvpn[master]: Add warning if a p2p NCP client connects to a p2mp server

2023-08-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/323?usp=email ) Change subject: Add warning if a p2p NCP client connects to a p2mp server

[Openvpn-devel] [S] Change in openvpn[master]: Add warning if a p2p NCP client connects to a p2mp server

2023-08-14 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/323?usp=email ) Change subject: Add warning if a p2p NCP client connects to a p2mp server

[Openvpn-devel] [M] Change in openvpn[master]: Remove ability to use configurations without TLS by default

2023-08-21 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/325?usp=email ) Change subject: Remove ability to use configurations without TLS by default ..

[Openvpn-devel] [S] Change in openvpn[master]: Remove last uses of inet_ntoa

2023-08-22 Thread flichtenheld (Code Review)
flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/326?usp=email ) Change subject: Remove last uses of inet_ntoa .. Remove last uses of inet_ntoa inet_ntoa is officially deprecated and in

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Support for long INFO/INFO_PRE messages

2023-09-04 Thread flichtenheld (Code Review)
Attention is currently required from: stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/327?usp=email ) Change subject: Support for long INFO/INFO_PRE messages .. Patch Set 1: Code

[Openvpn-devel] [S] Change in openvpn[master]: GHA: do not trigger builds in openvpn-build anymore

2023-09-05 Thread flichtenheld (Code Review)
flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/328?usp=email ) Change subject: GHA: do not trigger builds in openvpn-build anymore .. GHA: do not trigger builds in openvpn-build anymor

[Openvpn-devel] [M] Change in openvpn[master]: Various fixes for -Wconversion errors

2023-09-07 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/267?usp=email to review the following change. Change subject: Various fixes for -Wconversion errors ..

[Openvpn-devel] [M] Change in openvpn[master]: Various fixes for -Wconversion errors

2023-09-07 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/267?usp=email ) Change subject: Various fixes for -Wconversion errors .. Patch Set 3: (

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Warn user if INFO control command is too long

2023-09-12 Thread flichtenheld (Code Review)
Attention is currently required from: stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/329?usp=email ) Change subject: Warn user if INFO control command is too long .. Patch Set 1

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Warn user if INFO control command is too long

2023-09-12 Thread flichtenheld (Code Review)
Attention is currently required from: stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/329?usp=email ) Change subject: Warn user if INFO control command is too long .. Patch Set 1

[Openvpn-devel] [S] Change in openvpn[master]: Change type of frame.mss_fix to uint16_t

2023-09-12 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. Hello cron2, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/268?usp=email to review the following change. Change subject: Change type of frame.mss_fix to uint16_t

[Openvpn-devel] [M] Change in openvpn[master]: dns option: remove support for exclude-domains

2023-09-12 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/39?usp=email ) Change subject: dns option: remove support for exclude-domains ..

[Openvpn-devel] [M] Change in openvpn[master]: dns option: make server id/priority optional

2023-09-12 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/40?usp=email ) Change subject: dns option: make server id/priority optional .. d

[Openvpn-devel] [S] Change in openvpn[master]: Improve description of compat-mode

2023-09-12 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. plaisthos has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/34?usp=email ) Change subject: Improve description of compat-mode .. Improve description o

[Openvpn-devel] [S] Change in openvpn[master]: GHA: do not trigger builds in openvpn-build anymore

2023-09-14 Thread flichtenheld (Code Review)
Attention is currently required from: cron2. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/328?usp=email ) Change subject: GHA: do not trigger builds in openvpn-build anymore .. Patch

[Openvpn-devel] [S] Change in openvpn[master]: CMake: fix broken daemonization and syslog functionality

2023-09-15 Thread flichtenheld (Code Review)
Attention is currently required from: stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/341?usp=email ) Change subject: CMake: fix broken daemonization and syslog functionality ..

[Openvpn-devel] [XL] Change in openvpn[release/2.6]: CMake: backport CMake buildsystem from master to release/2.6

2023-09-19 Thread flichtenheld (Code Review)
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/315?usp=email ) Change subject: CMake: backport CMake buildsystem from master to release/2.6 .. Patch Set 1: (5 comments) Patchset: PS1

[Openvpn-devel] [S] Change in openvpn[master]: CMake: various small non-functional improvements

2023-09-19 Thread flichtenheld (Code Review)
flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/342?usp=email ) Change subject: CMake: various small non-functional improvements .. CMake: various small non-functional improvements The

[Openvpn-devel] [S] Change in openvpn[master]: CMake: various small non-functional improvements

2023-09-19 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/342?usp=email ) Change subject: CMake: various small non-functional improvements .. P

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Mock openvpn_exece on win32 also for test_tls_crypt

2023-09-19 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/313?usp=email ) Change subject: Mock openvpn_exece on win32 also for test_tls_crypt ...

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patch...

2023-09-20 Thread flichtenheld (Code Review)
flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/361?usp=email ) Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork .. dev-tools/gerrit-send-mail.

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patch...

2023-09-20 Thread flichtenheld (Code Review)
Attention is currently required from: cron2. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/361?usp=email ) Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork ...

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patch...

2023-09-20 Thread flichtenheld (Code Review)
Attention is currently required from: cron2. Hello cron2, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/361?usp=email to look at the new patch set (#2). Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patch...

2023-09-22 Thread flichtenheld (Code Review)
Attention is currently required from: cron2. Hello cron2, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/361?usp=email to look at the new patch set (#3). Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork

[Openvpn-devel] [M] Change in openvpn[master]: Remove --no-replay option

2023-09-22 Thread flichtenheld (Code Review)
flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/281?usp=email ) Change subject: Remove --no-replay option .. Remove --no-replay option Officially deprecated since v2.4. We have warned

[Openvpn-devel] [NoOp] Change in openvpn[master]: Improve description of compat-mode

2023-09-22 Thread flichtenheld (Code Review)
flichtenheld has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/34?usp=email ) Change subject: Improve description of compat-mode .. Abandoned merged with wrong Change-Id -- To view, visit http://gerrit.openvpn

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Mock openvpn_exece on win32 also for test_tls_crypt

2023-09-22 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/313?usp=email to look at the new patch set (#2). Change subject: Mock openvpn_exece on win32 also for test_tls_crypt ...

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: buffer: use memcpy in buf_catrunc

2023-09-22 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, flichtenheld. Hello cron2, d12fk, ordex, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/314?usp=email to look at the new patch set (#2). The change is no longer submittable: checks~ChecksSubmitRule is unsa

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Mock openvpn_exece on win32 also for test_tls_crypt

2023-09-22 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/313?usp=email ) Change subject: Mock openvpn_exece on win32 also for test_tls_crypt .. Patch

[Openvpn-devel] [XL] Change in openvpn[release/2.6]: CMake: backport CMake buildsystem from master to release/2.6

2023-09-26 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/315?usp=email ) Change subject: CMake: backport CMake buildsystem from master to release/2.6 .

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patch...

2023-09-26 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, flichtenheld. Hello cron2, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/361?usp=email to look at the new patch set (#4). Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patch...

2023-09-26 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, d12fk. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/361?usp=email ) Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork

[Openvpn-devel] [M] Change in openvpn[master]: Remove ability to use configurations without TLS by default

2023-10-07 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/325?usp=email ) Change subject: Remove ability to use configurations without TLS by default ..

[Openvpn-devel] [S] Change in openvpn[release/2.6]: dco: warn if DATA_V1 packets are sent to userspace

2023-10-07 Thread flichtenheld (Code Review)
Attention is currently required from: stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/368?usp=email ) Change subject: dco: warn if DATA_V1 packets are sent to userspace .. Patch

[Openvpn-devel] [S] Change in openvpn[master]: generate_auth_token: simplify code

2023-10-08 Thread flichtenheld (Code Review)
flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/310?usp=email ) Change subject: generate_auth_token: simplify code .. generate_auth_token: simplify code The previous code went through

[Openvpn-devel] [S] Change in openvpn[master]: Change type of frame.mss_fix to uint16_t

2023-10-08 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/268?usp=email to look at the new patch set (#4). Change subject: Change type of frame.mss_fix to uint16_t .

[Openvpn-devel] [S] Change in openvpn[master]: mss/mtu: make all size calculations use size_t

2023-10-08 Thread flichtenheld (Code Review)
flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/269?usp=email ) Change subject: mss/mtu: make all size calculations use size_t .. mss/mtu: make all size calculations use size_t Half of

[Openvpn-devel] [S] Change in openvpn[master]: Change type of frame.mss_fix to uint16_t

2023-10-08 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/268?usp=email ) Change subject: Change type of frame.mss_fix to uint16_t .. Patch

[Openvpn-devel] [S] Change in openvpn[master]: Add warning if a p2p NCP client connects to a p2mp server

2023-10-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/323?usp=email ) Change subject: Add warning if a p2p NCP client connects to a p2mp server

[Openvpn-devel] [XS] Change in openvpn[master]: Add warning for the --show-groups command that some groups are missing

2023-10-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/366?usp=email ) Change subject: Add warning for the --show-groups command that some groups are missing ..

[Openvpn-devel] [M] Change in openvpn[master]: Print server temp key details

2023-10-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/364?usp=email ) Change subject: Print server temp key details .. Patch Set 4: Code-Revie

[Openvpn-devel] [M] Change in openvpn[master]: Remove ability to use configurations without TLS by default

2023-10-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/325?usp=email ) Change subject: Remove ability to use configurations without TLS by default ..

[Openvpn-devel] [M] Change in openvpn[master]: Print SSL peer signature information in handshake debug details

2023-10-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/365?usp=email ) Change subject: Print SSL peer signature information in handshake debug details ..

[Openvpn-devel] [S] Change in openvpn[master]: Add warning if a p2p NCP client connects to a p2mp server

2023-10-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/323?usp=email ) Change subject: Add warning if a p2p NCP client connects to a p2mp server

[Openvpn-devel] [M] Change in openvpn[master]: Remove ability to use configurations without TLS by default

2023-10-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/325?usp=email ) Change subject: Remove ability to use configurations without TLS by default ..

[Openvpn-devel] [M] Change in openvpn[master]: Print peer temporary key details

2023-10-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/364?usp=email ) Change subject: Print peer temporary key details .. Patch Set 6: Code-Re

[Openvpn-devel] [M] Change in openvpn[master]: Print SSL peer signature information in handshake debug details

2023-10-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/365?usp=email ) Change subject: Print SSL peer signature information in handshake debug details ..

[Openvpn-devel] [M] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-18 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email ) Change subject: Add support for mbedtls 3.X.Y .. Patch Set 1: Code

[Openvpn-devel] [S] Change in openvpn[master]: Update README.mbedtls

2023-10-18 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/372?usp=email ) Change subject: Update README.mbedtls .. Patch Set 2: Code-Review+

[Openvpn-devel] [L] Change in openvpn[master]: Add compatibility functions for mbedtls 2.X.Y

2023-10-18 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/371?usp=email ) Change subject: Add compatibility functions for mbedtls 2.X.Y .. Patch Set 2:

[Openvpn-devel] [L] Change in openvpn[master]: Remove openssl engine method for loading the key

2023-10-18 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/373?usp=email ) Change subject: Remove openssl engine method for loading the key .. Patc

[Openvpn-devel] [XS] Change in openvpn[master]: Add --enable-werror to all platforms in Github Actions

2023-10-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/376?usp=email ) Change subject: Add --enable-werror to all platforms in Github Actions ..

[Openvpn-devel] [S] Change in openvpn[master]: Add undefined and abort on error to clang sanaitize builds

2023-10-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/375?usp=email ) Change subject: Add undefined and abort on error to clang sanaitize builds ...

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-20 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email ) Change subject: Add support for mbedtls 3.X.Y .. Patch Set 6: (3

[Openvpn-devel] [S] Change in openvpn[master]: Update README.mbedtls

2023-10-20 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/372?usp=email ) Change subject: Update README.mbedtls .. Patch Set 7: Code-Review+

[Openvpn-devel] [L] Change in openvpn[master]: Add support for mbedtls 3.X.Y

2023-10-24 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/370?usp=email ) Change subject: Add support for mbedtls 3.X.Y .. Patch Set 7: Code

[Openvpn-devel] [XS] Change in openvpn[master]: Add --enable-werror to all platforms in Github Actions

2023-10-25 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/376?usp=email ) Change subject: Add --enable-werror to all platforms in Github Actions ..

[Openvpn-devel] [S] Change in openvpn[master]: Fix building with cmake and mbed TLS

2023-10-30 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/377?usp=email ) Change subject: Fix building with cmake and mbed TLS .. Patch Set 1: Cod

[Openvpn-devel] [XS] Change in openvpn[master]: Remove CMake custom compiler flags for RELEASE and DEBUG build

2023-11-03 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/374?usp=email ) Change subject: Remove CMake custom compiler flags for RELEASE and DEBUG build ...

[Openvpn-devel] [L] Change in openvpn[master]: Remove support for NTLM v1 proxy authentication

2023-11-03 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/379?usp=email to review the following change. Change subject: Remove support for NTLM v1 proxy authentication

[Openvpn-devel] [S] Change in openvpn[master]: configure: allow to disable NTLM

2023-11-03 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/378?usp=email to review the following change. Change subject: configure: allow to disable NTLM ...

[Openvpn-devel] [L] Change in openvpn[master]: Remove support for NTLM v1 proxy authentication

2023-11-06 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/379?usp=email to look at the new patch set (#2). Change subject: Remove support for NTLM v1 proxy authentication ...

[Openvpn-devel] [S] Change in openvpn[master]: Change default of "topology" to "subnet"

2023-11-06 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/421?usp=email to review the following change. Change subject: Change default of "topology" to "subnet" ...

[Openvpn-devel] [M] Change in openvpn[master]: tun: use is_tun_p2p more consistently

2023-11-06 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/380?usp=email to review the following change. Change subject: tun: use is_tun_p2p more consistently ..

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Warn if pushed options require DHCP

2023-11-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/424?usp=email ) Change subject: Warn if pushed options require DHCP .. Patch Set

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Make --dns options apply for tap-windows6 driver

2023-11-10 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/423?usp=email ) Change subject: Make --dns options apply for tap-windows6 driver ...

[Openvpn-devel] [XS] Change in openvpn[master]: platform.c: Do not depend Windows build on HAVE_CHDIR

2023-11-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/425?usp=email to review the following change. Change subject: platform.c: Do not depend Windows build on HAVE_CHDIR ..

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Make --dns options apply for tap-windows6 driver

2023-11-13 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/423?usp=email ) Change subject: Make --dns options apply for tap-windows6 driver ...

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Warn if pushed options require DHCP

2023-11-13 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/424?usp=email ) Change subject: Warn if pushed options require DHCP .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: Enable key export with mbed TLS 3.x.y

2023-11-13 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/402?usp=email ) Change subject: Enable key export with mbed TLS 3.x.y .. Patch Set

[Openvpn-devel] [S] Change in openvpn[master]: Disable TLS 1.3 support with mbed TLS

2023-11-13 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/403?usp=email ) Change subject: Disable TLS 1.3 support with mbed TLS .. Patch Set

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Warn if pushed options require DHCP

2023-11-13 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/424?usp=email ) Change subject: Warn if pushed options require DHCP .. Patch Set

[Openvpn-devel] [S] Change in openvpn[master]: Warn if pushed options require DHCP

2023-11-13 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/428?usp=email ) Change subject: Warn if pushed options require DHCP .. Patch Set

[Openvpn-devel] [XS] Change in openvpn[master]: Make --dns options apply for tap-windows6 driver

2023-11-13 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/427?usp=email ) Change subject: Make --dns options apply for tap-windows6 driver ..

[Openvpn-devel] [M] Change in openvpn[master]: Enable key export with mbed TLS 3.x.y

2023-11-15 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/402?usp=email ) Change subject: Enable key export with mbed TLS 3.x.y .. Patch Set

[Openvpn-devel] [S] Change in openvpn[master]: Remove unused defined from configure and cmake config

2023-11-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/443?usp=email ) Change subject: Remove unused defined from configure and cmake config ..

[Openvpn-devel] [XS] Change in openvpn[master]: Add check for nice in cmake config

2023-11-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/444?usp=email ) Change subject: Add check for nice in cmake config .. Patch Set 1: Code-

[Openvpn-devel] [M] Change in openvpn[master]: Remove compat versionhelpers.h and remove cmake/configure check for it

2023-11-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/445?usp=email ) Change subject: Remove compat versionhelpers.h and remove cmake/configure check for it ..

[Openvpn-devel] [XS] Change in openvpn[master]: Deprecate tls-exit option

2023-11-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/447?usp=email ) Change subject: Deprecate tls-exit option .. Patch Set 1: Code-Review-1

[Openvpn-devel] [XS] Change in openvpn[master]: Log SSL alerts more prominently

2023-11-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/448?usp=email ) Change subject: Log SSL alerts more prominently .. Patch Set 1: Code-Rev

[Openvpn-devel] [M] Change in openvpn[master]: Allow the TLS session to send out TLS alerts

2023-11-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/449?usp=email ) Change subject: Allow the TLS session to send out TLS alerts .. Patch Se

[Openvpn-devel] [S] Change in openvpn[master]: Introduce report_command_status helper function

2023-11-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/450?usp=email ) Change subject: Introduce report_command_status helper function .. Patch

[Openvpn-devel] [XS] Change in openvpn[master]: Remove unused function prototype crypto_adjust_frame_parameters

2023-11-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/451?usp=email ) Change subject: Remove unused function prototype crypto_adjust_frame_parameters ..

[Openvpn-devel] [XS] Change in openvpn[master]: Deprecate tls-exit option

2023-11-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/447?usp=email ) Change subject: Deprecate tls-exit option .. Patch Set 1: (1 comment)

[Openvpn-devel] [M] Change in openvpn[master]: Remove compat versionhelpers.h and remove cmake/configure check for it

2023-11-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/445?usp=email ) Change subject: Remove compat versionhelpers.h and remove cmake/configure check for it ..

[Openvpn-devel] [S] Change in openvpn[master]: Remove unused/uneeded defines from configure and cmake config

2023-11-20 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/443?usp=email ) Change subject: Remove unused/uneeded defines from configure and cmake config

  1   2   3   4   5   6   7   8   9   >