flichtenheld has uploaded this change for review. (
http://gerrit.openvpn.net/c/openvpn/+/319?usp=email )
Change subject: route: Fix overriding return value of add_route3
......................................................................
route: Fix overriding return value of add_route3
The return value of add_bypass_routes overwrites
the return value of add_route3 instead of combining
them.
Coverity: CID 1539180 (#1 of 1): Unused value (UNUSED_VALUE)
Change-Id: I78f92f363fe203af5661c6958b2417ea30f7055c
Signed-off-by: Frank Lichtenheld <fr...@lichtenheld.com>
---
M src/openvpn/route.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/19/319/1
diff --git a/src/openvpn/route.c b/src/openvpn/route.c
index 90e981e..9212186 100644
--- a/src/openvpn/route.c
+++ b/src/openvpn/route.c
@@ -1062,7 +1062,7 @@
/* route DHCP/DNS server traffic through original default gateway
*/
ret = add_bypass_routes(&rl->spec.bypass, rl->rgi.gateway.addr,
tt, flags,
- &rl->rgi, es, ctx);
+ &rl->rgi, es, ctx) && ret;
if (rl->flags & RG_REROUTE_GW)
{
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/319?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I78f92f363fe203af5661c6958b2417ea30f7055c
Gerrit-Change-Number: 319
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
