Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/323?usp=email )
Change subject: Add warning if a p2p NCP client connects to a p2mp server ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: LGTM, but I find it very difficult to see whether this is the right place for the check :/ File src/openvpn/ssl_ncp.c: http://gerrit.openvpn.net/c/openvpn/+/323/comment/ddecee43_db5699c2 : PS1, Line 262: /* For client doing the newer version of NCP (that send IV_CIPHER) Since you have done other drive-by typo fixes, should say "clients" here. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/323?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I85ae4e1167e1395b4f59d5d0ecf6c38befcaa8a7 Gerrit-Change-Number: 323 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Thu, 10 Aug 2023 16:25:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
