Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/445?usp=email )
Change subject: Remove compat versionhelpers.h and remove cmake/configure check for it ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/445/comment/ac1dbdba_a1bab3b8 : PS1, Line 10: old msvc-config.h that always had it present. Also interactive.c includes interactive.c does not include it without the check? Patchset: PS1: Code looks good, but commit message seems wrong? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/445?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9c85ccab6d51064ebff2c391740ba8c2d044ed1a Gerrit-Change-Number: 445 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Mon, 20 Nov 2023 11:27:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
