Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/445?usp=email )

Change subject: Remove compat versionhelpers.h and remove cmake/configure check 
for it
......................................................................


Patch Set 2: Code-Review+2

(3 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/445/comment/6d2ffebd_108c2911 :
PS2, Line 11: Remove also the comapt implementation taken from mingw. All our 
current
"compat"


http://gerrit.openvpn.net/c/openvpn/+/445/comment/96f8a775_b2f3fbf2 :
PS2, Line 12: build environment already have that header in place.
"environments"


Patchset:

PS2:
Two little typos in the commit message. But code looks good.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/445?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9c85ccab6d51064ebff2c391740ba8c2d044ed1a
Gerrit-Change-Number: 445
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Comment-Date: Mon, 20 Nov 2023 12:06:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to