Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/373?usp=email )
Change subject: Remove openssl engine method for loading the key ...................................................................... Patch Set 1: Code-Review-1 (5 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/373/comment/e17b8596_9a54a763 : PS1, Line 10: deprecated since OpenSSL 3.0 and James Bottomlehy has not agreed "Bottomley" http://gerrit.openvpn.net/c/openvpn/+/373/comment/95a52a7e_866bd6f6 : PS1, Line 11: to the proposed license chagne. He is also okay with removing "change" http://gerrit.openvpn.net/c/openvpn/+/373/comment/4669cbdb_a38c78ba : PS1, Line 12: with the feature from the current code base as it is obsolete with remove "with" http://gerrit.openvpn.net/c/openvpn/+/373/comment/bea8f16e_17b2230f : PS1, Line 14: I think the commit message should mention the original commit that introduced the feature. Patchset: PS1: Commit message needs some work. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/373?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2d353a0cea0a62f289b8c1060244df66dd7a14cb Gerrit-Change-Number: 373 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Wed, 18 Oct 2023 12:50:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
