Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/424?usp=email )
Change subject: Warn if pushed options require DHCP ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/424/comment/a79c076d_2d9c9271 : PS2, Line 2489: const char *prefix = "Some dhcp-options (or --dns) require DHCP server"; In my original comment I wrote "same above". What I tried to say with that is that at least the "Some --dhcp-option or --dns options" improvement should also be applied to this part of the patch. Will be more verbose in the future 😊 File src/openvpn/tun.c: http://gerrit.openvpn.net/c/openvpn/+/424/comment/fd60c067_151f1700 : PS1, Line 6832: msg(M_WARN, "Some dhcp-options or --dns require DHCP server, which is not supported by the selected %s driver. Expect them not to work.", > How about: […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/424?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: Ie512544329a91fae15409cb18f29d8be617051a1 Gerrit-Change-Number: 424 Gerrit-PatchSet: 2 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Mon, 13 Nov 2023 11:57:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
