Attention is currently required from: plaisthos, stipa.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/424?usp=email )

Change subject: Warn if pushed options require DHCP
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Patchset:

PS1:
Text could use some improvement.


File src/openvpn/tun.c:

http://gerrit.openvpn.net/c/openvpn/+/424/comment/505f0e6f_dbd17325 :
PS1, Line 6832:         msg(M_WARN, "Some dhcp-options or --dns require DHCP 
server, which is not supported by the selected %s driver. Expect them not to 
work.",
How about:

Some --dhcp-option or --dns options require DHCP server, which is not supported 
by the selected %s driver. They will be ignored.

Same above.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/424?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: Ie512544329a91fae15409cb18f29d8be617051a1
Gerrit-Change-Number: 424
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: stipa <[email protected]>
Gerrit-Comment-Date: Fri, 10 Nov 2023 13:49:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to