On Wed, 11 Jun 2025 19:17:24 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Wed, 11 Jun 2025 19:17:24 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
On Wed, 11 Jun 2025 19:17:24 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
On Tue, 10 Jun 2025 18:49:20 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
On Wed, 11 Jun 2025 18:26:56 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> text origin
>
> tests/system/src/test/java/test/robot/javafx/scene/TextFlow_TextLayout_Test.java
> line 81:
>
>>
On Tue, 10 Jun 2025 18:49:20 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Thu, 5 Jun 2025 21:42:46 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
On Thu, 5 Jun 2025 21:31:59 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/TextLineInfo.java
>> line 42:
>>
>>> 40: *
>>> 41: * {@code minY} - the ascent of the line (negative).
>>> 42: * The ascent of the line is the max ascent of all fonts
On Thu, 5 Jun 2025 21:01:52 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 61 commits:
>>
>> - cleanup
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>>
On Thu, 5 Jun 2025 21:04:43 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 61 commits:
>>
>> - cleanup
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>>
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Thu, 5 Jun 2025 21:00:49 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 61 commits:
>>
>> - cleanup
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>>
On Tue, 27 May 2025 15:06:43 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Thu, 22 May 2025 21:47:22 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 59 commits:
>>
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>> - cleanup
>>
On Thu, 22 May 2025 19:00:19 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
On Thu, 22 May 2025 17:59:40 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1123:
>>
>>> 1121: * @since 25
>>> 1122: */
>>> 1123: public final PathElement[] getStrikeThroughShape(int start, int
>>> end) {
>>
>> I just noticed
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Thu, 22 May 2025 00:05:29 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 55 commits:
>>
>> - review comments
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Thu, 22 May 2025 15:16:57 GMT, Andy Goryachev wrote:
>> The point is that it's less complicated to have self-describing, strongly
>> typed, and compiler-checked code. Your code is more complicated because it's
>> brittle, untyped, and less robust against refactoring.
>>
>> Just to make sure
On Thu, 22 May 2025 14:40:43 GMT, Andy Goryachev wrote:
>> Instead of returning `float[]` here, this would be a good candidate to
>> return a discriminated union instead, something like:
>>
>> sealed interface CaretGeometry {
>> record Single(float x, float y, float height) implements Caret
On Thu, 22 May 2025 15:05:02 GMT, Michael Strauß wrote:
>> I would have agreed with the proposed change, if it were a public API.
>>
>> This is an internal method, so it was made as low level as possible. The
>> return value is documented, and the consumer is another part of internal
>> code.
On Thu, 22 May 2025 00:05:29 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 55 commits:
>>
>> - review comments
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout
On Wed, 21 May 2025 23:49:29 GMT, Michael Strauß wrote:
>> This method does not throw any exceptions, so none are specified.
>
> Instead of returning `float[]` here, this would be a good candidate to return
> a discriminated union instead, something like:
>
> sealed interface CaretGeometry {
>
On Wed, 21 May 2025 22:52:36 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
On Mon, 10 Mar 2025 16:08:31 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/text/TextLayout.java
>> line 256:
>>
>>> 254: * @return the caret geometry
>>> 255: */
>>> 256: public float[] getCaretGeometry(int offset, boolean leading);
>>
>
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Fri, 2 May 2025 16:57:02 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 2100:
>>
>>> 2098: * While there is no general guarantee that successive
>>> invocations of this method return the same instance,
>>> 2099: * it is safe to
On Fri, 2 May 2025 17:42:45 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
On Fri, 2 May 2025 17:42:45 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Mon, 7 Apr 2025 19:37:27 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
On Thu, 1 May 2025 18:58:47 GMT, Kevin Rushforth wrote:
>> We've got https://bugs.openjdk.org/browse/JDK-8341438 and a possibility of a
>> regression if we change the existing methods.
>>
>> I would very much like to get your thoughts on this.
>
> I also would like to hear thoughts about compat
On Thu, 1 May 2025 18:54:53 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sealed
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/CaretInfo.java line
> 60:
>
>> 58: * @ret
On Thu, 1 May 2025 18:39:44 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sealed
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/LayoutInfo.java line
> 57:
>
>> 55: * @re
On Thu, 1 May 2025 18:04:15 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sealed
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/LayoutInfo.java line
> 36:
>
>> 34: * as well
On Thu, 1 May 2025 17:59:23 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sealed
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 2100:
>
>> 2098: * While th
On Thu, 1 May 2025 15:39:03 GMT, Kevin Rushforth wrote:
>> I understand the argument for `TextLineInfo`, I guess I'm looking more at
>> `LayoutInfo` here. My question is whether it is really the best choice to
>> sacrifice local consistency within a single class just to have it look more
>> si
On Thu, 1 May 2025 15:41:07 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sealed
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 866:
>
>> 864: /**
>> 865:
On Wed, 5 Feb 2025 21:21:09 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/LayoutInfo.java line
>> 91:
>>
>>> 89: * @return the immutable list of {@code Rectangle2D} objects
>>> 90: */
>>> 91: public abstract List selectionShape(int start, in
On Mon, 7 Apr 2025 19:37:27 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
On Thu, 1 May 2025 19:36:51 GMT, Michael Strauß wrote:
>> what's a "tidy" and is it a part of our build/validation?
>
> The closing `` tag is not required in HTML, and Javadoc doesn't seem to
> object. Is this a requirement of another tool? We're using `` without a
> closing tag in many places
On Fri, 11 Apr 2025 15:00:20 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/TextLineInfo.java
>> line 36:
>>
>>> 34: * @param bounds the bounds of the text line, in local coordinates:
>>> 35: *
>>> 36: *
>>
>> We usually indent with 4 spaces.
>
> i
On Thu, 1 May 2025 15:50:22 GMT, Kevin Rushforth wrote:
>> in this economy, spaces are expensive ;-)
>
> More importantly, you need ` tags after each item. As it is, I doubt it
> would pass "tidy".
what's a "tidy" and is it a part of our build/validation?
-
PR Review Comment: http
On Thu, 1 May 2025 19:20:07 GMT, Andy Goryachev wrote:
>> More importantly, you need ` tags after each item. As it is, I doubt
>> it would pass "tidy".
>
> what's a "tidy" and is it a part of our build/validation?
The closing `` tag is not required in HTML, and Javadoc doesn't seem to
object.
On Mon, 7 Apr 2025 19:37:27 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
On Mon, 7 Apr 2025 19:14:40 GMT, Michael Strauß wrote:
>> `TextLineInfo` is a record, I don't want to add duplicate getXXX() aliases
>> there.
>>
>> The other (in `LayoutInfo`) are modeled after `Text`/`TextFlow` (e.g.
>> `underlineShape()`), I have no problem with any of these. I don't think
On Thu, 1 May 2025 18:13:03 GMT, Kevin Rushforth wrote:
>> Good point. The word 'shape' might be confusing, although it is still
>> correct in human terms (it is a shape, after all). I think it's ok, but we
>> could use the word "geometry" for these methods `selectionGeometry` /
>> `strikeTh
On Wed, 5 Feb 2025 21:18:20 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/LayoutInfo.java line
>> 91:
>>
>>> 89: * @return the immutable list of {@code Rectangle2D} objects
>>> 90: */
>>> 91: public abstract List selectionShape(int start, in
On Fri, 11 Apr 2025 08:28:40 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sealed
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/TextLineInfo.java
> line 36:
>
>> 34: * @para
On Mon, 7 Apr 2025 19:37:27 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Sat, 5 Apr 2025 07:49:07 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 48 commits:
>>
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>> - Merge remote-
On Mon, 7 Apr 2025 18:54:00 GMT, Michael Strauß wrote:
> I think a class should always be final or sealed by default
contr-argument: testing. having extendable classes makes it easier to mock,
although in the case of a platform your argument carries greater weight.
I can make it `sealed`.
--
On Sat, 5 Apr 2025 07:53:35 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 48 commits:
>>
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>> - Merge remote-
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Mon, 7 Apr 2025 18:39:25 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/CaretInfo.java line
>> 62:
>>
>>> 60: * {@code (index < 0 || index > getSegmentCount())}
>>> 61: */
>>> 62: public abstract Rectangle2D getSegmentAt(int index);
>>
On Mon, 7 Apr 2025 18:30:47 GMT, Andy Goryachev wrote:
> > Can this class be sealed?
>
> Theoretically, yes, but what problem would that solve?
>
> I can understand when sealing would make the platform more secure, but in
> this case I see no value whatsoever. Could you give me an example wher
On Fri, 4 Apr 2025 14:42:20 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
On Mon, 10 Mar 2025 16:25:40 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/LayoutInfo.java line
>> 41:
>>
>>> 39: * @since 25
>>> 40: */
>>> 41: public abstract class LayoutInfo {
>>
>> Any exceptions thrown by methods of this class?
>
> only `public a
On Fri, 4 Apr 2025 14:42:20 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Mon, 10 Mar 2025 16:30:25 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Sat, 8 Mar 2025 08:23:41 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 42 commits:
>>
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>> - review commen
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Wed, 5 Mar 2025 21:18:39 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
On Sat, 8 Mar 2025 08:29:19 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 42 commits:
>>
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>> - review commen
On Mon, 10 Mar 2025 17:04:22 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 44 commits:
>>
>> - review comments
>> - Merge remote-tracking branch 'origin/master' into ag.text.layout.
On Wed, 5 Mar 2025 21:18:39 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
On Wed, 5 Mar 2025 21:18:39 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
On Wed, 5 Feb 2025 20:33:09 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismCaretInfo.java
>> line 48:
>>
>>> 46: @Override
>>> 47: public Rectangle2D getSegmentAt(int index) {
>>> 48: return parts[index];
>>
>> do we need a bound ch
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Wed, 5 Feb 2025 13:08:07 GMT, Jose Pereda wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 25 25
>
> Overall it looks really good, the new API is quite useful in some scenarios.
> I've done some successful tes
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Tue, 4 Feb 2025 18:37:36 GMT, Jose Pereda wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 25 25
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/text/TextLayout.java
> line 268:
>
>> 266:
On Tue, 4 Feb 2025 18:47:14 GMT, Jose Pereda wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 25 25
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/text/TextLayout.java
> line 83:
>
>> 81: @Fu
On Wed, 5 Feb 2025 13:07:50 GMT, Jose Pereda wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 25 25
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismLayoutInfo.java
> line 57:
>
>> 55: publ
On Thu, 16 Jan 2025 19:34:06 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
On Thu, 16 Jan 2025 19:34:06 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
On Thu, 16 Jan 2025 19:34:06 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Tue, 10 Dec 2024 23:36:30 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Fri, 22 Nov 2024 16:19:50 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
On Fri, 25 Oct 2024 14:14:08 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 14 additional
>> comm
On Fri, 25 Oct 2024 14:27:25 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 14 additional
>> comm
On Fri, 25 Oct 2024 14:08:40 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 14 additional
>> comm
1 - 100 of 126 matches
Mail list logo
