On Wed, 5 Feb 2025 13:07:50 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 25 25
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismLayoutInfo.java
> line 57:
>
>> 55: public Rectangle2D getBounds(boolean includeLineSpacing) {
>> 56: BaseBounds b = layout.getBounds();
>> 57: Insets m = insets();
>
> See my comments below about adding the insets to the layout information.
> Maybe we could also add another boolean `includeInsets` for this?
Good question! I don't think this is needed: the call returns the layout
bounds (in the owning node coordinate system).
The insets only change the position of the layout within the owning node,
unlike lineSpacing which actually changes the shape by adding or removing the
last line spacing.
I think this method is ok as is.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1596#discussion_r1943630977
