On Thu, 1 May 2025 18:13:03 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Good point. The word 'shape' might be confusing, although it is still >> correct in human terms (it is a shape, after all). I think it's ok, but we >> could use the word "geometry" for these methods `selectionGeometry` / >> `strikeThroughGeometry` / `underlineGeometry`, what do other people think? >> >> As for using `javafx.scene.shape.Rectangle` - it is too heavy of an object, >> with properties and everything, it's not what we ask from this method. > > Yeah, it might be better to use a different name. "geometry" seems fine to > me. Or maybe "bounds" although it's a list of bounds, so that's a little less > clear. I like "geometry" the best so far. > > If we do this, then you could even add the "get" at the beginning of the name > (as suggested by Michael), since it would no longer duplicate the equivalent > name in Text/TextFlow. I don't have a strong opinion either way on this one. I like the idea of `getX*Geometry()`, to further distance the new API from the buggy ones in `Text`/`TextFlow`. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1596#discussion_r2070680024
