On Thu, 5 Jun 2025 21:01:52 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 61 commits: >> >> - cleanup >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - cleanup >> - removed getStrikeThroughShape >> - caret geometry >> - review comments >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - review comments >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - ... and 51 more: https://git.openjdk.org/jfx/compare/9950d33c...de1016be > > modules/javafx.graphics/src/main/java/javafx/scene/text/TextLineInfo.java > line 51: > >> 49: * {@code height} - the height of the line. >> 50: * The height of the line is sum of the max ascent, max descent, and >> 51: * max line gap of all the fonts in the line. > > Shouldn't that be "glyphs" not "fonts"? Nope. It's correct as is. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1596#discussion_r2138396329
