On Mon, 10 Mar 2025 17:04:22 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 44 commits: >> >> - review comments >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - review comments >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - 25 25 >> - Merge branch 'master' into ag.text.layout.api >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - Merge branch 'master' into ag.text.layout.api >> - ... and 34 more: https://git.openjdk.org/jfx/compare/1c3cfcb8...0ad6f66d > > modules/javafx.graphics/src/main/java/javafx/scene/text/CaretInfo.java line > 59: > >> 57: * @param index the line index >> 58: * @return the bounds of the caret segment >> 59: * @throws IndexOutOfBoundsException if the index is outside of the >> range if the index is out of range > > I think this sentence repeats the same thing twice, maybe check again. You > can probably just say `if the index is out of range {@code (...)}`. daylight saving time strikes! thanks for noticing. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1596#discussion_r1987705155
