On Thu, 1 May 2025 18:04:15 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> sealed
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/LayoutInfo.java line
> 36:
>
>> 34: * as well as geometry of other shapes derived from the layout
>> (selection, underline, etc.).
>> 35: * <p>
>> 36: * The information obtained via this object may change after the next
>> layout cycle, which may come as a result
>
> Since this is a view of the layout info for the current layout pass, do you
> think something like the following would be clearer:
>
> "The information obtained via this object is stable until the next layout
> cycle. It may change after the next layout cycle, which ..."
re-phrased to make it clearer:
* Provides a snapshot of the text layout geometry in a {@code Text} or a
{@code TextFlow} node,
* such as break up of the text into lines, as well as other shapes derived
from the layout
* (selection, underline, etc.).
* <p>
* The information in this object is valid until the next layout cycle.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1596#discussion_r2071904232
