On Sat, 5 Apr 2025 07:49:07 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 48 commits: >> >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - twice >> - tests >> - review comments >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - review comments >> - Merge remote-tracking branch 'origin/master' into ag.text.layout.api >> - 25 25 >> - ... and 38 more: https://git.openjdk.org/jfx/compare/76282bcf...33cf88d8 > > modules/javafx.graphics/src/main/java/javafx/scene/text/TextLineInfo.java > line 36: > >> 34: * @param bounds the bounds of the text line, in local coordinates: >> 35: * <ul> >> 36: * <li> > > What do you think about indenting the `<ul>` (so that it's clearer that it > belongs to the `@param` tag), as well as dropping the closing `</li>` and > indent the `<li>` elements to make them stand out better: > > > @param bounds the bounds of the text line, in local coordinates: > <ul> > <li>{@code minX} - the x origin of the line (relative to the > layout). > The x origin is defined by TextAlignment of the text layout, > always zero > for left-aligned text. > <li>{@code minY} - the ascent of the line (negative). > The ascent of the line is the max ascent of all fonts in the > line. > ... > > > > I find this formatting to be more readable in source code form. good idea ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1596#discussion_r2031790281
