Re: RFR: 8342454: Remove calls to doPrivileged in javafx.graphics/com.sun.glass [v2]

On Wed, 6 Nov 2024 15:37:23 GMT, Kevin Rushforth wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update based on review comments > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/Accessible.java line >

Re: RFR: 8342454: Remove calls to doPrivileged in javafx.graphics/com.sun.glass [v3]

> This PR removes AccessController.doPrivileged() calls in > javafx.graphics/com.sun.glass. It is part of umbrella task > [JDK-8342441](https://bugs.openjdk.org/browse/JDK-8342441). > > Also wherever classes are implementing PrivilegedAction they are replaced > with java.util.Supplier and get()

Re: RFR: 8339603: Seal the class hierarchy of Node, Camera, LightBase, Shape, Shape3D [v7]

> None of these classes can be extended by user code, and any attempt to do so > will fail at runtime with an exception. For this reason, we can seal the > class hierarchy and remove the run-time checks to turn this into a > compile-time error instead. > > In some cases, `Node` and `Shape` are

Re: RFR: 8306707: Support pluggable image loading via javax.imageio [v17]

> This PR is an improved version of #1093. > > JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image > loaders. It has been a long-standing request to support more image formats, > most notably (but not limited to) SVG. However, adding more built-in image > loaders is a signifi

Re: RFR: 8313424: JavaFX controls in the title bar [v26]

> Implementation of [`EXTENDED` stage > style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 33 commits: - Merge branch 'master' into feature/extended

Re: RFR: 8313424: JavaFX controls in the title bar [v21]

On Tue, 5 Nov 2024 18:54:11 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> stylistic changes > > modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.java line 83: > >> 81: *

Re: RFR: 8313424: JavaFX controls in the title bar [v21]

On Tue, 5 Nov 2024 18:48:00 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> stylistic changes > > modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBarBase.java > line 190: > >

Re: RFR: 8313424: JavaFX controls in the title bar [v25]

> Implementation of [`EXTENDED` stage > style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: WindowControlsOverlay snapping - Changes: - all: https:

Re: RFR: 8313424: JavaFX controls in the title bar [v19]

On Mon, 4 Nov 2024 23:36:21 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 23 commits: >> >> - Merge branch 'master' into feature/extended-window >> - Merge branch 'master' into feat

Re: RFR: 8313424: JavaFX controls in the title bar [v19]

On Tue, 5 Nov 2024 16:25:08 GMT, Andy Goryachev wrote: >> What do you mean with growing and shrinking? >> >> An application can add a single `GridPane` to `HeaderBar.center`, and set >> its prefWidth to `POSITIVE_INFINITY`. This will extend the `GridPane` across >> the entire width of the head

Re: RFR: 8313424: JavaFX controls in the title bar [v24]

> Implementation of [`EXTENDED` stage > style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: HeaderBar javadoc change - Changes: - all: https://git.

Re: RFR: 8313424: JavaFX controls in the title bar [v19]

On Tue, 5 Nov 2024 16:32:47 GMT, Andy Goryachev wrote: >> The components can't be too large to fit: >> `{@code HeaderBar} honors the minimum, preferred, and maximum sizes of its >> children.` > > I want to know what happens when the layout is over-constrained. For > example, consider the layou

Re: RFR: 8313424: JavaFX controls in the title bar [v19]

On Tue, 5 Nov 2024 16:19:50 GMT, Andy Goryachev wrote: >> It links directly to `StageStyle.EXTENDED`, which contains lots of >> information. I don't think we need it here. >> >> By the way, there are no support levels. The feature is supported in its >> entirety, as specified, on all desktop p

Re: RFR: 8313424: JavaFX controls in the title bar [v19]

On Mon, 4 Nov 2024 20:33:42 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 23 commits: >> >> - Merge branch 'master' into feature/extended-window >> - Merge branch 'master' into feat

Re: RFR: 8313424: JavaFX controls in the title bar [v19]

On Mon, 4 Nov 2024 23:01:03 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 23 commits: >> >> - Merge branch 'master' into feature/extended-window >> - Merge branch 'master' into feat

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v3]

On Wed, 6 Nov 2024 22:09:31 GMT, Andy Goryachev wrote: >> Public focus traversal API for use in custom controls. >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md >> >> This is a lightweight change that only adds the public API for focus >> t

Re: Prioritized event handlers

Dear Michael: What happened to this proposal? I would like to restart the discussion, if possible. More specifically, I would like to discuss the following topics: 1. the reason the discussion was started was due to "priority inversion" problem in Controls/Skins, ex.: JDK-8231245

Re: RFR: 8301121: RichTextArea Control (Incubator) [v37]

On Wed, 6 Nov 2024 11:14:48 GMT, Ambarish Rapte wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 52 commits: >> >> - readme >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >>

Re: RFR: 8301121: RichTextArea Control (Incubator) [v37]

On Wed, 6 Nov 2024 11:03:50 GMT, Ambarish Rapte wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 52 commits: >> >> - readme >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >>

Re: RFR: 8301121: RichTextArea Control (Incubator) [v37]

On Wed, 6 Nov 2024 10:42:47 GMT, Ambarish Rapte wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 52 commits: >> >> - readme >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >>

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v3]

On Wed, 6 Nov 2024 22:09:31 GMT, Andy Goryachev wrote: >> Public focus traversal API for use in custom controls. >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md >> >> This is a lightweight change that only adds the public API for focus >> t

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v3]

> Public focus traversal API for use in custom controls. > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md > > This is a lightweight change that only adds the public API for focus > traversal, containing neither the public API for the traversal p

Re: RFR: 8306707: Support pluggable image loading via javax.imageio [v15]

On Wed, 6 Nov 2024 21:26:30 GMT, Kevin Rushforth wrote: >> I'm not so sure about this, since there's already "iio" in in the name. > > How about one of the following as an alternative? > > * com.sun.javafx.iio.java2d > * com.sun.javafx.iio.j2d > * com.sun.javafx.iio.desktop > > That's roughly i

Re: RFR: 8306707: Support pluggable image loading via javax.imageio [v16]

> This PR is an improved version of #1093. > > JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image > loaders. It has been a long-standing request to support more image formats, > most notably (but not limited to) SVG. However, adding more built-in image > loaders is a signifi

Re: RFR: 8306707: Support pluggable image loading via javax.imageio [v15]

On Wed, 6 Nov 2024 18:46:38 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/test/addExports line 22: >> >>> 20: --add-exports javafx.graphics/com.sun.javafx.iio=ALL-UNNAMED >>> 21: --add-exports javafx.graphics/com.sun.javafx.iio.png=ALL-UNNAMED >>> 22: --add-exports javafx.graphics/co

Re: RFR: 8313424: JavaFX controls in the title bar [v21]

On Wed, 6 Nov 2024 18:47:18 GMT, Andy Goryachev wrote: > > Can you mark conversations resolved > > we are hitting the a github design problem here - as you correctly expect, > the originator should, in theory, be able to mark conversation as resolved, > but the only person who could is the PR

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v2]

On Wed, 6 Nov 2024 20:49:20 GMT, Andy Goryachev wrote: >> Public focus traversal API for use in custom controls. >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md >> >> This is a lightweight change that only adds the public API for focus >> t

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v2]

On Wed, 6 Nov 2024 20:49:20 GMT, Andy Goryachev wrote: >> Public focus traversal API for use in custom controls. >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md >> >> This is a lightweight change that only adds the public API for focus >> t

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v2]

> Public focus traversal API for use in custom controls. > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md > > This is a lightweight change that only adds the public API for focus > traversal, containing neither the public API for the traversal p

Re: RFR: 8306707: Support pluggable image loading via javax.imageio [v15]

On Sat, 2 Nov 2024 05:02:20 GMT, Michael Strauß wrote: >> This PR is an improved version of #1093. >> >> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image >> loaders. It has been a long-standing request to support more image formats, >> most notably (but not limited to) SV

Re: RFR: 8339603: Seal the class hierarchy of Node, Camera, LightBase, Shape, Shape3D [v6]

> None of these classes can be extended by user code, and any attempt to do so > will fail at runtime with an exception. For this reason, we can seal the > class hierarchy and remove the run-time checks to turn this into a > compile-time error instead. > > In some cases, `Node` and `Shape` are

Re: RFR: 8313424: JavaFX controls in the title bar [v21]

On Tue, 5 Nov 2024 20:22:01 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> stylistic changes > > please link your JEP from this PR @andy-goryachev-oracle Can you mark conversations resolved

Re: RFR: 8313424: JavaFX controls in the title bar [v21]

On Tue, 5 Nov 2024 19:03:41 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> stylistic changes > > modules/javafx.graphics/src/main/native-glass/mac/GlassViewDelegate.m line > 1336: > >> 1334

Re: RFR: 8313424: JavaFX controls in the title bar [v21]

On Wed, 6 Nov 2024 18:41:38 GMT, Michael Strauß wrote: > Can you mark conversations resolved we are hitting the a github design problem here - as you correctly expect, the originator should, in theory, be able to mark conversation as resolved, but the only person who could is the PR submitter.

Re: RFR: 8306707: Support pluggable image loading via javax.imageio [v15]

On Wed, 6 Nov 2024 10:32:52 GMT, Jayathirth D V wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> revert doc change > > modules/javafx.graphics/src/test/addExports line 22: > >> 20: --add-exports javafx.graphics/c

Re: RFR: 8313424: JavaFX controls in the title bar [v23]

> Implementation of [`EXTENDED` stage > style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: refactor performWindowDrag - Changes: - all: https://gi

RFR: 8091673: Public focus traversal API for use in custom controls

Public focus traversal API for use in custom controls. https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md This is a lightweight change that only adds the public API for focus traversal, containing neither the public API for the traversal policy (#1555

Re: RFR: 8091673: Public focus traversal API for use in custom controls (with the traversal policy hidden) [v9]

On Thu, 31 Oct 2024 14:58:12 GMT, Andy Goryachev wrote: >> Public focus traversal API for use in custom controls >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md >> >> This work is loosely based on the patch >> https://cr.openjdk.org/~jgiles/

Withdrawn: 8091673: Public focus traversal API for use in custom controls (with the traversal policy hidden)

On Fri, 18 Oct 2024 19:20:05 GMT, Andy Goryachev wrote: > Public focus traversal API for use in custom controls > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md > > This work is loosely based on the patch > https://cr.openjdk.org/~jgiles/806167

Withdrawn: 8090456: Focus Management

On Tue, 3 Sep 2024 19:09:15 GMT, Andy Goryachev wrote: > Public APIs for focus traversal and the focus traversal policy: > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md > > This work is loosely based on the patch > https://cr.openjdk.org/~jgiles/

Re: RFR: 8342454: Remove calls to doPrivileged in javafx.graphics/com.sun.glass [v2]

On Wed, 6 Nov 2024 05:13:48 GMT, Jayathirth D V wrote: >> This PR removes AccessController.doPrivileged() calls in >> javafx.graphics/com.sun.glass. It is part of umbrella task >> [JDK-8342441](https://bugs.openjdk.org/browse/JDK-8342441). >> >> Also wherever classes are implementing Privilege

Re: [External] : Re: Proposal: JavaFX Incubator Modules

As I see it, there are three different, but at least somewhat overlapping, ways to get non-final functionality into the hands of developers for testing: 1. Experimental EA test build from a sandbox branch -- a parallel build, distinct from jfx mainline builds A sandbox branch (which is equiv

Re: RFR: 8342454: Remove calls to doPrivileged in javafx.graphics/com.sun.glass [v2]

On Wed, 6 Nov 2024 05:13:48 GMT, Jayathirth D V wrote: >> This PR removes AccessController.doPrivileged() calls in >> javafx.graphics/com.sun.glass. It is part of umbrella task >> [JDK-8342441](https://bugs.openjdk.org/browse/JDK-8342441). >> >> Also wherever classes are implementing Privilege

Re: RFR: 8342459: Remove calls to doPrivileged in javafx.base [v2]

On Wed, 6 Nov 2024 03:39:09 GMT, Ambarish Rapte wrote: >> Remove `doPrivileged` calls in the javafx.base module. >> The changes are straight forward. >> 1. Remove doPrivileged calls, with keeping the lambda expression. >> 2. Remove SuppressWarnings annotations >> 3. Remove unused imports > > Amba

Integrated: 8342460: Remove calls to doPrivileged in javafx.web

On Thu, 31 Oct 2024 22:51:24 GMT, Andy Goryachev wrote: > Removes `doPrivileged` calls in the javafx.web module, excluding the code in > `{android,ios}`. This pull request has now been integrated. Changeset: 3d15a306 Author:Andy Goryachev URL: https://git.openjdk.org/jfx/commit/3d1

Re: RFR: 8342454: Remove calls to doPrivileged in javafx.graphics/com.sun.glass [v2]

On Wed, 6 Nov 2024 05:13:48 GMT, Jayathirth D V wrote: >> This PR removes AccessController.doPrivileged() calls in >> javafx.graphics/com.sun.glass. It is part of umbrella task >> [JDK-8342441](https://bugs.openjdk.org/browse/JDK-8342441). >> >> Also wherever classes are implementing Privilege

Re: RFR: 8343630: Pass AccessControlContext to/from WebKit as opaque object

On Wed, 6 Nov 2024 12:15:07 GMT, Kevin Rushforth wrote: > I don't like the practice of leaving pointers to JBS bug IDs that have been > fixed We don't have a well-defined knowledge base with permanent links which would have been better. The use of JBS ids, even resolved ones, might be the nex

Integrated: 8342459: Remove calls to doPrivileged in javafx.base

On Tue, 5 Nov 2024 17:42:53 GMT, Ambarish Rapte wrote: > Remove `doPrivileged` calls in the javafx.base module. > The changes are straight forward. > 1. Remove doPrivileged calls, with keeping the lambda expression. > 2. Remove SuppressWarnings annotations > 3. Remove unused imports This pull re

[jfx23u] Integrated: 8342917: GHA: Intermittent build failure on Linux while downloading ant

On Tue, 5 Nov 2024 23:41:32 GMT, Kevin Rushforth wrote: > Effectively clean backport of the GHA fix on Linux to install ant using the > package manager. I couldn't use the Skara backport command because of > differences in the surrounding context. The diffs themselves are identical to > the ma

Re: RFR: 8343630: Pass AccessControlContext to/from WebKit as opaque object

On Tue, 5 Nov 2024 23:58:19 GMT, Andy Goryachev wrote: > the only suggestion I have is maybe leave comments pointing to the JBS which > will help anyone years later to decipher what this thing is and why it is > passed along and not used. Good idea. I will leave a comment as part of [JDK-8342

Re: RFR: 8342459: Remove calls to doPrivileged in javafx.base [v2]

On Wed, 6 Nov 2024 03:39:09 GMT, Ambarish Rapte wrote: >> Remove `doPrivileged` calls in the javafx.base module. >> The changes are straight forward. >> 1. Remove doPrivileged calls, with keeping the lambda expression. >> 2. Remove SuppressWarnings annotations >> 3. Remove unused imports > > Amba

Re: Integrated: 8340982: [win] Dead key followed by Space generates two characters instead of one

Hi Johan, Thanks for explaining. I've taken a look at that JEP 14 document, and I can certainly understand the reasoning behind it. And indeed, this is a P4 bug, not particularly critical. Though the fix is small and low-risk, it is still a change and it inevitably takes resources to backport (al

Re: Proposal: JavaFX Incubator Modules

Being able to add an API without the guarantee for backwards compatibility (temporarily) is obviously alleviating to the developers and will ensure a better end result. My only concern is the amount of usability this can get. Incubating modules usually offer a substantial amount of code. In the JDK

Re: RFR: 8301121: RichTextArea Control (Incubator) [v37]

On Tue, 5 Nov 2024 21:47:54 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> us

Re: Proposal: JavaFX Incubator Modules

Thank you Kevin for restarting the discussion! Adding to what others said (very valid feedback from Michael/John), I specifically want to add a comment about Nir's remark where he mentioned Metal/DX12 pipelines. I am a bit worried about the difference between the openjfx sandbox repository and the

Re: CFV: New OpenJFX Reviewer: Michael Strauß

Vote: YES Regards, Ajit > On 5 Nov 2024, at 8:31 PM, Kevin Rushforth wrote: > > I hereby nominate Michael Strauß [1] to OpenJFX Reviewer. > > Michael is an OpenJFX community member, who has contributed 41 commits [2] to > OpenJFX. Michael regularly participates in code reviews, especially in

Re: RichTextArea and InputMap incubator modules [was: Proposal: JavaFX Incubator Modules]

It's a bit odd though to move forward with a proposal that had no clear consensus with developers on design and technical grounds first before getting community feedback.  I have not seen this with any of the other JEP's published.  Community feedback on this will need heavy filtering, as with