On Tue, 5 Nov 2024 19:03:41 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> stylistic changes > > modules/javafx.graphics/src/main/native-glass/mac/GlassViewDelegate.m line > 1336: > >> 1334: } >> 1335: >> 1336: - (NSEvent*)lastEvent > > could there be side effects with exposing this field? > concurrency issues? The native toolkits are single-threaded. Anyway, I chose to refactor this a bit, removing the exposed `lastEvent` field and instead providing the method `performWindowDrag` that is called instead. The logic to supply the `lastEvent` is now contained in `GlassViewDelegate`. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1831533708
