On Wed, 6 Nov 2024 11:14:48 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 52 commits: >> >> - readme >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - review comments >> - input map >> - validate model >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - javadoc >> - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea >> - review comments >> - measurement node >> - ... and 42 more: https://git.openjdk.org/jfx/compare/bd4bc057...a51ae151 > > modules/jfx.incubator.input/src/main/java/jfx/incubator/scene/control/input/KeyBinding.java > line 69: > >> 67: CTRL, >> 68: /** META modifier, mapped to COMMAND on Mac, META on >> Windows/Linux */ >> 69: META, > > The Command key on mac is mapped to both COMMAND(Line#65) and META. > Is there a difference of right and left Command key ? If Yes, then may be it > could be specified in the comment here. There is no differentiation between left and right COMMAND key in KeyCode, so it is impossible to provide one. Here, `KCondition` enum is private implementation detail. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1831838968
