On Mon, 4 Nov 2024 23:36:21 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 23 commits: >> >> - Merge branch 'master' into feature/extended-window >> - Merge branch 'master' into feature/extended-window >> - macOS: dynamically adapt toolbar style to headerbar height >> - fix header bar height flicker >> - NPE >> - fix peer access outside of synchronizer >> - improve title text documentation >> - macOS: hide window title >> - better documentation >> - set minHeight to native height of title bar >> - ... and 13 more: https://git.openjdk.org/jfx/compare/58cd76a8...9b63892d > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/WindowControlsOverlay.java > line 414: > >> 412: >> 413: double width = getWidth(); >> 414: double button1Width = boundedWidth(button1); > > Q: do we want to snap to pixel every time we use Node.[min/pref/max] values > to avoid jitter and fuzzy edges? I've added snapping at the appropriate points, and it makes a visible difference (less jitter). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1832015247
