On Fri, 1 Nov 2024 15:01:10 GMT, Andy Goryachev wrote:
>> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
>> `{android,ios}`.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> review comments
On Wed, 30 Oct 2024 18:16:26 GMT, Andy Goryachev wrote:
>> Removes doPrivileged in the following module:
>>
>> - javafx.swt
>>
>> See JDK-8342441 for details.
>>
>> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
>> whitespace" option.
>
> Andy Goryachev has update
On Tue, 5 Nov 2024 00:13:20 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 23 commits:
>>
>> - Merge branch 'master' into feature/extended-window
>> - Merge branch 'master' into feat
This PR removes AccessController.doPrivileged() calls in
javafx.graphics/com.sun.glass. It is part of umbrella task
[JDK-8342441](https://bugs.openjdk.org/browse/JDK-8342441).
Also wherever classes are implementing PrivilegedAction they are replaced with
java.util.Supplier and get().
I have re
On Tue, 5 Nov 2024 00:09:59 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 23 commits:
>>
>> - Merge branch 'master' into feature/extended-window
>> - Merge branch 'master' into feat
On Tue, 5 Nov 2024 00:05:43 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 23 commits:
>>
>> - Merge branch 'master' into feature/extended-window
>> - Merge branch 'master' into feat
On Tue, 5 Nov 2024 00:00:48 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 23 commits:
>>
>> - Merge branch 'master' into feature/extended-window
>> - Merge branch 'master' into feat
On Mon, 4 Nov 2024 11:28:35 GMT, Thiago Milczarek Sayao
wrote:
> I think it's fine, but is the window controls overlay supposed to take the
> whole window? I've set the background color just to demonstrate, it has no
> practical utility.
Yes, the overlay is resizable and will always stretch t
On Tue, 5 Nov 2024 01:32:16 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of effo
On Mon, 4 Nov 2024 23:33:34 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 23 commits:
>>
>> - Merge branch 'master' into feature/extended-window
>> - Merge branch 'master' into feat
> This PR is a new take on a highly requested feature: JavaFX controls in the
> header bar (see also #594 for an earlier iteration).
>
> This is a feature with many possible ways to skin the cat, and it has taken
> quite a bit of effort to come up with a good user model. In contrast to the
> pr
On Mon, 4 Nov 2024 23:57:40 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinWindow.java
>> line 385:
>>
>>> 383: * Classifies the window region at the specified physical
>>> coordinate.
>>> 384: *
>>> 385: * This method is called from
On Mon, 4 Nov 2024 23:56:00 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 23 commits:
>>
>> - Merge branch 'master' into feature/extended-window
>> - Merge branch 'master' into feat
On Mon, 4 Nov 2024 23:21:22 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 23 commits:
>>
>> - Merge branch 'master' into feature/extended-window
>> - Merge branch 'master' into feat
On Mon, 4 Nov 2024 22:54:55 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 23 commits:
>>
>> - Merge branch 'master' into feature/extended-window
>> - Merge branch 'master' into feat
On Mon, 4 Nov 2024 20:55:41 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 23 commits:
>>
>> - Merge branch 'master' into feature/extended-window
>> - Merge branch 'master' into feat
On Mon, 4 Nov 2024 20:13:23 GMT, Andy Goryachev wrote:
> There is, however, one problem in RTL mode on Win11: something is wrong with
> the hover area of the native close ([x]) button. If I click on the center of
> the X, nothing happens, and it does not show the hover status. If I move the
>
> This PR is a new take on a highly requested feature: JavaFX controls in the
> header bar (see also #594 for an earlier iteration).
>
> This is a feature with many possible ways to skin the cat, and it has taken
> quite a bit of effort to come up with a good user model. In contrast to the
> pr
On Mon, 4 Nov 2024 23:54:52 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 23 commits:
>>
>> - Merge branch 'master' into feature/extended-window
>> - Merge branch 'master' into feat
On Fri, 1 Nov 2024 23:38:52 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of effo
As noted, the current RichTextArea proposal depends on the InputMap
proposal. Andy will make this more clear by filing a new JBS Enhancement
(or reusing the existing one) for "InputMap (Incubator)", and adding
that issue to the RichTextArea PR.
The idea of incubating InputMap along with RichTe
The goal of incubating these or any other APIs is to get feedback from
applications developers as they use them, and be able to react to that
feedback with the freedom of being able to make incompatible changes. If
and when a feature is generally accepted, and we think the API is ready,
we woul
On Fri, 1 Nov 2024 23:38:52 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of effo
On Fri, 1 Nov 2024 23:38:52 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of effo
On Mon, 4 Nov 2024 17:42:01 GMT, Kevin Rushforth wrote:
> We are getting frequent intermittent failures downloading `ant` on Linux. The
> fix is to use the package manager to install ant rather than downloading it
> from `apache.org`.
>
> This only impacts GHA test builds, so the only verifica
We are getting frequent intermittent failures downloading `ant` on Linux. The
fix is to use the package manager to install ant rather than downloading it
from `apache.org`.
This only impacts GHA test builds, so the only verification needed for this fix
is that the GHA build passes on all platfo
On Thu, 31 Oct 2024 22:55:25 GMT, Andy Goryachev wrote:
> Added eclipse project files.
>
> The project is named `jsobject` instead of jdk.jsobject, similarly to how the
> other projects are named "base", "controls", ... instead of their full module
> names.
This pull request has now been inte
On Mon, 28 Oct 2024 14:59:12 GMT, Andy Goryachev wrote:
> Removes doPrivileged in the following module:
>
> - javafx.swing
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
This pull request has now been int
On Mon, 28 Oct 2024 15:01:47 GMT, Andy Goryachev wrote:
> Removes doPrivileged in the following module:
>
> - javafx.controls
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
This pull request has now been
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> Removed earlier manual tester in favor of the monkey tester.
>
> It is important to note that even though the constraints are given by the
> us
On Wed, 30 Oct 2024 18:16:26 GMT, Andy Goryachev wrote:
>> Removes doPrivileged in the following module:
>>
>> - javafx.swt
>>
>> See JDK-8342441 for details.
>>
>> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
>> whitespace" option.
>
> Andy Goryachev has update
On Fri, 1 Nov 2024 17:45:55 GMT, Andy Goryachev wrote:
>> Removes doPrivileged in the following module:
>>
>> - javafx.controls
>>
>> See JDK-8342441 for details.
>>
>> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
>> whitespace" option.
>
> Andy Goryachev has up
On Fri, 1 Nov 2024 23:38:52 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of effo
On Fri, 1 Nov 2024 23:38:52 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of effo
34 matches
Mail list logo
