The GitHub Actions job "Nightly Pekko 1.0 Builds" on pekko-connectors.git/main
has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run:
a9884925818ff539627bc0e0e725fbfa0facbfe9 / PJ Fanning
CI: use sha for actions instead of version (#1075)
Report URL:
The GitHub Actions job "Integration test for Kubernetes Lease" on
pekko-management.git/main has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run:
88efa0c665a6116387755a7fc9f3ef137b96161c / PJ Fanning
remove outdated release info in README.md (#437)
R
The GitHub Actions job "Nightly Build and Test" on
pekko-connectors-kafka.git/main has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run:
a26e13ce2e5889dc27457b1d81292ea9c226f338 / scala-steward-asf[bot]
<147768647+scala-steward-asf[bot]@users.noreply.g
The GitHub Actions job "Unit Tests" on pekko-persistence-cassandra.git/main has
succeeded.
Run started by GitHub user mdedetrich (triggered by mdedetrich).
Head commit for run:
171849f8cdbf220074069dc70a146237fd95bedc / scala-steward-asf[bot]
<147768647+scala-steward-asf[bot]@users.noreply.git
The GitHub Actions job "Nightly Tests" on pekko-management.git/main has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run:
88efa0c665a6116387755a7fc9f3ef137b96161c / PJ Fanning
remove outdated release info in README.md (#437)
Report URL: https://github
The GitHub Actions job "Nightly Builds" on pekko.git/main has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run:
9227912ea666f277d7ebc9dfedb53e6b2e768fa4 / PJ Fanning
Join cluster check adjusted to support akka (#1866)
* update cluster initjoin check t
The GitHub Actions job "Nightly Builds (1.1)" on pekko.git/main has succeeded.
Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run:
9227912ea666f277d7ebc9dfedb53e6b2e768fa4 / PJ Fanning
Join cluster check adjusted to support akka (#1866)
* update cluster initjoi
The GitHub Actions job "Publish 1.0.x Nightly" on pekko-projection.git/main has
succeeded.
Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run:
695ce1fa9e9237303d9af0c09ea91b67190236af / scala-steward-asf[bot]
<147768647+scala-steward-asf[bot]@users.noreply.githu
pjfanning commented on PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#issuecomment-2914044244
would this be a 1.2.0 or 1.1.2 change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
raboof commented on PR #1868:
URL: https://github.com/apache/pekko/pull/1868#issuecomment-2914007058
I could live with `changes` or `dropRepeated`. (I don't think we need an
equivalent of `changesWith`, people can use `statefulMap` for more advanced use
cases)
--
This is an automated mes
NavidJalali commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109540947
##
runtime/src/test/scala/org/apache/pekko/grpc/internal/GrpcResponseHelpersSpec.scala:
##
@@ -0,0 +1,36 @@
+package org.apache.pekko.grpc.internal
+
+import grpc.
pjfanning merged PR #1866:
URL: https://github.com/apache/pekko/pull/1866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekk
He-Pin merged PR #1870:
URL: https://github.com/apache/pekko/pull/1870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.a
He-Pin commented on PR #1870:
URL: https://github.com/apache/pekko/pull/1870#issuecomment-2913336255
let me merge this first, any improvement can come up later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
He-Pin closed issue #1829: Add onComplete to statefulMapConcat
URL: https://github.com/apache/pekko/issues/1829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
The GitHub Actions job "Headers" on pekko-grpc.git/pre-announce-trailers has
succeeded.
Run started by GitHub user NavidJalali (triggered by He-Pin).
Head commit for run:
11cc197f06dc355f34e69f8cf7288208b397542f / NavidJalali
copy paste header from somewhere else
Report URL: https://github.co
raboof commented on PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#issuecomment-2913163764
> Uhm, I am not sure what to put on the header of this new file.
>
> ```
> /*
> * Licensed to the Apache Software Foundation (ASF) under one or more
> * license agreements
NavidJalali commented on PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#issuecomment-2913086756
I guess technically lightbend doesnt even exist anymore its now called Akka
😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
raboof commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109389687
##
interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/PowerApiSpec.scala:
##
@@ -182,6 +182,37 @@ abstract class PowerApiSpec(backend: String)
metadat
raboof commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109547418
##
runtime/src/test/scala/org/apache/pekko/grpc/internal/GrpcResponseHelpersSpec.scala:
##
@@ -0,0 +1,36 @@
+package org.apache.pekko.grpc.internal
+
+import grpc.refle
NavidJalali commented on PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#issuecomment-2913064523
Uhm, I am not sure what to put on the header of this new file.
```
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* license agreements; and to Y
NavidJalali commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109540947
##
runtime/src/test/scala/org/apache/pekko/grpc/internal/GrpcResponseHelpersSpec.scala:
##
@@ -0,0 +1,36 @@
+package org.apache.pekko.grpc.internal
+
+import grpc.
The GitHub Actions job "Headers" on pekko-grpc.git/pre-announce-trailers has
failed.
Run started by GitHub user NavidJalali (triggered by raboof).
Head commit for run:
1eb58d1ee3410634febb9c9cc97e0399d3672d86 / NavidJalali
move test into runtime module
Report URL: https://github.com/apache/pe
NavidJalali commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109502011
##
interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/PowerApiSpec.scala:
##
@@ -182,6 +182,37 @@ abstract class PowerApiSpec(backend: String)
me
raboof commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109496833
##
interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/PowerApiSpec.scala:
##
@@ -182,6 +182,37 @@ abstract class PowerApiSpec(backend: String)
metadat
raboof commented on PR #1868:
URL: https://github.com/apache/pekko/pull/1868#issuecomment-2912761317
> Is there a reason not to just call this `distinct`? I don't get what the
`UntilChanged` bit adds to this - ie it seems unnecessary and potentially
confusing.
I think we should try a
NavidJalali commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109471395
##
interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/PowerApiSpec.scala:
##
@@ -182,6 +182,37 @@ abstract class PowerApiSpec(backend: String)
me
The GitHub Actions job "Link Validator" on pekko-grpc.git/pre-announce-trailers
has succeeded.
Run started by GitHub user NavidJalali (triggered by raboof).
Head commit for run:
8a8645f2bcf2a9715130f5b4c189ee169b5edc70 / NavidJalali
extend comment on top of response fn
Report URL: https://git
NavidJalali commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109337302
##
runtime/src/main/scala/org/apache/pekko/grpc/scaladsl/headers/headers.scala:
##
@@ -111,3 +112,29 @@ object `Status-Message` extends
ModeledCustomHeaderCompani
NavidJalali commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109467722
##
interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/PowerApiSpec.scala:
##
@@ -182,6 +182,37 @@ abstract class PowerApiSpec(backend: String)
me
NavidJalali commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109464984
##
runtime/src/main/scala/org/apache/pekko/grpc/scaladsl/headers/headers.scala:
##
@@ -111,3 +112,29 @@ object `Status-Message` extends
ModeledCustomHeaderCompani
NavidJalali commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109458080
##
interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/PowerApiSpec.scala:
##
@@ -182,6 +182,37 @@ abstract class PowerApiSpec(backend: String)
me
The GitHub Actions job "Validate and test" on pekko-grpc.git/main has succeeded.
Run started by GitHub user raboof (triggered by raboof).
Head commit for run:
bcb07b2da9bc46e2b4d39751223ad0859f621824 / PJ Fanning
test with scala 3.3.6 (#457)
Report URL: https://github.com/apache/pekko-grpc/ac
He-Pin commented on PR #1868:
URL: https://github.com/apache/pekko/pull/1868#issuecomment-2912857094
@pjfanning @pjfanning And in Kotlin flow, it's `distinctUntilChanged` ,but
in `FS2`, it's `filterWithPrevious`.
--
This is an automated message from the Apache Git Service.
To respond to t
raboof merged PR #457:
URL: https://github.com/apache/pekko-grpc/pull/457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekk
raboof commented on PR #457:
URL: https://github.com/apache/pekko-grpc/pull/457#issuecomment-2912847424
> > If we just make it `3.3` it should pick up the right patch version from
sbt, so that might be neater still?
>
> I think this is there for a reason, as in the build breaks when w
raboof opened a new issue, #458:
URL: https://github.com/apache/pekko-grpc/issues/458
Right now, publishing does a `+publish` and then separate explicit `publish`
invocations for 2.13 and 3.3 versions of codegen.
IIRC this is because in earlier versions of SBT, there was a problem wit
pjfanning commented on PR #1868:
URL: https://github.com/apache/pekko/pull/1868#issuecomment-2912825950
> > Is there a reason not to just call this `distinct`? I don't get what the
`UntilChanged` bit adds to this - ie it seems unnecessary and potentially
confusing.
>
> I think we sho
pjfanning commented on code in PR #1868:
URL: https://github.com/apache/pekko/pull/1868#discussion_r2109418862
##
stream-tests/src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java:
##
@@ -816,6 +816,14 @@ public void mustBeAbleToUseStatefulMap() throws Exception {
raboof commented on code in PR #1868:
URL: https://github.com/apache/pekko/pull/1868#discussion_r2109413329
##
docs/src/test/java/jdocs/stream/operators/SourceOrFlow.java:
##
@@ -608,6 +608,20 @@ void filterNotExample() {
// #filterNot
}
+ void distinctUntilChangedExa
He-Pin commented on code in PR #1868:
URL: https://github.com/apache/pekko/pull/1868#discussion_r2109412281
##
docs/src/test/java/jdocs/stream/operators/SourceOrFlow.java:
##
@@ -608,6 +608,20 @@ void filterNotExample() {
// #filterNot
}
+ void distinctUntilChangedExa
He-Pin commented on PR #1868:
URL: https://github.com/apache/pekko/pull/1868#issuecomment-2912798624
@pjfanning I'm following the naming in reactor-core and
https://github.com/smallrye/smallrye-mutiny/pull/1853, rxjava is using this
name too.
--
This is an automated message from the Apac
The GitHub Actions job "Validate and test" on
pekko-grpc.git/pre-announce-trailers has failed.
Run started by GitHub user NavidJalali (triggered by raboof).
Head commit for run:
9a2907f2c95fbd81e6290f1d25ebe59474a41f7b / NavidJalali
add test for checking `trailer` is part of metadata, make `tr
The GitHub Actions job "Link Validator" on pekko-grpc.git/pre-announce-trailers
has failed.
Run started by GitHub user NavidJalali (triggered by raboof).
Head commit for run:
9a2907f2c95fbd81e6290f1d25ebe59474a41f7b / NavidJalali
add test for checking `trailer` is part of metadata, make `trail
raboof commented on code in PR #1868:
URL: https://github.com/apache/pekko/pull/1868#discussion_r2109337578
##
stream-tests/src/test/java/org/apache/pekko/stream/javadsl/SourceTest.java:
##
@@ -816,6 +816,14 @@ public void mustBeAbleToUseStatefulMap() throws Exception {
Ass
raboof commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109260332
##
runtime/src/main/scala/org/apache/pekko/grpc/scaladsl/headers/headers.scala:
##
@@ -111,3 +112,29 @@ object `Status-Message` extends
ModeledCustomHeaderCompanion[`S
pjfanning commented on PR #457:
URL: https://github.com/apache/pekko-grpc/pull/457#issuecomment-2912692567
> If we just make it `3.3` it should pick up the right patch version from
sbt, so that might be neater still?
I think this is there for a reason, as in the build breaks when we d
pjfanning commented on PR #1868:
URL: https://github.com/apache/pekko/pull/1868#issuecomment-2912683403
Is there a reason not to just call this `distinct`? I don't get what the
`UntilChanged` bit adds to this - ie it seems unnecessary and potentially
confusing.
--
This is an automated me
He-Pin commented on PR #1868:
URL: https://github.com/apache/pekko/pull/1868#issuecomment-2912663354
@pjfanning Would you like to give another round of review on this? I want to
add `aggregateUntilChanged` once this is merged.
--
This is an automated message from the Apache Git Service.
T
He-Pin commented on PR #1870:
URL: https://github.com/apache/pekko/pull/1870#issuecomment-2912652218
@mdedetrich @raboof it would be nice if you have time to take another look :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
The GitHub Actions job "Validate and test" on
pekko-grpc.git/pre-announce-trailers has succeeded.
Run started by GitHub user NavidJalali (triggered by raboof).
Head commit for run:
f1156dee843efa530f8d00fa1c649a7f5c498c69 / NavidJalali
use ArraySeq.unsafeWrapArray
Report URL: https://github.c
pjfanning opened a new pull request, #457:
URL: https://github.com/apache/pekko-grpc/pull/457
* sbt setup was changed
* but we have GitHub hardcoding of version too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
raboof commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109274114
##
runtime/src/main/scala/org/apache/pekko/grpc/scaladsl/headers/headers.scala:
##
@@ -111,3 +112,29 @@ object `Status-Message` extends
ModeledCustomHeaderCompanion[`S
NavidJalali commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109267762
##
runtime/src/main/scala/org/apache/pekko/grpc/scaladsl/headers/headers.scala:
##
@@ -111,3 +112,29 @@ object `Status-Message` extends
ModeledCustomHeaderCompani
raboof commented on PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#issuecomment-2912610192
> would it be possible to add tests?
+1 - if nothing else, that would be a nice opportunity to document why that
header is important in practice
--
This is an automated message f
pjfanning commented on PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#issuecomment-2912604862
* this code does not compile in Scala 2.13 or 3.3
```
[error] -- Error:
/home/runner/work/pekko-grpc/pekko-grpc/runtime/src/main/scala/org/apache/pekko/grpc/scaladsl/headers/heade
NavidJalali commented on PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#issuecomment-2912515243
Thanks for running the tests. Checking whats wrong as these didnt show up
locally 👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please
The GitHub Actions job "Validate and test" on
pekko-grpc.git/pre-announce-trailers has failed.
Run started by GitHub user NavidJalali (triggered by pjfanning).
Head commit for run:
50075d8af993d2e2a3c9c77e8e843871152214dd / NavidJalali
preannounce trailers in server streaming calls
Report URL
NavidJalali commented on PR #453:
URL: https://github.com/apache/pekko-grpc/pull/453#issuecomment-2912497306
Closing in favor of https://github.com/apache/pekko-grpc/pull/456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
NavidJalali closed pull request #453: trailer only response for immediate
stream failures
URL: https://github.com/apache/pekko-grpc/pull/453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
NavidJalali opened a new pull request, #456:
URL: https://github.com/apache/pekko-grpc/pull/456
According to [RFC 7230](https://www.rfc-editor.org/rfc/rfc7230) in section
4.4 regarding trailers it says:
> [4.4](https://www.rfc-editor.org/rfc/rfc7230#section-4.4). Trailer
> When a
pjfanning commented on issue #1801:
URL: https://github.com/apache/pekko/issues/1801#issuecomment-2912257587
#1802 includes no changes to the existing Pekko Flow or Source APIs and
could easily be delivered as a 3rd party standalone lib.
--
This is an automated message from the Apache Git
jypma commented on issue #1801:
URL: https://github.com/apache/pekko/issues/1801#issuecomment-2912199445
@pjfanning Thanks for the clarification. However, I'm not fully
understanding the concrete way forward you're suggesting. Should I close the
PR, and retain this only as a separate librar
He-Pin commented on code in PR #1870:
URL: https://github.com/apache/pekko/pull/1870#discussion_r2108922146
##
stream/src/main/scala/org/apache/pekko/stream/javadsl/StatefulMapConcatAccumulator.scala:
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
pjfanning commented on code in PR #1870:
URL: https://github.com/apache/pekko/pull/1870#discussion_r2108872597
##
stream/src/main/scala/org/apache/pekko/stream/scaladsl/StatefulMapConcatAccumulator.scala:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (A
Copilot commented on code in PR #1870:
URL: https://github.com/apache/pekko/pull/1870#discussion_r2108866538
##
stream/src/main/scala/org/apache/pekko/stream/scaladsl/StatefulMapConcatAccumulator.scala:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
The GitHub Actions job "Publish Nightly" on pekko-grpc.git/main has succeeded.
Run started by GitHub user He-Pin (triggered by He-Pin).
Head commit for run:
0702fac80cd8ceeac4966f77e5cdc0d6db42b2f5 / scala-steward-asf[bot]
<147768647+scala-steward-asf[bot]@users.noreply.github.com>
Update sbt,
67 matches
Mail list logo
