NavidJalali commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109540947
##########
runtime/src/test/scala/org/apache/pekko/grpc/internal/GrpcResponseHelpersSpec.scala:
##########
@@ -0,0 +1,36 @@
+package org.apache.pekko.grpc.internal
+
+import grpc.reflection.v1alpha.reflection.{ ServerReflection,
ServerReflectionResponse }
+import io.grpc.Status
+import org.apache.pekko.actor.ActorSystem
+import org.apache.pekko.grpc.GrpcProtocol
+import org.apache.pekko.grpc.scaladsl.{ headers, ScalapbProtobufSerializer }
+import org.apache.pekko.stream.scaladsl.Source
+import org.apache.pekko.testkit.TestKit
+import org.scalatest.matchers.should.Matchers._
+import org.scalatest.wordspec.AnyWordSpecLike
+
+final class GrpcResponseHelpersSpec extends
TestKit(ActorSystem("GrpcResponseHelpersSpec")) with AnyWordSpecLike {
+ "GrpcResponseHelpers" should {
+
+ /**
+ * Pre-announcing trailers: See https://www.rfc-editor.org/rfc/rfc7230
#Section 4.4
+ * Certain reverse proxies (e.g. tyk) will not behave correctly if
trailers are not pre-announced and
+ * errors are not reported with trailer-only optimization.
+ */
+ "pre-announce trailers in the headers" in {
+ implicit val serializer:
ScalapbProtobufSerializer[ServerReflectionResponse] =
Review Comment:
@raboof I ended up just using whatever `GeneratedMessage` I found in the
same package since I didnt wanna add another `protobuf` file to generate new
messages, however I can do that if you think this is ugly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
