NavidJalali commented on code in PR #456: URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109458080
########## interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/PowerApiSpec.scala: ########## @@ -182,6 +182,37 @@ abstract class PowerApiSpec(backend: String) metadataServer.terminate(3.seconds) } + + "pre-announce trailers in the headers" in { + val binding = Http() Review Comment: yep makes sense ########## runtime/src/main/scala/org/apache/pekko/grpc/scaladsl/headers/headers.scala: ########## @@ -111,3 +112,29 @@ object `Status-Message` extends ModeledCustomHeaderCompanion[`Status-Message`] { def findIn(headers: immutable.Seq[HttpHeader]): Option[String] = headers.collectFirst { case h if h.is(name) => h.value() } } + +final class `Trailer` private (values: immutable.Seq[String]) extends ModeledCustomHeader[`Trailer`] { Review Comment: ah thats not powerful enough, private to grpc then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org