raboof commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109274114


##########
runtime/src/main/scala/org/apache/pekko/grpc/scaladsl/headers/headers.scala:
##########
@@ -111,3 +112,29 @@ object `Status-Message` extends 
ModeledCustomHeaderCompanion[`Status-Message`] {
   def findIn(headers: immutable.Seq[HttpHeader]): Option[String] =
     headers.collectFirst { case h if h.is(name) => h.value() }
 }
+
+final class `Trailer` private (values: immutable.Seq[String]) extends 
ModeledCustomHeader[`Trailer`] {

Review Comment:
   We should explicitly make it private here so it doesn't become part of the 
public API. That way we can later remove it (and start using the 'upstream' 
class), since nobody should/could have been relying on it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org

Reply via email to