raboof commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109389687
##########
interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/PowerApiSpec.scala:
##########
@@ -182,6 +182,37 @@ abstract class PowerApiSpec(backend: String)
metadataServer.terminate(3.seconds)
}
+
+ "pre-announce trailers in the headers" in {
Review Comment:
Please include a comment here as well explaining why it is important to
pre-announce trailers: link to the RFC (though with the caveat that it's
strictly speaking about chunked and not about h2) and mentioning the tyk bug.
Maybe add an issue to https://github.com/TykTechnologies/tyk so you can link to
it?
##########
interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/PowerApiSpec.scala:
##########
@@ -182,6 +182,37 @@ abstract class PowerApiSpec(backend: String)
metadataServer.terminate(3.seconds)
}
+
+ "pre-announce trailers in the headers" in {
+ val binding = Http()
Review Comment:
I don't think it's strictly necessary to have this as an 'interop' test, a
more lightweight unit test would have been fine to me as well. But I'm not
opposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
