Copilot commented on code in PR #1870: URL: https://github.com/apache/pekko/pull/1870#discussion_r2108866538
########## stream/src/main/scala/org/apache/pekko/stream/scaladsl/StatefulMapConcatAccumulator.scala: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.pekko.stream.scaladsl + +import org.apache.pekko +import pekko.japi.function +import pekko.stream.{ javadsl, scaladsl } +import pekko.util.ccompat._ + +/** + * A special accumulator for `StatefulMapConcat` operator that allows to emit elements when the upstream has completed. + * + * @since 1.2.0 + */ +@ccompatUsedUntil213 +@FunctionalInterface +trait StatefulMapConcatAccumulator[-In, +Out] extends (In => IterableOnce[Out]) { + + /** + * Been called once the upstream has been completed, optional elements can be emitted, by default none. + */ + def onComplete(): IterableOnce[Out] = Nil Review Comment: Consider clarifying in the documentation for onComplete that by default no elements are emitted and that implementations can override this to emit buffered elements upon upstream completion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
