raboof commented on code in PR #456:
URL: https://github.com/apache/pekko-grpc/pull/456#discussion_r2109496833
##########
interop-tests/src/test/scala/org/apache/pekko/grpc/scaladsl/PowerApiSpec.scala:
##########
@@ -182,6 +182,37 @@ abstract class PowerApiSpec(backend: String)
metadataServer.terminate(3.seconds)
}
+
+ "pre-announce trailers in the headers" in {
Review Comment:
Nice simplification of the test! Perhaps it can now be moved to the
`runtime` subproject?
Also, sorry about confusing things by mentioning the chunked encoding: what
I meant was that the RFC is about the chunked encoding, and HTTP/2 uses the
"Trailing headers" concept introduced there, but HTTP/2 doesn't actually use
chunked encoding. Perhaps it's not necessary to say anything about that in the
comment after all :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
