pjfanning commented on PR #1868: URL: https://github.com/apache/pekko/pull/1868#issuecomment-2912825950
> > Is there a reason not to just call this `distinct`? I don't get what the `UntilChanged` bit adds to this - ie it seems unnecessary and potentially confusing. > > I think we should try and avoid confusion with https://www.scala-lang.org/api/3.7.0/scala/collection/SeqOps.html#distinct-0 > > I understand the name follows https://rxjs.dev/api/operators/distinctUntilChanged . I'm not sure it makes sense to me: the results aren't 'distinct' 'until' they are the same? I don't want to bikeshed too much, but something like `dropRepeated' might make more sense? We can mention in the docs that this is called distinctUntilChanged in rx so people can find it. > > The docs for 'statefulMap' have this as an example (https://pekko.apache.org/docs/pekko/current/stream/operators/Source-or-Flow/statefulMap.html). There's something to be said for having it as a separate construct, but perhaps the docs should link to each other? I suppose that this function is not then the same as `distinct` and I think `dropRepeated` makes a lot more sense than `distinctUntilChanged` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
