Re: [PR] Bump qs from 6.2.3 to 6.11.1 [ignite-website]

2024-12-13 Thread via GitHub
chenyuan99 commented on PR #162: URL: https://github.com/apache/ignite-website/pull/162#issuecomment-2542666007 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] IGNITE-23722 Map JDBC ClientInfo to ApplicationAttributes [ignite]

2024-12-13 Thread via GitHub
timoninmaxim merged PR #11724: URL: https://github.com/apache/ignite/pull/11724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

Re: [PR] IGNITE-23948 Add print size only for MultipleRowReplicaRequest#binaryTuples in IgniteToStringBuilder#toString [ignite-3]

2024-12-13 Thread via GitHub
tkalkirill commented on code in PR #4887: URL: https://github.com/apache/ignite-3/pull/4887#discussion_r1883661521 ## modules/network-annotation-processor/src/main/java/org/apache/ignite/internal/network/processor/messages/MessageImplGenerator.java: ## @@ -137,12 +139,20 @@ publ

Re: [PR] IGNITE-23837 Add log when lock manager run out of slots [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4835: URL: https://github.com/apache/ignite-3/pull/4835#discussion_r1883631151 ## modules/transactions/src/test/java/org/apache/ignite/internal/tx/TxManagerTest.java: ## @@ -184,6 +183,8 @@ public void tearDown() { txManager.beforeNodeSto

Re: [PR] IGNITE-23777 DB API Driver 3: Prepare the driver for publishing [ignite-3]

2024-12-13 Thread via GitHub
isapego commented on code in PR #4869: URL: https://github.com/apache/ignite-3/pull/4869#discussion_r1883814715 ## modules/platforms/python/README.md: ## @@ -32,6 +39,53 @@ $ pip install -r requirements/.txt You may also want to consult the `setuptools` manual about using `se

Re: [PR] IGNITE-23043 .NET: Add IDistributedCache implementation [ignite-3]

2024-12-13 Thread via GitHub
ptupitsyn merged PR #4890: URL: https://github.com/apache/ignite-3/pull/4890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-23601 Create broadcast partitioned compute method [ignite-3]

2024-12-13 Thread via GitHub
valepakh commented on code in PR #4871: URL: https://github.com/apache/ignite-3/pull/4871#discussion_r1883822863 ## modules/api/src/main/java/org/apache/ignite/compute/JobExecutionContext.java: ## @@ -36,4 +38,13 @@ public interface JobExecutionContext { * @return {@code t

Re: [PR] IGNITE-23601 Create broadcast partitioned compute method [ignite-3]

2024-12-13 Thread via GitHub
valepakh commented on code in PR #4871: URL: https://github.com/apache/ignite-3/pull/4871#discussion_r1883823704 ## modules/api/src/main/java/org/apache/ignite/compute/IgniteCompute.java: ## @@ -244,6 +244,98 @@ default Map executeBroadcast( return map; } +/

[PR] IGNITE-23851 [ignite]

2024-12-13 Thread via GitHub
nizhikov opened a new pull request, #11737: URL: https://github.com/apache/ignite/pull/11737 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] IGNITE-23420 Tuple API does not provide a method to read decimal values [ignite-3]

2024-12-13 Thread via GitHub
AMashenkov merged PR #4870: URL: https://github.com/apache/ignite-3/pull/4870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] IGNITE-23853 [ignite]

2024-12-13 Thread via GitHub
nizhikov opened a new pull request, #11738: URL: https://github.com/apache/ignite/pull/11738 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

[PR] IGNITE-23982 Comment out asserts on primary eleceted/expired in ReplicaStateManager [ignite-3]

2024-12-13 Thread via GitHub
JAkutenshi opened a new pull request, #4893: URL: https://github.com/apache/ignite-3/pull/4893 JIRA Ticket: [IGNITE-23982](https://issues.apache.org/jira/browse/IGNITE-23982) ## The goal The goal of the PR is to comment out the corresponding assertions. ## The reason

Re: [PR] IGNITE-23780 Node restart behaviour when forced pending [ignite-3]

2024-12-13 Thread via GitHub
Cyrill commented on code in PR #4847: URL: https://github.com/apache/ignite-3/pull/4847#discussion_r1883774876 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/disaster/ItDisasterRecoveryReconfigurationTest.java: ## @@ -345,6 +348,145 @@ void testManualRebala

[PR] IGNITE-23940 Sql. Fixes races in AsyncRootNode [ignite-3]

2024-12-13 Thread via GitHub
korlov42 opened a new pull request, #4896: URL: https://github.com/apache/ignite-3/pull/4896 https://issues.apache.org/jira/browse/IGNITE-23940 This patch addresses two issues related to AsyncRootNode: - The race between `flush()` invocation triggered by prefetch and adding the

Re: [PR] IGNITE-23777 DB API Driver 3: Prepare the driver for publishing [ignite-3]

2024-12-13 Thread via GitHub
isapego commented on code in PR #4869: URL: https://github.com/apache/ignite-3/pull/4869#discussion_r1883803755 ## modules/platforms/python/scripts/build_wheels.sh: ## @@ -0,0 +1,61 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contribu

Re: [PR] IGNITE-23601 Create broadcast partitioned compute method [ignite-3]

2024-12-13 Thread via GitHub
ptupitsyn commented on code in PR #4871: URL: https://github.com/apache/ignite-3/pull/4871#discussion_r1883653148 ## modules/api/src/main/java/org/apache/ignite/compute/JobExecutionContext.java: ## @@ -36,4 +38,13 @@ public interface JobExecutionContext { * @return {@code

Re: [PR] IGNITE-23601 Create broadcast partitioned compute method [ignite-3]

2024-12-13 Thread via GitHub
ptupitsyn commented on code in PR #4871: URL: https://github.com/apache/ignite-3/pull/4871#discussion_r1883657954 ## modules/api/src/main/java/org/apache/ignite/compute/IgniteCompute.java: ## @@ -244,6 +244,98 @@ default Map executeBroadcast( return map; } +

Re: [PR] IGNITE-23601 Create broadcast partitioned compute method [ignite-3]

2024-12-13 Thread via GitHub
ptupitsyn commented on code in PR #4871: URL: https://github.com/apache/ignite-3/pull/4871#discussion_r1883660079 ## modules/api/src/main/java/org/apache/ignite/compute/IgniteCompute.java: ## @@ -244,6 +244,98 @@ default Map executeBroadcast( return map; } +

[PR] IGNITE-23983 Only create default profile if there are no others [ignite-3]

2024-12-13 Thread via GitHub
ibessonov opened a new pull request, #4894: URL: https://github.com/apache/ignite-3/pull/4894 https://issues.apache.org/jira/browse/IGNITE-23983 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-23948 Add print size only for MultipleRowReplicaRequest#binaryTuples in IgniteToStringBuilder#toString [ignite-3]

2024-12-13 Thread via GitHub
tkalkirill merged PR #4887: URL: https://github.com/apache/ignite-3/pull/4887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-23780 Node restart behaviour when forced pending [ignite-3]

2024-12-13 Thread via GitHub
Cyrill commented on code in PR #4847: URL: https://github.com/apache/ignite-3/pull/4847#discussion_r1883719973 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -2235,10 +2263,25 @@ private CompletableFuture handleChangePending

Re: [PR] IGNITE-23777 DB API Driver 3: Prepare the driver for publishing [ignite-3]

2024-12-13 Thread via GitHub
isapego commented on code in PR #4869: URL: https://github.com/apache/ignite-3/pull/4869#discussion_r1883724872 ## modules/platforms/python/scripts/BuildWheels.ps1: ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license a

Re: [PR] IGNITE-23898 Sql. Calculate schema for concat two rows just once [ignite-3]

2024-12-13 Thread via GitHub
AMashenkov merged PR #4882: URL: https://github.com/apache/ignite-3/pull/4882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-23777 DB API Driver 3: Prepare the driver for publishing [ignite-3]

2024-12-13 Thread via GitHub
isapego commented on code in PR #4869: URL: https://github.com/apache/ignite-3/pull/4869#discussion_r1883731637 ## modules/platforms/python/scripts/BuildWheels.ps1: ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license a

[PR] IGNITE-23890 Java thin: remove reconnect throttling config props [ignite-3]

2024-12-13 Thread via GitHub
ptupitsyn opened a new pull request, #4897: URL: https://github.com/apache/ignite-3/pull/4897 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] IGNITE-23780 Node restart behaviour when forced pending [ignite-3]

2024-12-13 Thread via GitHub
Cyrill commented on code in PR #4847: URL: https://github.com/apache/ignite-3/pull/4847#discussion_r1883535922 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/disaster/ItDisasterRecoveryReconfigurationTest.java: ## @@ -345,6 +348,145 @@ void testManualRebala

Re: [PR] IGNITE-23780 Node restart behaviour when forced pending [ignite-3]

2024-12-13 Thread via GitHub
Cyrill commented on code in PR #4847: URL: https://github.com/apache/ignite-3/pull/4847#discussion_r1883531128 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/disaster/ItDisasterRecoveryReconfigurationTest.java: ## @@ -345,6 +348,145 @@ void testManualRebala

Re: [PR] IGNITE-23850 Remove IgniteFeatures#TCP_COMMUNICATION_SPI_HANDSHAKE_WAIT_MESSAGE and related code [ignite]

2024-12-13 Thread via GitHub
nizhikov merged PR #11733: URL: https://github.com/apache/ignite/pull/11733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[PR] IGNITE-23990 Remove setForceServerMode from CacheAffinityCallSelfTest [ignite]

2024-12-13 Thread via GitHub
nizhikov opened a new pull request, #11739: URL: https://github.com/apache/ignite/pull/11739 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

2024-12-13 Thread via GitHub
tkalkirill commented on code in PR #4900: URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1884868416 ## modules/core/src/main/java/org/apache/ignite/internal/tostring/IgniteLogThrottle.java: ## @@ -0,0 +1,532 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] IGNITE-23619 Remove duplicated key-value tests. [ignite-3]

2024-12-13 Thread via GitHub
xtern merged PR #4892: URL: https://github.com/apache/ignite-3/pull/4892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-23837 Add log when lock manager run out of slots [ignite-3]

2024-12-13 Thread via GitHub
vldpyatkov merged PR #4835: URL: https://github.com/apache/ignite-3/pull/4835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

2024-12-13 Thread via GitHub
tkalkirill opened a new pull request, #4900: URL: https://github.com/apache/ignite-3/pull/4900 https://issues.apache.org/jira/browse/IGNITE-23972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884204969 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/ActionRequestProcessor.java: ## @@ -109,20 +108,9 @@ protected void handleRequestInternal(RpcContext

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884207820 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/CommandApplicationResult.java: ## @@ -19,24 +19,25 @@ import java.util.concurrent.Completab

Re: [PR] IGNITE-23890 Java thin: remove reconnect throttling config props [ignite-3]

2024-12-13 Thread via GitHub
ptupitsyn merged PR #4897: URL: https://github.com/apache/ignite-3/pull/4897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884204969 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/ActionRequestProcessor.java: ## @@ -109,20 +108,9 @@ protected void handleRequestInternal(RpcContext

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884222746 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/command/SafeTimePropagatingCommand.java: ## @@ -26,7 +27,11 @@ * Common interface for comman

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884174689 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/marshaller/PartitionCommandsMarshaller.java: ## @@ -37,4 +37,6 @@ public i

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884196837 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHandler

[PR] IGNITE-23605 Sql. Add shutdown guard for sql-execution-pool [ignite-3]

2024-12-13 Thread via GitHub
ygerzhedovich opened a new pull request, #4899: URL: https://github.com/apache/ignite-3/pull/4899 https://issues.apache.org/jira/browse/IGNITE-23605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

2024-12-13 Thread via GitHub
sashapolo commented on code in PR #4900: URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1884074073 ## modules/core/src/main/java/org/apache/ignite/internal/tostring/IgniteLogThrottle.java: ## @@ -0,0 +1,532 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] IGNITE-23601 Create broadcast partitioned compute method [ignite-3]

2024-12-13 Thread via GitHub
valepakh commented on code in PR #4871: URL: https://github.com/apache/ignite-3/pull/4871#discussion_r1883968376 ## modules/api/src/main/java/org/apache/ignite/compute/IgniteCompute.java: ## @@ -244,6 +244,98 @@ default Map executeBroadcast( return map; } +/

Re: [PR] IGNITE-23890 Java thin: remove reconnect throttling config props [ignite-3]

2024-12-13 Thread via GitHub
isapego commented on code in PR #4897: URL: https://github.com/apache/ignite-3/pull/4897#discussion_r1884064959 ## modules/client/src/main/java/org/apache/ignite/internal/client/ReliableChannel.java: ## @@ -754,8 +755,8 @@ class ClientChannelHolder { /** Address that ho

Re: [PR] IGNITE-23982 Comment out asserts on primary elected/expired in ReplicaStateManager [ignite-3]

2024-12-13 Thread via GitHub
sanpwc merged PR #4893: URL: https://github.com/apache/ignite-3/pull/4893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

Re: [PR] IGNITE-22557 Create system view for SQL query plans history [ignite]

2024-12-13 Thread via GitHub
alex-plekhanov commented on code in PR #11425: URL: https://github.com/apache/ignite/pull/11425#discussion_r1883714610 ## modules/core/src/main/java/org/apache/ignite/internal/processors/query/running/SqlPlanHistoryTracker.java: ## @@ -25,18 +25,13 @@ /** Class that manages rec

Re: [PR] IGNITE-23777 DB API Driver 3: Prepare the driver for publishing [ignite-3]

2024-12-13 Thread via GitHub
isapego commented on code in PR #4869: URL: https://github.com/apache/ignite-3/pull/4869#discussion_r1884079506 ## modules/platforms/python/scripts/build_wheels.sh: ## @@ -0,0 +1,61 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contribu

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884170810 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.apache.

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884174689 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/marshaller/PartitionCommandsMarshaller.java: ## @@ -37,4 +37,6 @@ public i

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884180223 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java: ## @@ -734,14 +733,6 @@ private void handleErrorResponse(CompletableFuture fut

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
rpuch commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1883812229 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -836,7 +836,7 @@ private RaftGroupOptions groupOptionsForPartition(b

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884194321 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java: ## @@ -447,6 +447,10 @@ public boolean startRaftNode( // Th

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884201903 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -3733,6 +3750,11 @@ public Message handleTimeoutNowRequest(final TimeoutNowRequest

[PR] IGNITE-23499 Integrate cancellation of compute job with sql kill handler. [ignite-3]

2024-12-13 Thread via GitHub
xtern opened a new pull request, #4898: URL: https://github.com/apache/ignite-3/pull/4898 https://issues.apache.org/jira/browse/IGNITE-23499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884152347 ## modules/metastorage/build.gradle: ## @@ -38,6 +39,7 @@ dependencies { implementation project(':ignite-failure-handler') implementation project(':ignite-met

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884158372 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.apache.

Re: [PR] IGNITE-23777 DB API Driver 3: Prepare the driver for publishing [ignite-3]

2024-12-13 Thread via GitHub
isapego merged PR #4869: URL: https://github.com/apache/ignite-3/pull/4869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ign

[PR] Bump log4j from 2.24.2 to 2.24.3 [ignite-3]

2024-12-13 Thread via GitHub
dependabot[bot] opened a new pull request, #4901: URL: https://github.com/apache/ignite-3/pull/4901 Bumps `log4j` from 2.24.2 to 2.24.3. Updates `org.apache.logging.log4j:log4j-slf4j2-impl` from 2.24.2 to 2.24.3 Updates `org.apache.logging.log4j:log4j-api` from 2.24.2 to 2.24.3

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884143441 ## modules/core/src/main/java/org/apache/ignite/internal/util/PendingComparableValuesTracker.java: ## @@ -110,6 +110,35 @@ public void update(T newValue, @Nullable R fu

Re: [PR] IGNITE-23890 Java thin: remove reconnect throttling config props [ignite-3]

2024-12-13 Thread via GitHub
ptupitsyn commented on code in PR #4897: URL: https://github.com/apache/ignite-3/pull/4897#discussion_r1884139249 ## modules/client/src/main/java/org/apache/ignite/internal/client/ReliableChannel.java: ## @@ -754,8 +755,8 @@ class ClientChannelHolder { /** Address that

Re: [PR] IGNITE-23601 Create broadcast partitioned compute method [ignite-3]

2024-12-13 Thread via GitHub
ptupitsyn commented on code in PR #4871: URL: https://github.com/apache/ignite-3/pull/4871#discussion_r1884143620 ## modules/api/src/main/java/org/apache/ignite/compute/IgniteCompute.java: ## @@ -244,6 +244,98 @@ default Map executeBroadcast( return map; } +

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884148492 ## modules/distribution-zones/build.gradle: ## @@ -55,6 +55,7 @@ dependencies { testImplementation project(':ignite-metastorage') testImplementation project('

Re: [PR] IGNITE-23851 Remove IgniteFeatures#DISTRIBUTED_METASTORAGE and related code [ignite]

2024-12-13 Thread via GitHub
nizhikov merged PR #11737: URL: https://github.com/apache/ignite/pull/11737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-23601 Create broadcast partitioned compute method [ignite-3]

2024-12-13 Thread via GitHub
ptupitsyn commented on code in PR #4871: URL: https://github.com/apache/ignite-3/pull/4871#discussion_r1883963073 ## modules/api/src/main/java/org/apache/ignite/compute/IgniteCompute.java: ## @@ -244,6 +244,98 @@ default Map executeBroadcast( return map; } +

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884233512 ## modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicasSafeTimePropagationTest.java: ## @@ -86,6 +83,8 @@ public class ReplicasSafeTimePropagat

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884239660 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -202,19 +189,6 @@ private void onWriteBusy(Iterator> ite

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-13 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884250208 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterator> it