sanpwc commented on code in PR #4821:
URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884204969


##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/ActionRequestProcessor.java:
##########
@@ -109,20 +108,9 @@ protected void handleRequestInternal(RpcContext rpcCtx, 
Node node, ActionRequest
                 command = 
commandsMarshaller.unmarshall(writeRequest.command());
             }
 
-            if (fsm.getListener() instanceof BeforeApplyHandler) {
+            if (listener instanceof BeforeApplyHandler) {

Review Comment:
   I will repeat myself. I really don't like an idea of changing raft internals 
in order to inline some external concepts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to