sanpwc commented on code in PR #4821:
URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884196837
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java:
##########
@@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements
EventHandler<LogEntryAndClosu
// task list for batch
private final List<LogEntryAndClosure> tasks = new
ArrayList<>(NodeImpl.this.raftOptions.getApplyBatch());
+ private @Nullable HybridTimestamp safeTs = null;
Review Comment:
Agree with Roma, to be honest I don't like an idea of inlining safeTime
logic inside jraft. Despite the fact that you state opposite idea in PR
description "Also it's bad from the pluggable replication point of view,
because not all protocols require this concept.".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
