Cyrill commented on code in PR #4847:
URL: https://github.com/apache/ignite-3/pull/4847#discussion_r1883719973
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -2235,10 +2263,25 @@ private CompletableFuture<Void>
handleChangePendingAssignmentEvent(
return;
}
+ // A node might exist in stable yet we don't want to start
the replica
+ // The case is: nodes A, B and C hold a replication group,
+ // nodes A and B die.
+ // Reset adds C into force pending and user writes data
onto C.
+ // Then A and B go back online. In this case
+ // stable = [A, B, C], pending = [C, force] and only C
should be started.
+ if (isRecovery &&
!replicaMgr.isReplicaStarted(replicaGrpId)) {
Review Comment:
This check was moved from isNodeInReducedStableOrPendingAssignments, so
technically speaking, this check has already been there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
