sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884180223
########## modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java: ########## @@ -734,14 +733,6 @@ private void handleErrorResponse(CompletableFuture<? extends NetworkMessage> fut break; } - case EREORDER: - assert resp.maxObservableSafeTimeViolatedValue() != null : - "Unexpected combination of EREORDER error type and null in maxObservableSafeTimeViolatedValue."; - - fut.completeExceptionally(new SafeTimeReorderException(resp.maxObservableSafeTimeViolatedValue())); Review Comment: SafeTimeReorderException is still in use in comments ``` /** * Wrapper for the update(All)Command processing result that besides result itself stores actual command that was processed. It helps to * manage commands substitutions on SafeTimeReorderException where cloned command with adjusted safeTime is sent. */ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org