sanpwc commented on code in PR #4821:
URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884222746
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/command/SafeTimePropagatingCommand.java:
##########
@@ -26,7 +27,11 @@
* Common interface for commands carrying safe time.
*/
public interface SafeTimePropagatingCommand extends WriteCommand {
- /** Safe time. */
+ @Override
+ HybridTimestamp initiatorTime();
Review Comment:
Mmmm, I didn't get the concept.
- Initiator time is the time on the node that creates and sends the command,
right? In case of partitions it's primary replica?
- On leader you do calculate safeTime as `safeTs = command.initiatorTime()
== null ? clock.now() : clock.now(command.initiatorTime())` and then patch the
command with the safeTime.
All in all that means that Initiator time is a sort of timestampAware
messaging between the node that hosts raft-client and raft leader and safeTime
mechanics is now fully managed inside raft. Is that correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
