sanpwc commented on code in PR #4821:
URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1884233512


##########
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ReplicasSafeTimePropagationTest.java:
##########
@@ -86,6 +83,8 @@ public class ReplicasSafeTimePropagationTest extends 
IgniteAbstractTest {
     @InjectConfiguration("mock: { fsync: false }")
     private RaftConfiguration raftConfiguration;
 
+    private static final int MAX_CLOCK_SKEW = 500;

Review Comment:
   max clock skew is a part of configuration, why not to inject it? Or at least 
adding a todo that will let us not to forget to inject it when maxClockSkew 
will be extracted from SchemaSynchronizationConfiguration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to