ptupitsyn commented on code in PR #4871:
URL: https://github.com/apache/ignite-3/pull/4871#discussion_r1883653148
##########
modules/api/src/main/java/org/apache/ignite/compute/JobExecutionContext.java:
##########
@@ -36,4 +38,13 @@ public interface JobExecutionContext {
* @return {@code true} when the job was cancelled.
*/
boolean isCancelled();
+
+ /**
+ * List of partitions numbers associated with this job. Not a {@code null}
only when
+ * {@link IgniteCompute#submitBroadcastPartitioned(String, JobDescriptor,
Object)} method is used to submit jobs. In this case, the list
+ * contains partitions numbers that are local on the node executing the
job.
+ *
+ * @return list of partitions numbers associated with this job.
+ */
+ @Nullable List<Integer> partitions();
Review Comment:
```suggestion
@Nullable List<org.apache.ignite.table.partition.Partition> partitions();
```
Should be compatible with `PartitionManager` API.
##########
modules/client/src/main/java/org/apache/ignite/internal/client/compute/ClientCompute.java:
##########
@@ -236,6 +237,37 @@ public <T, R> R executeMapReduce(TaskDescriptor<T, R>
taskDescriptor, @Nullable
return sync(executeMapReduceAsync(taskDescriptor, cancellationToken,
arg));
}
+ @Override
+ public <T, R> CompletableFuture<Map<ClusterNode, JobExecution<R>>>
submitBroadcastPartitioned(
+ String tableName,
+ JobDescriptor<T, R> descriptor,
+ @Nullable T arg
+ ) {
+ Objects.requireNonNull(tableName);
+ Objects.requireNonNull(descriptor);
+ return failedFuture(new UnsupportedOperationException("Not
implemented"));
Review Comment:
Please create a ticket and add TODO for client impl. Ideally also tickets
for other clients (.NET, C++).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
