ygerzhedovich opened a new pull request, #5357:
URL: https://github.com/apache/ignite-3/pull/5357
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
IgGusev opened a new pull request, #5361:
URL: https://github.com/apache/ignite-3/pull/5361
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
##
korlov42 commented on code in PR #5311:
URL: https://github.com/apache/ignite-3/pull/5311#discussion_r1983525983
##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSecondaryIndexTest.java:
##
@@ -965,23 +987,29 @@ public void testNullsInSearch
PakhomovAlexander commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1983263290
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##
@@ -514,6 +519,18 @@ private CompletableFutur
sashapolo commented on code in PR #5315:
URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1983210856
##
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterInitializer.java:
##
@@ -107,29 +107,44 @@ public CompletableFuture
sashapolo merged PR #5370:
URL: https://github.com/apache/ignite-3/pull/5370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
lowka opened a new pull request, #5373:
URL: https://github.com/apache/ignite-3/pull/5373
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
###
rpuch merged PR #5366:
URL: https://github.com/apache/ignite-3/pull/5366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignit
asfgit closed pull request #11873: IGNITE-14964 SQL Calcite: Optimize IN
statement with literals
URL: https://github.com/apache/ignite/pull/11873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
JAkutenshi commented on code in PR #5366:
URL: https://github.com/apache/ignite-3/pull/5366#discussion_r1985341849
##
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItColocationTxRecoveryTest.java:
##
@@ -0,0 +1,106 @@
+/*
+
JAkutenshi commented on code in PR #5366:
URL: https://github.com/apache/ignite-3/pull/5366#discussion_r1985338744
##
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItColocationTxRecoveryTest.java:
##
@@ -0,0 +1,106 @@
+/*
+
sonarqubecloud[bot] commented on PR #11896:
URL: https://github.com/apache/ignite/pull/11896#issuecomment-2706838827
## [](https://son
denis-chudov opened a new pull request, #5372:
URL: https://github.com/apache/ignite-3/pull/5372
https://issues.apache.org/jira/browse/IGNITE-24735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ibessonov commented on code in PR #5365:
URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1985014929
##
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/throttling/SpeedBasedMemoryConsumptionThrottlingStrategy.java:
##
@@ -0,0 +1,4
rpuch opened a new pull request, #5371:
URL: https://github.com/apache/ignite-3/pull/5371
https://issues.apache.org/jira/browse/IGNITE-24363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
xtern commented on code in PR #5364:
URL: https://github.com/apache/ignite-3/pull/5364#discussion_r1985178149
##
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/storage/CatalogStorageSerializationTest.java:
##
@@ -0,0 +1,431 @@
+/*
+ * Licensed to the Apache Sof
xtern commented on code in PR #5364:
URL: https://github.com/apache/ignite-3/pull/5364#discussion_r1984983419
##
modules/catalog/src/test/resources/storage/SnapshotEntry.bin:
##
Review Comment:
~~I think it's worth adding a snapshot for "VersionedUpdate" as well
(containin
IgGusev opened a new pull request, #5360:
URL: https://github.com/apache/ignite-3/pull/5360
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
##
rpuch commented on code in PR #5366:
URL: https://github.com/apache/ignite-3/pull/5366#discussion_r1985119672
##
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItColocationTxRecoveryTest.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Li
ascherbakoff commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1985114216
##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java:
##
@@ -373,9 +373,12 @@ public void testMergeBatch() {
ascherbakoff commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1985109878
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##
@@ -1040,20 +1048,24 @@ private Row createKeyRow(int id) {
sashapolo opened a new pull request, #5370:
URL: https://github.com/apache/ignite-3/pull/5370
https://issues.apache.org/jira/browse/IGNITE-24733
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both
ascherbakoff commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1985108230
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##
@@ -1040,20 +1048,24 @@ private Row createKeyRow(int id) {
ascherbakoff commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1985108230
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##
@@ -1040,20 +1048,24 @@ private Row createKeyRow(int id) {
sashapolo commented on code in PR #5315:
URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1985104708
##
modules/runner/src/test/java/org/apache/ignite/InitParametersBuilderTest.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
rpuch commented on code in PR #5366:
URL: https://github.com/apache/ignite-3/pull/5366#discussion_r1985104193
##
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItColocationTxRecoveryTest.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Li
sashapolo commented on code in PR #5315:
URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1985068880
##
modules/runner/src/main/java/org/apache/ignite/InitParametersBuilder.java:
##
@@ -186,21 +173,13 @@ public InitParametersBuilder clusterName(String
clusterName)
ibessonov commented on code in PR #5365:
URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1985017837
##
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##
@@ -1315,6 +1315,23 @@ public Set dirtyPages() {
JAkutenshi commented on code in PR #5366:
URL: https://github.com/apache/ignite-3/pull/5366#discussion_r1984987136
##
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/handlers/ReplicaSafeTimeSyncRequestHandler.java:
##
@@ -54,9 +56,14 @@
ibessonov commented on code in PR #5365:
URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1985018516
##
modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/throttling/IgniteThrottlingTest.java:
##
@@ -0,0 +1,421 @@
+/*
+ * Licensed to
ibessonov commented on code in PR #5365:
URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1985016577
##
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/throttling/SpeedBasedMemoryConsumptionThrottlingStrategy.java:
##
@@ -0,0 +1,4
korlov42 opened a new pull request, #5369:
URL: https://github.com/apache/ignite-3/pull/5369
https://issues.apache.org/jira/browse/IGNITE-24732
--
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
rpuch commented on code in PR #5365:
URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1984908151
##
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##
@@ -1315,6 +1315,23 @@ public Set dirtyPages() {
lowka commented on PR #5364:
URL: https://github.com/apache/ignite-3/pull/5364#issuecomment-2706349549
Every update entry is wrapped in `VersionedUpdate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
xtern commented on code in PR #5364:
URL: https://github.com/apache/ignite-3/pull/5364#discussion_r1984983419
##
modules/catalog/src/test/resources/storage/SnapshotEntry.bin:
##
Review Comment:
I think it's worth adding a snapshot for "VersionedUpdate" as well
(containing
slukyano commented on code in PR #5315:
URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984981446
##
modules/runner/src/main/java/org/apache/ignite/InitParametersBuilder.java:
##
@@ -186,21 +173,13 @@ public InitParametersBuilder clusterName(String
clusterName) {
slukyano commented on code in PR #5315:
URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984978663
##
modules/runner/src/main/java/org/apache/ignite/InitParameters.java:
##
@@ -45,17 +46,15 @@ public class InitParameters {
* @param clusterConfiguration Cluste
sk0x50 merged PR #5363:
URL: https://github.com/apache/ignite-3/pull/5363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@igni
sashapolo commented on code in PR #5367:
URL: https://github.com/apache/ignite-3/pull/5367#discussion_r1984960760
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##
@@ -3024,15 +3015,12 @@ private void startTables(long recoveryRevis
skorotkov commented on code in PR #11906:
URL: https://github.com/apache/ignite/pull/11906#discussion_r1984931961
##
modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/sql/tpch/TpchBenchmark.java:
##
@@ -0,0 +1,302 @@
+/*
+ * Licensed to the Apache Softwa
rpuch commented on code in PR #5345:
URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1984868108
##
modules/network-api/src/main/java/org/apache/ignite/internal/network/NodeFinder.java:
##
@@ -36,4 +36,7 @@ public interface NodeFinder extends ManuallyCloseable {
Phillippko commented on code in PR #5365:
URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1984741784
##
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/throttling/PagesWriteSpeedBasedThrottle.java:
##
@@ -0,0 +1,321 @@
+/*
+ * Li
skorotkov commented on code in PR #11906:
URL: https://github.com/apache/ignite/pull/11906#discussion_r1984896566
##
modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/sql/tpch/TpchBenchmark.java:
##
@@ -0,0 +1,302 @@
+/*
+ * Licensed to the Apache Softwa
skorotkov commented on code in PR #11906:
URL: https://github.com/apache/ignite/pull/11906#discussion_r1984892095
##
modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/sql/tpch/TpchBenchmark.java:
##
@@ -0,0 +1,302 @@
+/*
+ * Licensed to the Apache Softwa
rpuch merged PR #5359:
URL: https://github.com/apache/ignite-3/pull/5359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignit
rpuch commented on code in PR #5352:
URL: https://github.com/apache/ignite-3/pull/5352#discussion_r1983147280
##
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaPrimacyEngine.java:
##
@@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apa
AMashenkov opened a new pull request, #5368:
URL: https://github.com/apache/ignite-3/pull/5368
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
rpuch commented on code in PR #5359:
URL: https://github.com/apache/ignite-3/pull/5359#discussion_r1984835541
##
modules/transactions/src/test/java/org/apache/ignite/internal/tx/TxManagerTest.java:
##
@@ -116,6 +118,7 @@
*/
@ExtendWith(ConfigurationExtension.class)
@ExtendWi
alievmirza commented on code in PR #5367:
URL: https://github.com/apache/ignite-3/pull/5367#discussion_r1984869440
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##
@@ -3024,15 +3015,12 @@ private void startTables(long recoveryRevi
skorotkov commented on code in PR #11906:
URL: https://github.com/apache/ignite/pull/11906#discussion_r1984857798
##
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/tpch/TpchHelper.java:
##
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the A
Phillippko commented on code in PR #5345:
URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1984870132
##
modules/network/src/main/java/org/apache/ignite/internal/network/configuration/MulticastConfigurationSchema.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apa
skorotkov commented on code in PR #11906:
URL: https://github.com/apache/ignite/pull/11906#discussion_r1984855196
##
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/tpch/TpchHelper.java:
##
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the A
rpuch commented on code in PR #5345:
URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1984862825
##
modules/network/src/main/java/org/apache/ignite/internal/network/configuration/MulticastConfigurationSchema.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache S
skorotkov commented on code in PR #11906:
URL: https://github.com/apache/ignite/pull/11906#discussion_r1984855196
##
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/tpch/TpchHelper.java:
##
@@ -0,0 +1,360 @@
+/*
+ * Licensed to the A
nva opened a new pull request, #301:
URL: https://github.com/apache/ignite-extensions/pull/301
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
timoninmaxim commented on code in PR #11906:
URL: https://github.com/apache/ignite/pull/11906#discussion_r1984815003
##
modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/sql/tpch/TpchBenchmark.java:
##
@@ -0,0 +1,302 @@
+/*
+ * Licensed to the Apache Sof
sashapolo opened a new pull request, #5367:
URL: https://github.com/apache/ignite-3/pull/5367
https://issues.apache.org/jira/browse/IGNITE-24728
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both
PakhomovAlexander commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1984751374
##
modules/transactions/src/main/java/org/apache/ignite/internal/tx/InternalTransaction.java:
##
@@ -117,9 +117,10 @@ void enlist(
* @param executionTi
Phillippko commented on code in PR #5365:
URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1984758378
##
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##
@@ -1425,6 +1442,13 @@ private void close() {
korlov42 merged PR #5355:
URL: https://github.com/apache/ignite-3/pull/5355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ig
PakhomovAlexander commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1984744117
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##
@@ -1730,16 +1761,21 @@ protected CompletableF
PakhomovAlexander commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1984743059
##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java:
##
@@ -373,9 +373,12 @@ public void testMergeBatch() {
PakhomovAlexander commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1984741531
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##
@@ -1040,20 +1048,24 @@ private Row createKeyRow(int id)
zstan commented on code in PR #5311:
URL: https://github.com/apache/ignite-3/pull/5311#discussion_r1984734483
##
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSecondaryIndexTest.java:
##
@@ -965,23 +987,29 @@ public void testNullsInSearchRow
ascherbakoff commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1984547524
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##
@@ -578,10 +585,12 @@ public void testTwiceScanInTransaction(
PakhomovAlexander commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1984729724
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##
@@ -578,10 +585,12 @@ public void testTwiceScanInTransac
Phillippko commented on code in PR #5345:
URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1984448644
##
modules/network/src/main/java/org/apache/ignite/internal/network/MulticastNodeFinder.java:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundatio
Phillippko commented on code in PR #5345:
URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1984480437
##
modules/network/src/main/java/org/apache/ignite/internal/network/configuration/MulticastConfigurationSchema.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apa
Phillippko commented on code in PR #5345:
URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1984480437
##
modules/network/src/main/java/org/apache/ignite/internal/network/configuration/MulticastConfigurationSchema.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apa
sashapolo commented on code in PR #5359:
URL: https://github.com/apache/ignite-3/pull/5359#discussion_r1984686328
##
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItInternalTableReadWriteScanTest.java:
##
@@ -91,4 +92,8 @@ protected InternalTransaction sta
rpuch merged PR #5358:
URL: https://github.com/apache/ignite-3/pull/5358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignit
sashapolo commented on code in PR #5315:
URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984614310
##
modules/runner/src/main/java/org/apache/ignite/InitParametersBuilder.java:
##
@@ -186,21 +173,13 @@ public InitParametersBuilder clusterName(String
clusterName)
12rcu commented on code in PR #5158:
URL: https://github.com/apache/ignite-3/pull/5158#discussion_r1984650114
##
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java:
##
@@ -2710,28 +2717,33 @@ public void
testAppendEntriesWhenFollowerIsInErro
rpuch opened a new pull request, #5366:
URL: https://github.com/apache/ignite-3/pull/5366
https://issues.apache.org/jira/browse/IGNITE-24361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
chesnokoff opened a new pull request, #11915:
URL: https://github.com/apache/ignite/pull/11915
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
###
sashapolo commented on code in PR #5315:
URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984606446
##
docs/_docs/administrators-guide/lifecycle.adoc:
##
@@ -40,7 +40,15 @@ First, the nodes specified in the
`--cluster-management-group` argument form a R
image::
Phillippko commented on code in PR #5358:
URL: https://github.com/apache/ignite-3/pull/5358#discussion_r1984434716
##
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/time/ClusterTimeImpl.java:
##
@@ -209,30 +233,42 @@ synchronized void schedule()
ibessonov opened a new pull request, #5365:
URL: https://github.com/apache/ignite-3/pull/5365
https://issues.apache.org/jira/browse/IGNITE-24547
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both
78 matches
Mail list logo