[PR] IGNITE-24429 Sql. Get rid of support of BINARY datatype. [ignite-3]

2025-03-07 Thread via GitHub
ygerzhedovich opened a new pull request, #5357: URL: https://github.com/apache/ignite-3/pull/5357 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

[PR] IGN-27058 Fixing ignite groupid [ignite-3]

2025-03-07 Thread via GitHub
IgGusev opened a new pull request, #5361: URL: https://github.com/apache/ignite-3/pull/5361 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ##

Re: [PR] IGNITE-24307 Sql. Query plan does not use the most optimal table index [ignite-3]

2025-03-07 Thread via GitHub
korlov42 commented on code in PR #5311: URL: https://github.com/apache/ignite-3/pull/5311#discussion_r1983525983 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSecondaryIndexTest.java: ## @@ -965,23 +987,29 @@ public void testNullsInSearch

Re: [PR] IGNITE-24244 Support timeout in RW transactions [ignite-3]

2025-03-07 Thread via GitHub
PakhomovAlexander commented on code in PR #5209: URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1983263290 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -514,6 +519,18 @@ private CompletableFutur

Re: [PR] IGNITE-24035 Implemented default values for MS and CMG node lists on init [ignite-3]

2025-03-07 Thread via GitHub
sashapolo commented on code in PR #5315: URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1983210856 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterInitializer.java: ## @@ -107,29 +107,44 @@ public CompletableFuture

Re: [PR] IGNITE-24733 Add checkstyle rule to enforce line breaks at the end of files [ignite-3]

2025-03-07 Thread via GitHub
sashapolo merged PR #5370: URL: https://github.com/apache/ignite-3/pull/5370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[PR] Ignite 24698 [ignite-3]

2025-03-07 Thread via GitHub
lowka opened a new pull request, #5373: URL: https://github.com/apache/ignite-3/pull/5373 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ###

Re: [PR] IGNITE-24361 Implement TxRecoveryMessage processing for zone replica [ignite-3]

2025-03-07 Thread via GitHub
rpuch merged PR #5366: URL: https://github.com/apache/ignite-3/pull/5366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-14964 SQL Calcite: Optimize IN statement with literals [ignite]

2025-03-07 Thread via GitHub
asfgit closed pull request #11873: IGNITE-14964 SQL Calcite: Optimize IN statement with literals URL: https://github.com/apache/ignite/pull/11873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] IGNITE-24361 Implement TxRecoveryMessage processing for zone replica [ignite-3]

2025-03-07 Thread via GitHub
JAkutenshi commented on code in PR #5366: URL: https://github.com/apache/ignite-3/pull/5366#discussion_r1985341849 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItColocationTxRecoveryTest.java: ## @@ -0,0 +1,106 @@ +/* +

Re: [PR] IGNITE-24361 Implement TxRecoveryMessage processing for zone replica [ignite-3]

2025-03-07 Thread via GitHub
JAkutenshi commented on code in PR #5366: URL: https://github.com/apache/ignite-3/pull/5366#discussion_r1985338744 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItColocationTxRecoveryTest.java: ## @@ -0,0 +1,106 @@ +/* +

Re: [PR] IGNITE-24130 Support of data region storage path implemented [ignite]

2025-03-07 Thread via GitHub
sonarqubecloud[bot] commented on PR #11896: URL: https://github.com/apache/ignite/pull/11896#issuecomment-2706838827 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

[PR] IGNITE-24735 Remove catalog version from DataNodesManager#dataNodes parameters [ignite-3]

2025-03-07 Thread via GitHub
denis-chudov opened a new pull request, #5372: URL: https://github.com/apache/ignite-3/pull/5372 https://issues.apache.org/jira/browse/IGNITE-24735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] IGNITE-24547 Port speed-based throttling from Ignite 2 [ignite-3]

2025-03-07 Thread via GitHub
ibessonov commented on code in PR #5365: URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1985014929 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/throttling/SpeedBasedMemoryConsumptionThrottlingStrategy.java: ## @@ -0,0 +1,4

[PR] Implement TxCleanupRecoveryRequest processing for zone replica [ignite-3]

2025-03-07 Thread via GitHub
rpuch opened a new pull request, #5371: URL: https://github.com/apache/ignite-3/pull/5371 https://issues.apache.org/jira/browse/IGNITE-24363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-24563 Sql. Add tests to ensure catalog object serialization backward compatibility [ignite-3]

2025-03-07 Thread via GitHub
xtern commented on code in PR #5364: URL: https://github.com/apache/ignite-3/pull/5364#discussion_r1985178149 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/storage/CatalogStorageSerializationTest.java: ## @@ -0,0 +1,431 @@ +/* + * Licensed to the Apache Sof

Re: [PR] IGNITE-24563 Sql. Add tests to ensure catalog object serialization backward compatibility [ignite-3]

2025-03-07 Thread via GitHub
xtern commented on code in PR #5364: URL: https://github.com/apache/ignite-3/pull/5364#discussion_r1984983419 ## modules/catalog/src/test/resources/storage/SnapshotEntry.bin: ## Review Comment: ~~I think it's worth adding a snapshot for "VersionedUpdate" as well (containin

[PR] IGN-27058 Fixing ignite groupid [ignite-3]

2025-03-07 Thread via GitHub
IgGusev opened a new pull request, #5360: URL: https://github.com/apache/ignite-3/pull/5360 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ##

Re: [PR] IGNITE-24361 Implement TxRecoveryMessage processing for zone replica [ignite-3]

2025-03-07 Thread via GitHub
rpuch commented on code in PR #5366: URL: https://github.com/apache/ignite-3/pull/5366#discussion_r1985119672 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItColocationTxRecoveryTest.java: ## @@ -0,0 +1,106 @@ +/* + * Li

Re: [PR] IGNITE-24244 Support timeout in RW transactions [ignite-3]

2025-03-07 Thread via GitHub
ascherbakoff commented on code in PR #5209: URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1985114216 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java: ## @@ -373,9 +373,12 @@ public void testMergeBatch() {

Re: [PR] IGNITE-24244 Support timeout in RW transactions [ignite-3]

2025-03-07 Thread via GitHub
ascherbakoff commented on code in PR #5209: URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1985109878 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java: ## @@ -1040,20 +1048,24 @@ private Row createKeyRow(int id) {

[PR] IGNITE-24733 Add checkstyle rule to enforce line breaks at the end of files [ignite-3]

2025-03-07 Thread via GitHub
sashapolo opened a new pull request, #5370: URL: https://github.com/apache/ignite-3/pull/5370 https://issues.apache.org/jira/browse/IGNITE-24733 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-24244 Support timeout in RW transactions [ignite-3]

2025-03-07 Thread via GitHub
ascherbakoff commented on code in PR #5209: URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1985108230 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java: ## @@ -1040,20 +1048,24 @@ private Row createKeyRow(int id) {

Re: [PR] IGNITE-24244 Support timeout in RW transactions [ignite-3]

2025-03-07 Thread via GitHub
ascherbakoff commented on code in PR #5209: URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1985108230 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java: ## @@ -1040,20 +1048,24 @@ private Row createKeyRow(int id) {

Re: [PR] IGNITE-24035 Implemented default values for MS and CMG node lists on init [ignite-3]

2025-03-07 Thread via GitHub
sashapolo commented on code in PR #5315: URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1985104708 ## modules/runner/src/test/java/org/apache/ignite/InitParametersBuilderTest.java: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] IGNITE-24361 Implement TxRecoveryMessage processing for zone replica [ignite-3]

2025-03-07 Thread via GitHub
rpuch commented on code in PR #5366: URL: https://github.com/apache/ignite-3/pull/5366#discussion_r1985104193 ## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItColocationTxRecoveryTest.java: ## @@ -0,0 +1,106 @@ +/* + * Li

Re: [PR] IGNITE-24035 Implemented default values for MS and CMG node lists on init [ignite-3]

2025-03-07 Thread via GitHub
sashapolo commented on code in PR #5315: URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1985068880 ## modules/runner/src/main/java/org/apache/ignite/InitParametersBuilder.java: ## @@ -186,21 +173,13 @@ public InitParametersBuilder clusterName(String clusterName)

Re: [PR] IGNITE-24547 Port speed-based throttling from Ignite 2 [ignite-3]

2025-03-07 Thread via GitHub
ibessonov commented on code in PR #5365: URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1985017837 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java: ## @@ -1315,6 +1315,23 @@ public Set dirtyPages() {

Re: [PR] IGNITE-24361 Implement TxRecoveryMessage processing for zone replica [ignite-3]

2025-03-07 Thread via GitHub
JAkutenshi commented on code in PR #5366: URL: https://github.com/apache/ignite-3/pull/5366#discussion_r1984987136 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/handlers/ReplicaSafeTimeSyncRequestHandler.java: ## @@ -54,9 +56,14 @@

Re: [PR] IGNITE-24547 Port speed-based throttling from Ignite 2 [ignite-3]

2025-03-07 Thread via GitHub
ibessonov commented on code in PR #5365: URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1985018516 ## modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/throttling/IgniteThrottlingTest.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to

Re: [PR] IGNITE-24547 Port speed-based throttling from Ignite 2 [ignite-3]

2025-03-07 Thread via GitHub
ibessonov commented on code in PR #5365: URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1985016577 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/throttling/SpeedBasedMemoryConsumptionThrottlingStrategy.java: ## @@ -0,0 +1,4

[PR] IGNITE-24732 Sql. Avoid expression lookup on every expression invocation [ignite-3]

2025-03-07 Thread via GitHub
korlov42 opened a new pull request, #5369: URL: https://github.com/apache/ignite-3/pull/5369 https://issues.apache.org/jira/browse/IGNITE-24732 -- Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality

Re: [PR] IGNITE-24547 Port speed-based throttling from Ignite 2 [ignite-3]

2025-03-07 Thread via GitHub
rpuch commented on code in PR #5365: URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1984908151 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java: ## @@ -1315,6 +1315,23 @@ public Set dirtyPages() {

Re: [PR] IGNITE-24563 Sql. Add tests to ensure catalog object serialization backward compatibility [ignite-3]

2025-03-07 Thread via GitHub
lowka commented on PR #5364: URL: https://github.com/apache/ignite-3/pull/5364#issuecomment-2706349549 Every update entry is wrapped in `VersionedUpdate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] IGNITE-24563 Sql. Add tests to ensure catalog object serialization backward compatibility [ignite-3]

2025-03-07 Thread via GitHub
xtern commented on code in PR #5364: URL: https://github.com/apache/ignite-3/pull/5364#discussion_r1984983419 ## modules/catalog/src/test/resources/storage/SnapshotEntry.bin: ## Review Comment: I think it's worth adding a snapshot for "VersionedUpdate" as well (containing

Re: [PR] IGNITE-24035 Implemented default values for MS and CMG node lists on init [ignite-3]

2025-03-07 Thread via GitHub
slukyano commented on code in PR #5315: URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984981446 ## modules/runner/src/main/java/org/apache/ignite/InitParametersBuilder.java: ## @@ -186,21 +173,13 @@ public InitParametersBuilder clusterName(String clusterName) {

Re: [PR] IGNITE-24035 Implemented default values for MS and CMG node lists on init [ignite-3]

2025-03-07 Thread via GitHub
slukyano commented on code in PR #5315: URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984978663 ## modules/runner/src/main/java/org/apache/ignite/InitParameters.java: ## @@ -45,17 +46,15 @@ public class InitParameters { * @param clusterConfiguration Cluste

Re: [PR] Bump com.github.spotbugs from 6.1.6 to 6.1.7 [ignite-3]

2025-03-07 Thread via GitHub
sk0x50 merged PR #5363: URL: https://github.com/apache/ignite-3/pull/5363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

Re: [PR] IGNITE-24728 Remove startVv from TableManager [ignite-3]

2025-03-07 Thread via GitHub
sashapolo commented on code in PR #5367: URL: https://github.com/apache/ignite-3/pull/5367#discussion_r1984960760 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -3024,15 +3015,12 @@ private void startTables(long recoveryRevis

Re: [PR] IGNITE-24685 Add Jmh benchmark and helper fot TPC-H queries [ignite]

2025-03-07 Thread via GitHub
skorotkov commented on code in PR #11906: URL: https://github.com/apache/ignite/pull/11906#discussion_r1984931961 ## modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/sql/tpch/TpchBenchmark.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] IGNITE-24400 Implement multicast finder [ignite-3]

2025-03-07 Thread via GitHub
rpuch commented on code in PR #5345: URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1984868108 ## modules/network-api/src/main/java/org/apache/ignite/internal/network/NodeFinder.java: ## @@ -36,4 +36,7 @@ public interface NodeFinder extends ManuallyCloseable {

Re: [PR] IGNITE-24547 Port speed-based throttling from Ignite 2 [ignite-3]

2025-03-07 Thread via GitHub
Phillippko commented on code in PR #5365: URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1984741784 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/throttling/PagesWriteSpeedBasedThrottle.java: ## @@ -0,0 +1,321 @@ +/* + * Li

Re: [PR] IGNITE-24685 Add Jmh benchmark and helper fot TPC-H queries [ignite]

2025-03-07 Thread via GitHub
skorotkov commented on code in PR #11906: URL: https://github.com/apache/ignite/pull/11906#discussion_r1984896566 ## modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/sql/tpch/TpchBenchmark.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] IGNITE-24685 Add Jmh benchmark and helper fot TPC-H queries [ignite]

2025-03-07 Thread via GitHub
skorotkov commented on code in PR #11906: URL: https://github.com/apache/ignite/pull/11906#discussion_r1984892095 ## modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/sql/tpch/TpchBenchmark.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] IGNITE-24695 Assert replication group type on enlistment [ignite-3]

2025-03-07 Thread via GitHub
rpuch merged PR #5359: URL: https://github.com/apache/ignite-3/pull/5359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-24380 Move ensureReplicaIsPrimary logic to ZonePartitionReplicaListener [ignite-3]

2025-03-07 Thread via GitHub
rpuch commented on code in PR #5352: URL: https://github.com/apache/ignite-3/pull/5352#discussion_r1983147280 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaPrimacyEngine.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apa

[PR] IGNITE-23960 Sql. Execution node should not hold thread for too long [ignite-3]

2025-03-07 Thread via GitHub
AMashenkov opened a new pull request, #5368: URL: https://github.com/apache/ignite-3/pull/5368 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-24695 Assert replication group type on enlistment [ignite-3]

2025-03-07 Thread via GitHub
rpuch commented on code in PR #5359: URL: https://github.com/apache/ignite-3/pull/5359#discussion_r1984835541 ## modules/transactions/src/test/java/org/apache/ignite/internal/tx/TxManagerTest.java: ## @@ -116,6 +118,7 @@ */ @ExtendWith(ConfigurationExtension.class) @ExtendWi

Re: [PR] IGNITE-24728 Remove startVv from TableManager [ignite-3]

2025-03-07 Thread via GitHub
alievmirza commented on code in PR #5367: URL: https://github.com/apache/ignite-3/pull/5367#discussion_r1984869440 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -3024,15 +3015,12 @@ private void startTables(long recoveryRevi

Re: [PR] IGNITE-24685 Add Jmh benchmark and helper fot TPC-H queries [ignite]

2025-03-07 Thread via GitHub
skorotkov commented on code in PR #11906: URL: https://github.com/apache/ignite/pull/11906#discussion_r1984857798 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/tpch/TpchHelper.java: ## @@ -0,0 +1,360 @@ +/* + * Licensed to the A

Re: [PR] IGNITE-24400 Implement multicast finder [ignite-3]

2025-03-07 Thread via GitHub
Phillippko commented on code in PR #5345: URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1984870132 ## modules/network/src/main/java/org/apache/ignite/internal/network/configuration/MulticastConfigurationSchema.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apa

Re: [PR] IGNITE-24685 Add Jmh benchmark and helper fot TPC-H queries [ignite]

2025-03-07 Thread via GitHub
skorotkov commented on code in PR #11906: URL: https://github.com/apache/ignite/pull/11906#discussion_r1984855196 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/tpch/TpchHelper.java: ## @@ -0,0 +1,360 @@ +/* + * Licensed to the A

Re: [PR] IGNITE-24400 Implement multicast finder [ignite-3]

2025-03-07 Thread via GitHub
rpuch commented on code in PR #5345: URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1984862825 ## modules/network/src/main/java/org/apache/ignite/internal/network/configuration/MulticastConfigurationSchema.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache S

Re: [PR] IGNITE-24685 Add Jmh benchmark and helper fot TPC-H queries [ignite]

2025-03-07 Thread via GitHub
skorotkov commented on code in PR #11906: URL: https://github.com/apache/ignite/pull/11906#discussion_r1984855196 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/tpch/TpchHelper.java: ## @@ -0,0 +1,360 @@ +/* + * Licensed to the A

[PR] IGNITE-24729 Spring Data: Fix checkstyle for the module. [ignite-extensions]

2025-03-07 Thread via GitHub
nva opened a new pull request, #301: URL: https://github.com/apache/ignite-extensions/pull/301 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] IGNITE-24685 Add Jmh benchmark and helper fot TPC-H queries [ignite]

2025-03-07 Thread via GitHub
timoninmaxim commented on code in PR #11906: URL: https://github.com/apache/ignite/pull/11906#discussion_r1984815003 ## modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/sql/tpch/TpchBenchmark.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Sof

[PR] IGNITE-24728 Remove startVv from TableManager [ignite-3]

2025-03-07 Thread via GitHub
sashapolo opened a new pull request, #5367: URL: https://github.com/apache/ignite-3/pull/5367 https://issues.apache.org/jira/browse/IGNITE-24728 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

Re: [PR] IGNITE-24244 Support timeout in RW transactions [ignite-3]

2025-03-07 Thread via GitHub
PakhomovAlexander commented on code in PR #5209: URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1984751374 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/InternalTransaction.java: ## @@ -117,9 +117,10 @@ void enlist( * @param executionTi

Re: [PR] IGNITE-24547 Port speed-based throttling from Ignite 2 [ignite-3]

2025-03-07 Thread via GitHub
Phillippko commented on code in PR #5365: URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1984758378 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java: ## @@ -1425,6 +1442,13 @@ private void close() {

Re: [PR] IGNITE-24658 Sql. Fix NPE in ReadWriteTransactionImpl#enlist [ignite-3]

2025-03-07 Thread via GitHub
korlov42 merged PR #5355: URL: https://github.com/apache/ignite-3/pull/5355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-24244 Support timeout in RW transactions [ignite-3]

2025-03-07 Thread via GitHub
PakhomovAlexander commented on code in PR #5209: URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1984744117 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -1730,16 +1761,21 @@ protected CompletableF

Re: [PR] IGNITE-24244 Support timeout in RW transactions [ignite-3]

2025-03-07 Thread via GitHub
PakhomovAlexander commented on code in PR #5209: URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1984743059 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDmlTest.java: ## @@ -373,9 +373,12 @@ public void testMergeBatch() {

Re: [PR] IGNITE-24244 Support timeout in RW transactions [ignite-3]

2025-03-07 Thread via GitHub
PakhomovAlexander commented on code in PR #5209: URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1984741531 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java: ## @@ -1040,20 +1048,24 @@ private Row createKeyRow(int id)

Re: [PR] IGNITE-24307 Sql. Query plan does not use the most optimal table index [ignite-3]

2025-03-07 Thread via GitHub
zstan commented on code in PR #5311: URL: https://github.com/apache/ignite-3/pull/5311#discussion_r1984734483 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSecondaryIndexTest.java: ## @@ -965,23 +987,29 @@ public void testNullsInSearchRow

Re: [PR] IGNITE-24244 Support timeout in RW transactions [ignite-3]

2025-03-07 Thread via GitHub
ascherbakoff commented on code in PR #5209: URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1984547524 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java: ## @@ -578,10 +585,12 @@ public void testTwiceScanInTransaction(

Re: [PR] IGNITE-24244 Support timeout in RW transactions [ignite-3]

2025-03-07 Thread via GitHub
PakhomovAlexander commented on code in PR #5209: URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1984729724 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java: ## @@ -578,10 +585,12 @@ public void testTwiceScanInTransac

Re: [PR] IGNITE-24400 Implement multicast finder [ignite-3]

2025-03-07 Thread via GitHub
Phillippko commented on code in PR #5345: URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1984448644 ## modules/network/src/main/java/org/apache/ignite/internal/network/MulticastNodeFinder.java: ## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] IGNITE-24400 Implement multicast finder [ignite-3]

2025-03-07 Thread via GitHub
Phillippko commented on code in PR #5345: URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1984480437 ## modules/network/src/main/java/org/apache/ignite/internal/network/configuration/MulticastConfigurationSchema.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apa

Re: [PR] IGNITE-24400 Implement multicast finder [ignite-3]

2025-03-07 Thread via GitHub
Phillippko commented on code in PR #5345: URL: https://github.com/apache/ignite-3/pull/5345#discussion_r1984480437 ## modules/network/src/main/java/org/apache/ignite/internal/network/configuration/MulticastConfigurationSchema.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apa

Re: [PR] IGNITE-24695 Assert replication group type on enlistment [ignite-3]

2025-03-07 Thread via GitHub
sashapolo commented on code in PR #5359: URL: https://github.com/apache/ignite-3/pull/5359#discussion_r1984686328 ## modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItInternalTableReadWriteScanTest.java: ## @@ -91,4 +92,8 @@ protected InternalTransaction sta

Re: [PR] IGNITE-24717 Improve handling of Metastorage safe time sync problems [ignite-3]

2025-03-07 Thread via GitHub
rpuch merged PR #5358: URL: https://github.com/apache/ignite-3/pull/5358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-24035 Implemented default values for MS and CMG node lists on init [ignite-3]

2025-03-07 Thread via GitHub
sashapolo commented on code in PR #5315: URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984614310 ## modules/runner/src/main/java/org/apache/ignite/InitParametersBuilder.java: ## @@ -186,21 +173,13 @@ public InitParametersBuilder clusterName(String clusterName)

Re: [PR] Make ItNodeTest#testFollowerStartStopFollowing more resilient against flakiness [ignite-3]

2025-03-07 Thread via GitHub
12rcu commented on code in PR #5158: URL: https://github.com/apache/ignite-3/pull/5158#discussion_r1984650114 ## modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java: ## @@ -2710,28 +2717,33 @@ public void testAppendEntriesWhenFollowerIsInErro

[PR] IGNITE-24361 Implement TxRecoveryMessage processing for zone replica [ignite-3]

2025-03-07 Thread via GitHub
rpuch opened a new pull request, #5366: URL: https://github.com/apache/ignite-3/pull/5366 https://issues.apache.org/jira/browse/IGNITE-24361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] Ignite 24286 wip [ignite]

2025-03-07 Thread via GitHub
chesnokoff opened a new pull request, #11915: URL: https://github.com/apache/ignite/pull/11915 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

Re: [PR] IGNITE-24035 Implemented default values for MS and CMG node lists on init [ignite-3]

2025-03-07 Thread via GitHub
sashapolo commented on code in PR #5315: URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984606446 ## docs/_docs/administrators-guide/lifecycle.adoc: ## @@ -40,7 +40,15 @@ First, the nodes specified in the `--cluster-management-group` argument form a R image::

Re: [PR] IGNITE-24717 Improve handling of Metastorage safe time sync problems [ignite-3]

2025-03-07 Thread via GitHub
Phillippko commented on code in PR #5358: URL: https://github.com/apache/ignite-3/pull/5358#discussion_r1984434716 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/time/ClusterTimeImpl.java: ## @@ -209,30 +233,42 @@ synchronized void schedule()

[PR] IGNITE-24547 Port speed-based throttling from Ignite 2 [ignite-3]

2025-03-07 Thread via GitHub
ibessonov opened a new pull request, #5365: URL: https://github.com/apache/ignite-3/pull/5365 https://issues.apache.org/jira/browse/IGNITE-24547 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both