ibessonov commented on code in PR #5365: URL: https://github.com/apache/ignite-3/pull/5365#discussion_r1985016577
########## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/throttling/SpeedBasedMemoryConsumptionThrottlingStrategy.java: ########## @@ -0,0 +1,482 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.pagememory.persistence.throttling; + +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.function.Supplier; +import org.apache.ignite.internal.pagememory.persistence.PersistentPageMemory; +import org.apache.ignite.internal.pagememory.persistence.checkpoint.CheckpointProgress; + +/** + * Speed-based throttle used to protect clean pages from exhaustion. + * + * <p>The main method is {@link #protectionParkTime(long)} which is used to compute park time, if throttling is needed. + * + * @see #protectionParkTime(long) + */ +class SpeedBasedMemoryConsumptionThrottlingStrategy { + /** Maximum fraction of dirty pages in a region. */ + private static final double MAX_DIRTY_PAGES = 0.75; Review Comment: It would make sense to do so. Right now I would not want to do that, concentrating on "porting" first, and "fixing" later, I have a separate task for that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
