alievmirza commented on code in PR #5367:
URL: https://github.com/apache/ignite-3/pull/5367#discussion_r1984869440
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -3024,15 +3015,12 @@ private void startTables(long recoveryRevision,
@Nullable HybridTimestamp lwm) {
LOG.debug("Tables started successfully");
}
});
-
- // Forces you to wait until recovery is complete before the metastore
watches is deployed to avoid races with catalog listeners.
- startVv.update(recoveryRevision, (unused, throwable) ->
allTablesStartedFuture);
Review Comment:
Do we preserve such invariant with a new approach?
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -3024,15 +3015,12 @@ private void startTables(long recoveryRevision,
@Nullable HybridTimestamp lwm) {
LOG.debug("Tables started successfully");
}
});
-
- // Forces you to wait until recovery is complete before the metastore
watches is deployed to avoid races with catalog listeners.
- startVv.update(recoveryRevision, (unused, throwable) ->
allTablesStartedFuture);
Review Comment:
Do we preserve such invariant with the new approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
