sashapolo commented on code in PR #5359:
URL: https://github.com/apache/ignite-3/pull/5359#discussion_r1984686328
##########
modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItInternalTableReadWriteScanTest.java:
##########
@@ -91,4 +92,8 @@ protected InternalTransaction startTx() {
return tx;
}
+
+ ReplicationGroupId targetReplicationGroupId(int tableOrZoneId, int partId)
{
Review Comment:
Should we also have a TODO to remove this method?
##########
modules/transactions/src/test/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImplTest.java:
##########
@@ -53,6 +55,7 @@
import org.mockito.junit.jupiter.MockitoExtension;
@ExtendWith(MockitoExtension.class)
+@WithSystemProperty(key = IgniteSystemProperties.COLOCATION_FEATURE_FLAG,
value = "true")
Review Comment:
Sam question
##########
modules/transactions/src/test/java/org/apache/ignite/internal/tx/TxManagerTest.java:
##########
@@ -116,6 +118,7 @@
*/
@ExtendWith(ConfigurationExtension.class)
@ExtendWith(ExecutorServiceExtension.class)
+@WithSystemProperty(key = IgniteSystemProperties.COLOCATION_FEATURE_FLAG,
value = "true")
Review Comment:
Why is this needed? What about testing the non-colocated approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
