slukyano commented on code in PR #5315:
URL: https://github.com/apache/ignite-3/pull/5315#discussion_r1984981446
##########
modules/runner/src/main/java/org/apache/ignite/InitParametersBuilder.java:
##########
@@ -186,21 +173,13 @@ public InitParametersBuilder clusterName(String
clusterName) {
* @param clusterConfiguration Cluster configuration.
* @return {@code this} for chaining.
*/
- public InitParametersBuilder clusterConfiguration(String
clusterConfiguration) {
+ public InitParametersBuilder clusterConfiguration(@Nullable String
clusterConfiguration) {
Review Comment:
But the configuration parameter IS nullable. Not setting the parameter or
explicitly setting it to null is the same thing. I don't think I ever saw
Builders that disallow passing null for an optional parameter that's
initialized with a null. And if something can be null, it should be @Nullable.
##########
modules/runner/src/main/java/org/apache/ignite/InitParametersBuilder.java:
##########
@@ -186,21 +173,13 @@ public InitParametersBuilder clusterName(String
clusterName) {
* @param clusterConfiguration Cluster configuration.
* @return {@code this} for chaining.
*/
- public InitParametersBuilder clusterConfiguration(String
clusterConfiguration) {
+ public InitParametersBuilder clusterConfiguration(@Nullable String
clusterConfiguration) {
Review Comment:
But the configuration parameter IS nullable. Not setting the parameter or
explicitly setting it to null is the same thing. I don't think I ever saw
Builders that disallow passing null for an optional parameter that's
initialized with a null. And if something can be null, it should be `@Nullable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
