rpuch commented on code in PR #5366: URL: https://github.com/apache/ignite-3/pull/5366#discussion_r1985119672
########## modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItColocationTxRecoveryTest.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.partition.replicator; + +import static org.apache.ignite.internal.testframework.matchers.CompletableFutureMatcher.willCompleteSuccessfully; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.junit.jupiter.api.Assertions.assertDoesNotThrow; + +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.partition.replicator.fixtures.Node; +import org.apache.ignite.internal.placementdriver.ReplicaMeta; +import org.apache.ignite.internal.replicator.ZonePartitionId; +import org.apache.ignite.table.KeyValueView; +import org.apache.ignite.tx.Transaction; +import org.junit.jupiter.api.Test; + +class ItColocationTxRecoveryTest extends ItAbstractColocationTest { + private static final long KEY = 1; + + /** + * Tests that tx recovery works. Scenario: + * + * <ol> + * <li>A transaction tx1 is started, it takes a shared lock on a key and never gets finished</li> + * <li>Its coordinator (different from the node hosting the touched partition primary) is stopped, so the transaction becomes + * abandoned</li> + * <li>Transaction tx2 tries to write to the same key, founds an incompatible lock, realizes that it's held by an abandoned + * transaction, and does tx recovery to remove the lock on the partition primary</li> + * <li>tx2 should succeed</li> + * </ol> + */ + @Test + void abandonedTransactionGetsAbortedOnTouch() throws Exception { + assertThat(txConfiguration.abandonedCheckTs().update(600_000L), willCompleteSuccessfully()); + + startCluster(3); + + Node node0 = getNode(0); + + // Create a zone with a single partition on every node. + int zoneId = createZone(node0, TEST_ZONE_NAME, 1, cluster.size()); + + createTable(node0, TEST_ZONE_NAME, TEST_TABLE_NAME1); + + cluster.forEach(Node::waitForMetadataCompletenessAtNow); + + putInitialValue(node0); + + ReplicaMeta primaryReplica = getPrimaryReplica(zoneId); + + Node coordinatorNodeToBeStopped = findAnyOtherNode(primaryReplica); + Transaction txToBeAbandoned = coordinatorNodeToBeStopped.transactions().begin(); + // Trigger a shared lock to be taken on the key. + coordinatorNodeToBeStopped.tableManager.table(TEST_TABLE_NAME1) + .keyValueView(Long.class, Integer.class) + .get(txToBeAbandoned, KEY); + + coordinatorNodeToBeStopped.stop(); + cluster.remove(coordinatorNodeToBeStopped); + + Node runningNode = cluster.get(0); + + KeyValueView<Long, Integer> kvView = runningNode.tableManager.table(TEST_TABLE_NAME1).keyValueView(Long.class, Integer.class); + + Transaction conflictingTx = runningNode.transactions().begin(); + assertDoesNotThrow(() -> kvView.put(conflictingTx, KEY, 111)); + } + + private static void putInitialValue(Node node0) { Review Comment: The method is introduced to reveal intention (I think there was even a pattern like 'Intention revealing message' somewhere in Kent Beck's book https://github.com/anapata/reading/blob/master/chapter14/Draft-Smalltalk%20Best%20Practice%20Patterns%20Kent%20Beck.pdf). The idea is that, when you read the test scenario, you see ``` putInitialValue(node0); ``` and it is obvious to you WHY this is done (initial value is put). But if you see just ``` node.tableManager.table(TEST_TABLE_NAME1).keyValueView(Long.class, Integer.class).put(null, KEY, 42); ``` , you see WHAT is done, but you have no idea WHY this is needed; you have to deduce it yourself from the context. Intention revealing allows to make things obvious and save some time spent on reading and deducing. I renamed the parameter and improved the method structure a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
