rpuch commented on code in PR #5359: URL: https://github.com/apache/ignite-3/pull/5359#discussion_r1984835541
########## modules/transactions/src/test/java/org/apache/ignite/internal/tx/TxManagerTest.java: ########## @@ -116,6 +118,7 @@ */ @ExtendWith(ConfigurationExtension.class) @ExtendWith(ExecutorServiceExtension.class) +@WithSystemProperty(key = IgniteSystemProperties.COLOCATION_FEATURE_FLAG, value = "true") Review Comment: >Why is this needed? Because without this flag the assertion I added in this PR will trigger. >What about testing the non-colocated approach? I duplicated the test to test for both approaches ########## modules/transactions/src/test/java/org/apache/ignite/internal/tx/TxManagerTest.java: ########## @@ -116,6 +118,7 @@ */ @ExtendWith(ConfigurationExtension.class) @ExtendWith(ExecutorServiceExtension.class) +@WithSystemProperty(key = IgniteSystemProperties.COLOCATION_FEATURE_FLAG, value = "true") Review Comment: >Why is this needed? Because without this flag the assertion I added in this PR will be triggered. >What about testing the non-colocated approach? I duplicated the test to test for both approaches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
