PakhomovAlexander commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1984741531
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##########
@@ -1040,20 +1048,24 @@ private Row createKeyRow(int id) {
private InternalTransaction startTxWithEnlistedPartition(int partId,
boolean readOnly) {
IgniteImpl ignite = unwrapIgniteImpl(CLUSTER.aliveNode());
- InternalTransaction tx = (InternalTransaction)
ignite.transactions().begin(new TransactionOptions().readOnly(readOnly));
+ InternalTransaction tx = (InternalTransaction)
ignite.transactions().begin(
+ new
TransactionOptions().timeoutMillis(10_000).readOnly(readOnly)
Review Comment:
`testScanWithUpperBound`:
```java
IgniteTestUtils.assertThrowsWithCode(
TransactionException.class,
Transactions.ACQUIRE_LOCK_ERR,
() -> kvView.put(null, Tuple.create().set("key", 8),
Tuple.create().set("valInt", 8).set("valStr", "New_8")),
"Failed to acquire a lock due to a possible deadlock");
```
this assertion fails with "no exception" cause if we use default tx timeout
(5 secs in this test).
This happens because implicit transaction succeeds because Read-Write is
rolled back. So, I add more time to Read-Write transaction (10 secs here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
