alled for OpenGL ES 3.x right now. But if this was to change in
the future, this makes the function behave a lot more predictable.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa
All other _mesa_has_foo functions return bool rather than GLboolean, so
let's follow that style here as well.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
lso need to use _mesa_has_EXT_texture_compression_s3tc() instead of
checking the driver cap directly, otherwise we end up enabling this on
OpenGL ES 1.x, as the API isn't checked.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
d
cing-prefix from
the name.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 12 ++--
src/mesa/main/glformats.h | 6 +++---
src/mesa/main/teximage.c | 4 ++--
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/ma
test
was fixed, namely oes_packed_depth_stencil-depth-stencil-texture_gles1.
I don't think this is worth back-porting to old releases, as this only
prevents broken code from incorrectly working, not the other way around.
Erik Faye-Lund (30):
mesa/main: make _mesa_has_tessellation return bool
mesa/main:
S3_s3tc is the extension that enables this functionality on desktop, so
let's check for that one. The _mesa_has_S3_s3tc() helper already
verifies the API according to the extension-table.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 8 +++-
1 file changed, 3 inser
EXT_packed_float isn't supported on OpenGL ES, we shouldn't allow
these enums there, before OpenGL ES 3.0 which also introduce support
for these enums.
Since this check is repeated a lot, let's make a helper for this.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h |
epth textures on OpenGL and OpenGL ES 2.0+. There's no
extension enabling depth-textures for OpenGL ES 1.x, so we shouldn't
allow those enums there.
This fixes oes_packed_depth_stencil-depth-stencil-texture_gles1 on i965
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 3
support depth textures on OpenGL and
OpenGL ES 2.0+. There's no extension enabling stencil-textures for
OpenGL ES 1.x, so we shouldn't allow those enums there.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
dif
Integer textures shouldn't be implicitly exposed on OpenGL ES 1.x and
2.x, but because the code checked against a driver-capability rather
than using an extension-check helper, we ended up accidentally allowing
these enums on older versions when the driver supports it.
Signed-off-by: Erik
This should be equalent of what we did before.
Signed-off-by: Erik Faye-Lund
---
src/mesa/state_tracker/st_extensions.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/state_tracker/st_extensions.c
b/src/mesa/state_tracker/st_extensions.c
index 16889074f66
This extension requies OpenGL, and shouldn't be available on OpenGL ES.
So let's not allow the enums from it either.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/glformats.c b/src
irst place.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 14 ++
src/mesa/main/glformats.c | 39 +--
2 files changed, 43 insertions(+), 10 deletions(-)
diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
index 071bd5b0818..b
#x27;s tighten the check.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 6c9d8b88d79..d79bcedffd9 100644
--- a/src/mesa/main/glformats.c
+++ b/src/mes
tighten the check.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 0a42d3dd9a0..6c9d8b88d79 100644
--- a/src/mesa/main/glformats.c
+++ b/src/mesa/main/glfo
#x27;s tighten the check.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 453465fb1c8..0a42d3dd9a0 100644
--- a/src/mesa/main/glformats.c
+++ b/src/mesa/main/glfo
There's nothing in the ARB_texture_float specification that limits
filterability for floating-point textures, so we need to ensure that
this is required to enable this extension. Luckily, we have just the
right bits ready.
Signed-off-by: Erik Faye-Lund
---
src/mesa/state_tracker/st_extensi
OpenGL ES 3.0 require this functionality, so we should also test for it
to avoid incorrectly exposing a too high GLES version.
On desktop, this has been required since all the way back in OpenGL 1.2
anyway.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/version.c | 3 ++-
1 file changed, 2
The OpenGL ES 3.0 specification, table 3.13 lists half-float textures as
filterable, but not float textures. So we shouldn't depend on
ARB_float_texture, which requires full filtering support for both.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/version.c | 4 +++-
1 file chang
repeated, let's introduce a helper.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 6 ++
src/mesa/main/glformats.c | 4 ++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
index af81717d9bd..7db3b94e0b6 100644
-
sRGB textures is a requirement for OpenGL ES 3.0, so let's make sure
we don't incorrectly enable a too high version.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/version.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c
index b
ums there.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 7 +++
src/mesa/main/glformats.c | 6 +++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
index 7db3b94e0b6..071bd5b0818 100644
--- a/src/mesa/main/c
#x27;t allow those enums there.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 2ac3110187f..453465fb1c8 100644
--- a/src/mesa/main/glf
re.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 964235bb72f..2e2ef9a05bb 100644
--- a/src/mesa/main/glformats.c
+++ b/src/mesa/main/glformats.c
EXT_packed_float isn't supported on OpenGL ES, we shouldn't allow
these enums there, before OpenGL ES 3.0 which also introduce support
for these enums.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 6 ++
src/mesa/main/glformats.c | 6 +++---
2 files changed, 9
h the lack
of FP32-interpolation...
> On Mon, Nov 19, 2018 at 7:16 AM Erik Faye-Lund
> wrote:
> > There's nothing in the ARB_texture_float specification that limits
> > filterability for floating-point textures, so we need to ensure
> > that
> > this is requi
On Mon, 2018-11-19 at 11:13 -0500, Ilia Mirkin wrote:
> On Mon, Nov 19, 2018 at 10:40 AM Erik Faye-Lund
> wrote:
> > On Mon, 2018-11-19 at 10:02 -0500, Ilia Mirkin wrote:
> > > Unfortunately this will drop GL 3.0 from Adreno A3xx. I think
> > > we'd
> > &g
On Mon, 2018-11-19 at 11:37 -0500, Ilia Mirkin wrote:
> On Mon, Nov 19, 2018 at 11:30 AM Erik Faye-Lund
> wrote:
> > On Mon, 2018-11-19 at 11:13 -0500, Ilia Mirkin wrote:
> > > On Mon, Nov 19, 2018 at 10:40 AM Erik Faye-Lund
> > > wrote:
> > > > On M
On Mon, 2018-11-19 at 18:43 +0100, Francesco Ansanelli wrote:
> Hi Eric,
>
> While checking this patch I noticed an extra semicolon in this
> function:
> +static inline bool
> +_mesa_has_half_float_textures(const struct gl_context *ctx)
> +{
> + return _mesa_has_ARB_texture_float(ctx) ||
> +
cting this would be the right thing to do in theory,
but I have no practical use-case for it, so I'm happy to drop the patch
for now.
>
> From: mesa-dev on behalf of
> Ilia Mirkin
> Sent: Monday, November 19, 2018 5:37:58 PM
> To: Erik
now. I'd still like
to know what you're referring to, though.
> On Mon, Nov 19, 2018 at 7:15 AM Erik Faye-Lund <
> erik.faye-l...@collabora.com> wrote:
> > There's nothing in the ARB_texture_float specification that limits
> > filterability for floating-po
On Tue, 2018-11-20 at 10:08 +0100, Erik Faye-Lund wrote:
> On Tue, 2018-11-20 at 01:21 -0500, Marek Olšák wrote:
> > I'd like to keep ARB_texture_float enabled on drivers that don't
> > support linear interpolation. ARB_texture_float is required by DX9,
> &g
;s this Change-Id thing? I don't think we usually include things
like this...
With that dropped:
Reviewed-by: Erik Faye-Lund
> ---
> src/gallium/drivers/virgl/virgl_winsys.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/virgl/v
On Wed, 2018-11-21 at 20:08 -0800, Gurchetan Singh wrote:
> We can mark the buffer unclean if it's ever bound as a TBO,
> SSBO, ABO, or image.
>
> This improves
>
> dEQP-
> GLES3.performance.buffer.data_upload.function_call.map_buffer_range.n
> ew_specified_buffer.flag_write_full.stream_draw
>
>
. All arguments that are no longer validated
are generated internally by mesa, so there's no use in validating them.
Fixes: 42891dbaa12 "gettextsubimage: verify zoffset and depth are correct"
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/texgetimage.c | 57 +++
or. But it will make a difference for the next
patch, where we no longer call this method from the non-sub tex-image
getters.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/texgetimage.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git
This error checking is the same for teximage and texsubimage getters, so
let's factor it out to its own function.
This will be useful when getteximage and gettexsubimage gets their own
error checking routines a bit later.
---
src/mesa/main/texgetimage.c | 46 +++--
up
checking explicitly for these conditions later, this should simply be a
no-op as per the spec. And we already have some support-code for this.
No regressions found in piglit.
Erik Faye-Lund (6):
mesa/main: remove ARB suffix from glGetnTexImage
mesa/main: remove bogus error for zero-siz
This will be useful when we split error-checking for getteximage and
gettexsubimage later.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/texgetimage.c | 110 +---
1 file changed, 64 insertions(+), 46 deletions(-)
diff --git a/src/mesa/main/texgetimage.c b/src
t's not generate an error, there's non mandated in the spec in
xoffset/yoffset/zoffset = 0 case. We already avoid doing any work in
this case, because of the final, non-error generating check in this
function.
Fixes: b37b35a5d26 "getteximage: assume texture image is empty for non define
This function has been core since OpenGL 4.3, so naming the
implementation and reporting erros using an ARB-suffix can be
confusing.
Signed-off-by: Erik Faye-Lund
---
src/mapi/glapi/gen/ARB_robustness.xml | 2 +-
src/mapi/glapi/gen/gl_API.xml | 9 +
src/mesa/main/texgetimage.c
>
> > Reviewed-by: Tapani Pälli
> >
> > On 11/8/18 2:42 PM, Erik Faye-Lund wrote:
> > > Here's v2 of this series. Changes are as follows:
> > >
> > > - 5/13: also check for ARB_occlusion_query2, for core-contexts
> > > - 8/13: also check
On Thu, 2018-11-22 at 13:26 +0100, Mathias Fröhlich wrote:
> Hi Erik,
>
> The series looks very reasonable and I could not spot loosing any
> negating ! in the
> query logic. Even if I have not been able time wise to double checked
> every move when
> which texture format got introduced in which E
_mesa_has_FOO_bar() knows about the APIs these extensions should be
supported under, so let's use that to simplify these checks a bit.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src
OK, so here's a v2 of this series. These are the changes since v1:
- Removed double-semicolons in patch #25
- Removed default-case and questionable comment in patch #25
- Dropped patch #30, as it would regress functionality on two drivers
Please review :)
Erik Faye-Lund (29):
mesa/main:
cing-prefix from
the name.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 12 ++--
src/mesa/main/glformats.h | 6 +++---
src/mesa/main/teximage.c | 4 ++--
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/ma
This makes the logic a little bit easier to follow; this is *either*
about ES2 compatibility *or* about gles. GL_RGB565 was added already in
OpenGL ES 1.0.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa
All other _mesa_has_foo functions return bool rather than GLboolean, so
let's follow that style here as well.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
S3_s3tc is the extension that enables this functionality on desktop, so
let's check for that one. The _mesa_has_S3_s3tc() helper already
verifies the API according to the extension-table.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 8 +++-
1 file changed, 3 inser
support depth textures on OpenGL and
OpenGL ES 2.0+. There's no extension enabling stencil-textures for
OpenGL ES 1.x, so we shouldn't allow those enums there.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
dif
lso need to use _mesa_has_EXT_texture_compression_s3tc() instead of
checking the driver cap directly, otherwise we end up enabling this on
OpenGL ES 1.x, as the API isn't checked.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
d
alled for OpenGL ES 3.x right now. But if this was to change in
the future, this makes the function behave a lot more predictable.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa
re.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 964235bb72f..2e2ef9a05bb 100644
--- a/src/mesa/main/glformats.c
+++ b/src/mesa/main/glformats.c
EXT_packed_float isn't supported on OpenGL ES, we shouldn't allow
these enums there, before OpenGL ES 3.0 which also introduce support
for these enums.
Since this check is repeated a lot, let's make a helper for this.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h |
#x27;s tighten the check.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 453465fb1c8..0a42d3dd9a0 100644
--- a/src/mesa/main/glformats.c
+++ b/src/mesa/main/glfo
This makes the logic a little bit easier to follow, and reduce a bit of
repetition.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 6 ++
src/mesa/main/glformats.c | 27 +++
2 files changed, 17 insertions(+), 16 deletions(-)
diff --git a/src/mesa/main
epth textures on OpenGL and OpenGL ES 2.0+. There's no
extension enabling depth-textures for OpenGL ES 1.x, so we shouldn't
allow those enums there.
This fixes oes_packed_depth_stencil-depth-stencil-texture_gles1 on i965
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 3
#x27;s tighten the check.
Signed-off-by: Erik Faye-Lund
Reviewed-By: Gert Wollny
---
src/mesa/main/glformats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 6c9d8b88d79..d79bcedffd9 100644
--- a/src/mesa/main/glf
This should be equalent of what we did before.
Signed-off-by: Erik Faye-Lund
---
src/mesa/state_tracker/st_extensions.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/state_tracker/st_extensions.c
b/src/mesa/state_tracker/st_extensions.c
index 16889074f66
The OpenGL ES 3.0 specification, table 3.13 lists half-float textures as
filterable, but not float textures. So we shouldn't depend on
ARB_float_texture, which requires full filtering support for both.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/version.c | 4 +++-
1 file chang
repeated, let's introduce a helper.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 6 ++
src/mesa/main/glformats.c | 4 ++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
index af81717d9bd..7db3b94e0b6 100644
-
ums there.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 7 +++
src/mesa/main/glformats.c | 6 +++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
index 7db3b94e0b6..071bd5b0818 100644
--- a/src/mesa/main/c
#x27;t allow those enums there.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 2ac3110187f..453465fb1c8 100644
--- a/src/mesa/main/glf
Integer textures shouldn't be implicitly exposed on OpenGL ES 1.x and
2.x, but because the code checked against a driver-capability rather
than using an extension-check helper, we ended up accidentally allowing
these enums on older versions when the driver supports it.
Signed-off-by: Erik
ums there.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 2e2ef9a05bb..b715af1a468 100644
--- a/src/mesa/main/glformats.c
+++ b/src/mesa/main/glfo
sRGB textures is a requirement for OpenGL ES 3.0, so let's make sure
we don't incorrectly enable a too high version.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/version.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c
index b
tighten the check.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 0a42d3dd9a0..6c9d8b88d79 100644
--- a/src/mesa/main/glformats.c
+++ b/src/mesa/main/glfo
This extension requies OpenGL, and shouldn't be available on OpenGL ES.
So let's not allow the enums from it either.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/glformats.c b/src
OpenGL ES 3.0 require this functionality, so we should also test for it
to avoid incorrectly exposing a too high GLES version.
On desktop, this has been required since all the way back in OpenGL 1.2
anyway.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/version.c | 3 ++-
1 file changed, 2
, let's make a helper for it.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 6 ++
src/mesa/main/glformats.c | 6 +++---
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
index c51b3c17c0d..14f9a6b8987 100644
irst place.
While we're at it, remove the pointless default-case, and the seemingly
stale fallthrough comment.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 14 ++
src/mesa/main/glformats.c | 39 +++
2 files changed, 41 insertions(+
EXT_packed_float isn't supported on OpenGL ES, we shouldn't allow
these enums there, before OpenGL ES 3.0 which also introduce support
for these enums.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 6 ++
src/mesa/main/glformats.c | 6 +++---
2 files changed, 9
ARB_texture_rgb10_a2ui isn't supported on OpenGL ES, we shouldn't expose
it there even if the driver supports it.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 6 ++
src/mesa/main/glformats.c | 12 ++--
2 files changed, 12 insertions(+), 6 deletions(-)
di
On Fri, 2018-11-23 at 15:50 +0100, Juan A. Suarez Romero wrote:
> On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote:
> > I was recently investigating a gl-error that appears some times
> > while
> > using virgl, where I got a pretty nonsensical GL-error:
>
On Mon, 2018-11-26 at 13:06 +0100, Juan A. Suarez Romero wrote:
> On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote:
> > If glGetTexImage or glGetnTexImage is called with a level that
> > doesn't
> > exist, we get an error message on this form:
> >
> >
On Mon, 2018-11-26 at 13:16 +0100, Juan A. Suarez Romero wrote:
> On Mon, 2018-11-26 at 13:13 +0100, Erik Faye-Lund wrote:
> > On Mon, 2018-11-26 at 13:06 +0100, Juan A. Suarez Romero wrote:
> > > On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote:
> > > > If g
On Mon, 2018-05-07 at 08:14 +0200, mathias.froehl...@gmx.net wrote:
> From: Mathias Fröhlich
>
> Finally make use of the binding information in the VAO when
> setting up arrays for draw.
>
> v2: Emit less relocations also for interleaved userspace arrays.
>
> Signed-off-by: Mathias Fröhlich
I
/main: fix validation of transform-feedback queries"
Signed-off-by: Erik Faye-Lund
---
Sorry about this! As I mentioned on the ticket, I don't have old enough
intel HW to trigger this, but I think this should do the trick.
src/mesa/main/queryobj.c | 1 +
1 file changed, 1 insertion(+)
d
llny
>
For the series:
Reviewed-by: Erik Faye-Lund
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
.
On Mon, 2018-11-26 at 15:42 -0500, Marek Olšák wrote:
> I have this issue on radeonsi as well, but the bad commit is:
>
> commit f1998e15ffccf260552bf559abe1a733a8ce990e
> Author: Erik Faye-Lund
> Date: Wed Nov 21 20:09:46 2018 +0100
>
> mesa/main: remove ARB
On Mon, 2018-11-26 at 21:33 +0100, Mathias Fröhlich wrote:
> Hi,
>
> On Monday, 26 November 2018 19:39:50 CET Erik Faye-Lund wrote:
> > I know this is *very* late notice, but this commit broke Super Tux
> > Kart
> > on VirGL. Both the player-models as as well as
Thanks. Pushed :)
On Mon, 2018-11-26 at 12:58 -0800, Mark Janes wrote:
> Tested-by: Mark Janes
>
> Erik Faye-Lund writes:
>
> > This enum is also allowed by EXT_tessellation_shader, which is
> > supported
> > on older i965 HW (as opposed to OES_geometry_shader)
(sorry, forgot to answer one of the questions)
On Mon, 2018-11-26 at 21:33 +0100, Mathias Fröhlich wrote:
> Hi,
>
> On Monday, 26 November 2018 19:39:50 CET Erik Faye-Lund wrote:
> > I know this is *very* late notice, but this commit broke Super Tux
> > Kart
> > on Vi
On Tue, 2018-11-27 at 07:11 +0100, Mathias Fröhlich wrote:
> Hi Erik,
>
> > > On Monday, 26 November 2018 19:39:50 CET Erik Faye-Lund wrote:
> > > > I know this is *very* late notice, but this commit broke Super
> > > > Tux
> > > > Kart
> &g
On Tue, 2018-11-27 at 11:13 +0200, Timo Aaltonen wrote:
> On 17.11.2018 6.04, Dylan Baker wrote:
> > Quoting Dylan Baker (2018-09-17 09:44:07)
> > > I feel like for !windows meson is in good enough shape at this
> > > point that we
> > > can start having the discussion about deleting the autotools
On Tue, 2018-11-27 at 23:20 -0800, Jordan Justen wrote:
> This adds the "Developer's Certificate of Origin 1.1" from the Linux
> kernel. It indicates that by using Signed-off-by you are certifying
> that your patch meets the DCO 1.1 guidelines.
>
> It also changes Signed-off-by from being optional
On Wed, 2018-11-28 at 01:18 -0800, Jordan Justen wrote:
> On 2018-11-28 00:47:25, Erik Faye-Lund wrote:
> > On Tue, 2018-11-27 at 23:20 -0800, Jordan Justen wrote:
> > > This adds the "Developer's Certificate of Origin 1.1" from the
> > > Linux
> >
On Wed, 2018-11-28 at 15:20 +, Emil Velikov wrote:
> On Wed, 28 Nov 2018 at 14:29, Eric Engestrom <
> eric.engest...@intel.com> wrote:
> > On Wednesday, 2018-11-28 01:18:16 -0800, Jordan Justen wrote:
> > > On 2018-11-28 00:47:25, Erik Faye-Lund wrote:
> > >
On Tue, 2018-11-27 at 17:13 -0800, Jordan Justen wrote:
> This documents a mechanism for using GitLab Merge Requests as an
> optional, secondary way to get code reviews for patchsets.
>
> We still require all patches to be emailed.
>
> Aside from the potential usage for code review comments, it m
On Wed, 2018-11-28 at 13:43 -0800, Eric Anholt wrote:
> Jordan Justen writes:
>
> > This adds the "Developer's Certificate of Origin 1.1" from the
> > Linux
> > kernel. It indicates that by using Signed-off-by you are certifying
> > that your patch meets the DCO 1.1 guidelines.
> >
> > It also c
On Wed, 2018-11-28 at 20:22 -0500, Marek Olšák wrote:
> From: Marek Olšák
>
> The spec was modified to support GLES. Tested by piglit.
> ---
> docs/relnotes/19.0.0.html| 1 +
> src/mesa/main/extensions_table.h | 2 +-
> src/mesa/main/glformats.c| 19 +--
> src/m
On Wed, 2018-11-28 at 20:22 -0500, Marek Olšák wrote:
> From: Marek Olšák
>
> tested by piglit.
> ---
> docs/relnotes/19.0.0.html| 1 +
> src/mesa/main/extensions_table.h | 1 +
> src/mesa/main/glformats.c| 13 +++--
> src/mesa/main/texcompress.c | 9 +
>
On Thu, 2018-11-29 at 18:09 -0800, Gurchetan Singh wrote:
> Thanks! Gentle ping for push from committers..
Pushed, thanks :)
> On Mon, Nov 26, 2018 at 11:52 AM Erik Faye-Lund
> wrote:
> > On Mon, 2018-11-26 at 09:54 -0800, Gurchetan Singh wrote:
> > > Tested running
On Fri, 2018-11-23 at 11:53 +0100, Erik Faye-Lund wrote:
> OK, so here's a v2 of this series. These are the changes since v1:
> - Removed double-semicolons in patch #25
> - Removed default-case and questionable comment in patch #25
> - Dropped patch #30, as it would regress fun
On Fri, 2018-11-30 at 18:15 -0500, Marek Olšák wrote:
> On Fri, Nov 30, 2018 at 5:57 PM Ian Romanick
> wrote:
> > On 11/30/2018 02:17 PM, Marek Olšák wrote:
> > >
> > >
> > > On Fri, Nov 23, 2018 at 5:54 AM Erik Faye-Lund
> > > > erik.faye-l
On Fri, 2018-11-30 at 07:06 +0100, Mathias Fröhlich wrote:
> Good Morning,
>
> On Tuesday, 27 November 2018 10:17:07 CET Erik Faye-Lund wrote:
> > On Tue, 2018-11-27 at 07:11 +0100, Mathias Fröhlich wrote:
> > > Hi Erik,
> > >
> > > > > On Mond
On Mon, 2018-12-03 at 12:15 -0500, Marek Olšák wrote:
> Looks good. Feel free to push this.
Thanks, pushed :)
>
> Marek
>
> On Mon, Dec 3, 2018 at 5:05 AM Erik Faye-Lund <
> erik.faye-l...@collabora.com> wrote:
> > On Fri, 2018-11-30 at 18:15 -0500, Marek Olš
On Mon, 2018-12-03 at 17:24 +, Emil Velikov wrote:
> Hi Erik,
>
> On Fri, 23 Nov 2018 at 10:54, Erik Faye-Lund
> wrote:
> > This makes the logic a little bit easier to follow; this is
> > *either*
> > about ES2 compatibility *or* about gles. GL_RGB565 was adde
enting, by correcting the check as per the spec.
Signed-off-by: Erik Faye-Lund
Reviewed-by: Emil Velikov
---
src/mesa/main/glformats.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 7506c238232..ea73068d025 100644
On Tue, 2018-12-04 at 07:54 +0100, Mathias Fröhlich wrote:
> Hey,
>
> On Monday, 3 December 2018 12:15:17 CET Erik Faye-Lund wrote:
> > Yeah. An important thing to note is that virgl is pretty widely
> > tested
> > by now, and we don't see this pop up in other pla
401 - 500 of 768 matches
Mail list logo
