On Mon, 2018-11-19 at 18:43 +0100, Francesco Ansanelli wrote:
> Hi Eric,
>
> While checking this patch I noticed an extra semicolon in this
> function:
> +static inline bool
> +_mesa_has_half_float_textures(const struct gl_context *ctx)
> +{
> + return _mesa_has_ARB_texture_float(ctx) ||
> + _mesa_has_OES_texture_half_float(ctx) ||
> _mesa_is_gles3(ctx);;
> +}
Whoops, good catch. Thanks for noticing :)
> I'm also wondering about the new default below:
> + default:
> + ; /* fallthrough */
> It's not exactly a fall through case IMHO, but I understand what you
> mean with it... I'd evaluate to put the second switch under the
> default instead, but probably it's just a matter of taste and can
> lead to an unwanted bigger patch.
Yeah, this is a bit confusing, I agree. The comment and the default-
block seems to be needless, but they were already there and I copied it
for the second version. I don't think it's *wrong*, but I don't think
it solves anything either. The default-handling and comment should just
go away, I think.
> Sorry the bothering..
> Cheers,
> Francesco
No bother at all, thanks for the input :)
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
