Re: [Mesa-dev] [PATCH] glsl: optimize list handling in opt_dead_code

I would like to mention that the response Ian posted was/is a nice read. I am not sure what to write in response. Let me just note that adding formalisms to Mesa would lead to both higher performance and higher safety. If you do not want C++ in Mesa, maybe it would be acceptable for Mesa developer

Re: [Mesa-dev] [PATCH] drivers/meta: Accept GL_TEXTURE_3D as target for tex image decompression

On Tuesday, October 18, 2016 9:55:38 AM PDT Eduardo Lima Mitev wrote: > An assert is currently raised, preventing decompression of a texture image > into > a GL_TEXTURE_3D target. I have not found any spec wording that would explain > this, or implementation detail that would prevent it. And in an

Re: [Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

On 10/28/2016 05:15 AM, Timothy Arceri wrote: On Thu, 2016-10-27 at 18:51 -0700, Kenneth Graunke wrote: On Thursday, October 27, 2016 9:03:12 PM PDT Timothy Arceri wrote: On Thu, 2016-10-27 at 12:37 +1100, Timothy Arceri wrote: Agreed but as far as I can tell we shouldn't even need gl_linked_s

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/27/2016 09:16 PM, Marek Olšák wrote: On Fri, Oct 21, 2016 at 5:29 PM, Tapani Pälli wrote: On 10/21/2016 04:57 PM, Eero Tamminen wrote: Hi, On 21.10.2016 14:07, Tapani Pälli wrote: I did run some valgrind comparisons with gfxbench4, your branch against Mesa master. I did not spot anythi

[Mesa-dev] [RFC 2/3] egl, dri: Propagate context priority hint to driver->CreateContext

Jump through the layers of abstraction between egl and dri in order to feed the context priority attribute through to the backend. This requires us to read the value from the base _egl_context, convert it to a DRI attribute, parse it again in the generic context creater before passing it to the dri

[Mesa-dev] [RFC 1/3] egl: Support IMG_context_priority

IMG_context_priority https://www.khronos.org/registry/egl/extensions/IMG/EGL_IMG_context_priority.txt "This extension allows an EGLContext to be created with a priority hint. It is possible that an implementation will not honour the hint, especially if there are constraints on the numb

[Mesa-dev] [RFC 3/3] i965: Implement context priorities

Pass along the context priority provided through eglCreateContext to the kernel, where it will be used for priority sorting of batches. Signed-off-by: Chris Wilson --- src/mesa/drivers/dri/i965/brw_batch.c | 43 - src/mesa/drivers/dri/i965/brw_batch.h | 3 ++-

Re: [Mesa-dev] [PATCH 4/5] i965: use memory context when creating passthrough tcs

Thanks for cleaning this up Reviewed-by: Jason Ekstrand The others in the series look fine too. I'd like to see pt 2 before I give a full R-B though. On Thu, Oct 27, 2016 at 11:27 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > --- > src/mesa/drivers/dri/i965/brw_tcs.c | 13 +

Re: [Mesa-dev] [PATCH] glsl: Improve accuracy of alpha scaling in advanced blend lowering.

Patch makes sense and it does fix the two tests. Assuming no regressions, it is: Reviewed-by: Eduardo Lima Mitev On 10/28/2016 06:37 AM, Kenneth Graunke wrote: > When blending with GL_COLORBURN_KHR and these colors: > >dst = <0.372549027, 0.372549027, 0.372549027, 0.372549027> >src = <0

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

On 28/10/16 03:58 PM, Nayan Deshmukh wrote: > On Fri, Oct 28, 2016 at 7:00 AM, Michel Dänzer > wrote: > > On 28/10/16 03:08 AM, Marek Olšák wrote: > > On Thu, Oct 27, 2016 at 5:23 PM, Emil Velikov > wrote: > >> On 17 October

Re: [Mesa-dev] [RFC 1/3] egl: Support IMG_context_priority

First patch is Reviewed-by: Tapani Pälli I also tested setting different priority levels, querying them and setting invalid priority level where context creation fails. API works as expected. On 10/28/2016 11:10 AM, Chris Wilson wrote: IMG_context_priority https://www.khronos.org/registry/e

Re: [Mesa-dev] [PATCH 2/5] nir: fix nir_shader_clone()

On 10/28/2016 08:27 AM, Timothy Arceri wrote: > This was broken in e1af20f18a8 when the info field in nir_shader was > turned into a pointer. > --- Patch is: Reviewed-by: Eduardo Lima Mitev thanks! > src/compiler/nir/nir_clone.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

On Fri, Oct 28, 2016 at 2:14 PM, Michel Dänzer wrote: > On 28/10/16 03:58 PM, Nayan Deshmukh wrote: > > On Fri, Oct 28, 2016 at 7:00 AM, Michel Dänzer > > wrote: > > > > On 28/10/16 03:08 AM, Marek Olšák wrote: > > > On Thu, Oct 27, 2016 at 5:23 PM, Emil Veliko

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

On 28/10/16 06:04 PM, Nayan Deshmukh wrote: > On Fri, Oct 28, 2016 at 2:14 PM, Michel Dänzer > wrote: > > On 28/10/16 03:58 PM, Nayan Deshmukh wrote: > > On Fri, Oct 28, 2016 at 7:00 AM, Michel Dänzer > >

[Mesa-dev] [PATCH 08/18] anv/blorp: Ignore clears for attachments first used as resolve destinations

Otherwise, we'll try to clear it the first time it's used as a draw so if you do some multisampled rendering, resolve to an attachment, and then draw on top of the single-sampled attachment, we might accidentally clear it. Signed-off-by: Jason Ekstrand Cc: "13.0" --- src/intel/vulkan/anv_blorp.

[Mesa-dev] [PATCH 18/18] anv/TODO: Check off render buffer compression

There's still a tiny bit of work to do for storage images but it's otherwise pretty much done at this point. Signed-off-by: Jason Ekstrand --- src/intel/vulkan/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO index 4c3faad..a39bf43 100644 ---

[Mesa-dev] [PATCH 17/18] anv: Enable "permanent" compression for immutable format images

This commit extends our support of color compression to surfaces without the VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT set. These images will never have an image view created with a different format then the one set at image creation time so it's safe to always use compression. We still bail if the imag

[Mesa-dev] [PATCH 00/18] anv: Enable color compression on Sky Lake

This little patch series (which applies on top of my previous series to rework attachment surface states) enables color compression on Sky Lake. I must say, I'm extremely pleased with how smoothly it all went. I only really ran into three big issues: 1) An ISL bug that caused GPU hangs due to

[Mesa-dev] [PATCH 02/18] anv/cmd_buffer: Pull add_surface_state_reloc into genX_cmd_buffer.c

Signed-off-by: Jason Ekstrand --- src/intel/vulkan/anv_private.h | 11 --- src/intel/vulkan/genX_cmd_buffer.c | 19 ++- 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 44fe606..b135d

[Mesa-dev] [PATCH 05/18] intel/isl: Allow non-2D CCS surfaces

The CCS calculations in ISL are already correct for 1-D and 3-D CCS surfaces since they have exactly the same layout as 2-D array surfaces (at least on Sky Lake). The only problem was that we weren't passing in the right dimensionality and we weren't passing in the depth. Signed-off-by: Jason Eks

[Mesa-dev] [PATCH 03/18] anv/cmd_buffer: Refactor surface state relocation handling

Signed-off-by: Jason Ekstrand --- src/intel/vulkan/genX_cmd_buffer.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 35e582a..a5e4d0e 100644 --- a/src/intel/vul

[Mesa-dev] [PATCH 06/18] intel/blorp: Add plumbing for color resolve slice details

From: "Pohjolainen, Topi" Signed-off-by: Topi Pohjolainen Reviewed-by: Jason Ekstrand --- src/intel/blorp/blorp.h | 3 ++- src/intel/blorp/blorp_clear.c | 9 +++-- src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- 3 files changed, 10 insertions(+), 4 deletions(-) diff --

[Mesa-dev] [PATCH 04/18] intel/isl: Rework the asserts and fails in isl_surf_get_ccs

There are some invariants such as number of samples on which we should assert. However, most other things should silently return false since they're much easier for isl_surf_get_ccs to check than the caller. We also update the checking to be a bit more complete. Signed-off-by: Jason Ekstrand --

[Mesa-dev] [PATCH 16/18] intel/blorp: Properly handle color compression in blorp_copy

Previously, blorp copy operations were CCS-unaware so you had to perform resolves on the source and destination before performing the copy. This commit makes blorp_copy capable of handling CCS-compressed images without any resolves. Signed-off-by: Jason Ekstrand --- src/intel/blorp/blorp_blit.c

[Mesa-dev] [PATCH 15/18] intel/blorp: Always use UINT formats on SKL+

Many of these UINT formats aren't available prior to Sky Lake so we used UNORM formats. Using UINT formats is a bit nicer because it guarantees we don't run into rounding issues. Also, we will need it in the next commit for handling copies with CCS enabled. Signed-off-by: Jason Ekstrand --- sr

[Mesa-dev] [PATCH 09/18] anv/image: Rename hiz_surface to aux_surface

Signed-off-by: Jason Ekstrand --- src/intel/vulkan/anv_image.c | 16 src/intel/vulkan/anv_private.h | 5 +++-- src/intel/vulkan/genX_cmd_buffer.c | 10 +- 3 files changed, 16 insertions(+), 15 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/

[Mesa-dev] [PATCH 07/18] intel/blorp: Take a fast_clear_op in ccs_resolve

Eventually, we may want to just have a single blorp_ccs_op function that does both clears and resolves. For now we'll stick to just making the ccs_resolve function we have now a bit more configurable. Signed-off-by: Jason Ekstrand --- src/intel/blorp/blorp.h | 10 +- src/i

[Mesa-dev] [PATCH 12/18] anv/pass: Precompute some subpass usage information

Signed-off-by: Jason Ekstrand --- src/intel/vulkan/anv_pass.c| 39 --- src/intel/vulkan/anv_private.h | 11 +++ 2 files changed, 43 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 6eaa5c8..

[Mesa-dev] [PATCH 10/18] anv/image: Memset all aux surfaces (not just HiZ) to 0

Signed-off-by: Jason Ekstrand --- src/intel/vulkan/anv_image.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 2104901..bdf8bca 100644 --- a/src/intel/vulkan/anv_image.c +++ b/src/intel/vulkan/anv_ima

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

On Fri, Oct 28, 2016 at 2:43 PM, Michel Dänzer wrote: > On 28/10/16 06:04 PM, Nayan Deshmukh wrote: > > On Fri, Oct 28, 2016 at 2:14 PM, Michel Dänzer > > wrote: > > > > On 28/10/16 03:58 PM, Nayan Deshmukh wrote: > > > On Fri, Oct 28, 2016 at 7:00 AM, Michel D

[Mesa-dev] [PATCH 13/18] anv: Add initial for Sky Lake color compression

This commit adds basic support for color compression. For the moment, color compression is only enabled within a render pass and a full resolve is done before the render pass finishes. All texturing operations still happen with CCS disabled. Signed-off-by: Jason Ekstrand --- src/intel/vulkan/a

[Mesa-dev] [PATCH 14/18] anv/image: Add an aux_usage field for "default" aux

Initially, the field is set to ISL_AUX_USAGE_NONE so this commit shouldn't bring any functional changes. Setting this field to something else will cause all sampled and storage image views to be created with AUX and blorp will start trying to respect it so set with care. Signed-off-by: Jason Ekst

[Mesa-dev] [PATCH 01/18] anv/image: Stop force-disabling AUX

Auxiliary surfaces have to be created manually anyway so force-disabling it does nothing whatsoever at the moment. Signed-off-by: Jason Ekstrand --- src/intel/vulkan/anv_image.c | 4 1 file changed, 4 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c ind

[Mesa-dev] [PATCH 11/18] util/vk_alloc: Add a vk_zalloc2 helper

Signed-off-by: Jason Ekstrand --- src/util/vk_alloc.h | 16 1 file changed, 16 insertions(+) diff --git a/src/util/vk_alloc.h b/src/util/vk_alloc.h index a8e21ca..fdf0039 100644 --- a/src/util/vk_alloc.h +++ b/src/util/vk_alloc.h @@ -25,6 +25,7 @@ /* common allocation inlines

[Mesa-dev] [PATCH] android: avoid using libdrm with host modules

Note LOCAL_CFLAGS and LOCAL_SHARED_LIBRARIES in Android.common.mk are used by both host and target modules. However, commit 112e988 moved libdrm related flags to common. It causes the errors like: error: 'out/host/linux-x86/obj32/SHARED_LIBRARIES/libdrm_intermediates/export_includes', needed by

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

On Oct 28, 2016 3:30 AM, "Michel Dänzer" wrote: > > On 28/10/16 03:08 AM, Marek Olšák wrote: > > On Thu, Oct 27, 2016 at 5:23 PM, Emil Velikov wrote: > >> On 17 October 2016 at 10:37, Marek Olšák wrote: > >>> Reverting the whole commit is too much. You can just remove the PIPE BIND > >>> SHARED

[Mesa-dev] [Bug 92877] Add support for libglvnd

https://bugs.freedesktop.org/show_bug.cgi?id=92877 Bastien Nocera changed: What|Removed |Added CC||bugzi...@hadess.net --- Comment #6 from

[Mesa-dev] [Bug 92877] Add support for libglvnd

https://bugs.freedesktop.org/show_bug.cgi?id=92877 --- Comment #7 from Mike Lothian --- Mesa only supports glvnd for GLX, it doesn't work for anything else yet -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Michel Dänzer wrote: On 27/10/16 07:52 PM, Andy Furniss wrote: Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use Fluxbox w

[Mesa-dev] [Bug 92877] Add support for libglvnd

https://bugs.freedesktop.org/show_bug.cgi?id=92877 --- Comment #8 from Bastien Nocera --- (In reply to Mike Lothian from comment #7) > Mesa only supports glvnd for GLX, it doesn't work for anything else yet Noted, thanks. -- You are receiving this mail because: You are the QA Contact for the b

[Mesa-dev] [Bug 92877] Add support for libglvnd

https://bugs.freedesktop.org/show_bug.cgi?id=92877 --- Comment #9 from Ernst Sjöstrand --- I don't think these patches are merged yet: https://patchwork.freedesktop.org/series/12471/ Sounds like it's not very well tested yet... -- You are receiving this mail because: You are the assignee for th

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli wrote: > On 10/27/2016 01:48 PM, Rob Clark wrote: >> >> On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli >> wrote: >>> >>> On 10/27/2016 12:16 AM, Rob Clark wrote: So, not quite sure if this is the *correct* solution, but it is at least *a

[Mesa-dev] [Bug 92877] Add support for libglvnd

https://bugs.freedesktop.org/show_bug.cgi?id=92877 --- Comment #10 from Mike Lothian --- It's not documented very well either -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mai

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #39 from Stefano Cipriani --- Playing against bots with an AMD r9 m265x (cape verde) using DRI_PRIME=1 rendered via Intel HD Graphics 4600 the game it's not playable for about 30+ seconds, bot cars start to one every 5~10 seconds. Whe

[Mesa-dev] [PATCH 2/2] vulkan/wsi/x11: Smplify implementation of vkGetPhysicalDeviceSurfaceFormatsKHR

This patch simplifies x11_surface_get_formats() and makes it more readable. It is actually an improvement over the patch I provided earlier this week (750d8cad72), which was not very "good-tasting". I'm sorry for the noise. --- src/vulkan/wsi/wsi_common_x11.c | 11 +++ 1 file changed, 3 in

[Mesa-dev] [PATCH 1/2] vulkan/wsi/x11: Fix behavior of vkGetPhysicalDeviceSurfacePresentModesKHR

x11_surface_get_present_modes() is currently asserting that the number of elements in pPresentModeCount must be greater than or equal to the number of present modes available. This is buggy because pPresentModeCount elements are later copied from the internal modes' array, so if pPresentModeCount i

[Mesa-dev] [Bug 91631] Clang static analysis of libtess shows undefined values and use of memory after free

https://bugs.freedesktop.org/show_bug.cgi?id=91631 Frederic Devernay changed: What|Removed |Added CC||frederic.dever...@m4x.org -- You ar

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

On 10/28/2016 03:22 PM, Rob Clark wrote: On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli wrote: On 10/27/2016 01:48 PM, Rob Clark wrote: On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli wrote: On 10/27/2016 12:16 AM, Rob Clark wrote: So, not quite sure if this is the *correct* solution, but it i

Re: [Mesa-dev] [PATCH 2/2] nir: Fix clone/sweep of info allocated by nir_builder_init_simple_shader().

On Thu, 2016-10-27 at 15:23 -0700, Jason Ekstrand wrote: > On Thu, Oct 27, 2016 at 2:47 PM, Timothy Arceri bora.com> wrote: > > On Thu, 2016-10-27 at 13:57 -0700, Jason Ekstrand wrote: > > > On Thu, Oct 27, 2016 at 1:30 PM, Eric Anholt > > wrote: > > > > Fixes use-after-free-caused segfaults in t

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi/x11: Fix behavior of vkGetPhysicalDeviceSurfacePresentModesKHR

On Friday, 2016-10-28 14:55:00 +0200, Eduardo Lima Mitev wrote: > x11_surface_get_present_modes() is currently asserting that the number of > elements in pPresentModeCount must be greater than or equal to the number > of present modes available. This is buggy because pPresentModeCount > elements ar

Re: [Mesa-dev] [PATCH 1/3] glx/glvnd: Don't modify the dummy slot in the dispatch table

On Wednesday, 2016-09-14 14:06:18 -0400, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- It has been pointed out recently [1] that this series hasn't landed yet. Has it simply fallen through the cracks, or is something holding it up? Cheers, Eric [1] https://bugs.freedesktop.org/show_

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

+Mauro, Chih-Wei On Fri, Oct 28, 2016 at 7:22 AM, Rob Clark wrote: > On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli wrote: >> On 10/27/2016 01:48 PM, Rob Clark wrote: >>> >>> On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli >>> wrote: On 10/27/2016 12:16 AM, Rob Clark wrote: > > S

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

On 28 October 2016 at 13:22, Rob Clark wrote: > On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli wrote: >> On 10/27/2016 01:48 PM, Rob Clark wrote: >>> >>> On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli >>> wrote: On 10/27/2016 12:16 AM, Rob Clark wrote: > > So, not quite sure if t

[Mesa-dev] [Bug 98471] [TRACKER] Mesa 13.0 release tracker

https://bugs.freedesktop.org/show_bug.cgi?id=98471 Bug ID: 98471 Summary: [TRACKER] Mesa 13.0 release tracker Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Prior

[Mesa-dev] [Bug 98473] Mesa fails to build with flex 2.6.2

https://bugs.freedesktop.org/show_bug.cgi?id=98473 Bug ID: 98473 Summary: Mesa fails to build with flex 2.6.2 Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Prior

[Mesa-dev] [Bug 98473] Mesa fails to build with flex 2.6.2

https://bugs.freedesktop.org/show_bug.cgi?id=98473 --- Comment #1 from Emil Velikov --- The following should address the issue, although the question stands: are we doing something wrong or this is a flex bug. https://patchwork.freedesktop.org/series/14477/ -- You are receiving this mail becau

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

On Fri, Oct 28, 2016 at 9:14 AM, Emil Velikov wrote: > On 28 October 2016 at 13:22, Rob Clark wrote: >> On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli wrote: >>> On 10/27/2016 01:48 PM, Rob Clark wrote: On Thu, Oct 27, 2016 at 2:59 AM, Tapani Pälli wrote: > > On 10/27/2016

[Mesa-dev] [Bug 98473] Mesa fails to build with flex 2.6.2

https://bugs.freedesktop.org/show_bug.cgi?id=98473 Emil Velikov changed: What|Removed |Added Blocks||98471 Referenced Bugs: https://bugs.fre

[Mesa-dev] [Bug 98474] Linking mesa against [non-standard prefixed] LLVM fails

https://bugs.freedesktop.org/show_bug.cgi?id=98474 Bug ID: 98474 Summary: Linking mesa against [non-standard prefixed] LLVM fails Product: Mesa Version: git Hardware: Other OS: All Status: NEW

[Mesa-dev] [Bug 98471] [TRACKER] Mesa 13.0 release tracker

https://bugs.freedesktop.org/show_bug.cgi?id=98471 Emil Velikov changed: What|Removed |Added Depends on||98335, 98473, 98474 Referenced Bugs: ht

[Mesa-dev] [Bug 98474] Linking mesa against [non-standard prefixed] LLVM fails

https://bugs.freedesktop.org/show_bug.cgi?id=98474 Emil Velikov changed: What|Removed |Added Blocks||98471 Referenced Bugs: https://bugs.fre

[Mesa-dev] [Bug 98473] Mesa fails to build with flex 2.6.2

https://bugs.freedesktop.org/show_bug.cgi?id=98473 Mike Lothian changed: What|Removed |Added CC||m...@fireburn.co.uk --- Comment #2 from M

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

On 28 October 2016 at 15:33, Rob Herring wrote: > On Fri, Oct 28, 2016 at 9:14 AM, Emil Velikov > wrote: >> On 28 October 2016 at 13:22, Rob Clark wrote: >>> On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli >>> wrote: On 10/27/2016 01:48 PM, Rob Clark wrote: > > On Thu, Oct 27, 2016

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

On 27 October 2016 at 17:06, Gurchetan Singh wrote: > In Android, the pthreads libs are in bionic. When building > Mesa for Android with the autotools workflow, we shouldn't > set -lpthread or -pthread. > --- > configure.ac | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff

Re: [Mesa-dev] [PATCH 2/2] egl: Use pkg-config for Android NDK build

On 27 October 2016 at 17:07, Gurchetan Singh wrote: > It's possible to build Mesa for Android using the traditional > autotools workflow. To enable this, let's add the required > pkg-config checks and link against them. Does the upstream repositories have the files or one requires extra patches ?

Re: [Mesa-dev] [RFC] mesa: drop current draw/read buffer when ctx is released

On Fri, Oct 28, 2016 at 11:33 PM, Rob Herring wrote: > On Fri, Oct 28, 2016 at 9:14 AM, Emil Velikov > wrote: >> On 28 October 2016 at 13:22, Rob Clark wrote: >>> On Fri, Oct 28, 2016 at 1:24 AM, Tapani Pälli >>> wrote: On 10/27/2016 01:48 PM, Rob Clark wrote: > > On Thu, Oct 27,

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

https://bugs.freedesktop.org/show_bug.cgi?id=98428 --- Comment #5 from Emil Velikov --- (In reply to ajax at nwnk dot net from comment #4) > (In reply to Emil Velikov from comment #3) > > On a more comprehensive note: > > > > One of the goals behind GLVND is to reuse mesa's GLAPI and allow us to

Re: [Mesa-dev] [PATCH 2/3] glx/glvnd: Fix dispatch function names and indices

On 19 October 2016 at 18:39, Adam Jackson wrote: > On Fri, 2016-09-16 at 19:07 +0100, Emil Velikov wrote: >> On 14 September 2016 at 19:06, Adam Jackson wrote: >> > As this array was not actually sorted, FindGLXFunction's binary search >> > would only sometimes work. >> > >> >> This commit messag

[Mesa-dev] [Bug 98473] Mesa fails to build with flex 2.6.2

https://bugs.freedesktop.org/show_bug.cgi?id=98473 --- Comment #3 from Emil Velikov --- (In reply to Mike Lothian from comment #2) > Is this a blocker for 13? The release won't need flex to compile as it'll be > pre-generated for the tarball That's correct. Some distros still do autoreconf + fri

Re: [Mesa-dev] [PATCH 2/2] vulkan/wsi/x11: Smplify implementation of vkGetPhysicalDeviceSurfaceFormatsKHR

This is nice. Both are Reviewed-by: Jason Ekstrand On Oct 28, 2016 5:55 AM, "Eduardo Lima Mitev" wrote: > This patch simplifies x11_surface_get_formats() and makes it more readable. > It is actually an improvement over the patch I provided earlier this week > (750d8cad72), which was not very

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

On Fri, Oct 28, 2016 at 8:06 AM, Emil Velikov wrote: > On 27 October 2016 at 17:06, Gurchetan Singh > wrote: >> In Android, the pthreads libs are in bionic. When building >> Mesa for Android with the autotools workflow, we shouldn't >> set -lpthread or -pthread. >> --- >> configure.ac | 7 +

Re: [Mesa-dev] [PATCH] glsl: Improve accuracy of alpha scaling in advanced blend lowering.

Kenneth Graunke writes: > When blending with GL_COLORBURN_KHR and these colors: > >dst = <0.372549027, 0.372549027, 0.372549027, 0.372549027> >src = <0.09375, 0.046875, 0.0, 0.375> > > the normalized dst value became 0.9994 (due to precision problems > in the floating point divide of

[Mesa-dev] [PATCH 1/2] configure.ac: fold xxd's -i within XXD

From: Emil Velikov Otherwise we get annoying messages like the following when xxd is missing. /bin/sh: line 2: -i: command not found Cc: mesa-sta...@lists.freedesktop.org Cc: Lionel Landwerlin Signed-off-by: Emil Velikov --- I'm wondering if we shouldn't give some form or warning/error messag

[Mesa-dev] [PATCH 2/2] intel/genxml: automake: drop Makefile dependency for the _xml.h target

From: Emil Velikov There is nothing in here that would require it. Cc: mesa-sta...@lists.freedesktop.org Cc: Lionel Landwerlin Signed-off-by: Emil Velikov --- Not sure why we got that dependency in the first place, Lionel ? --- src/intel/Makefile.genxml.am | 2 -- 1 file changed, 2 deletions(

Re: [Mesa-dev] [PATCH 2/2] intel/genxml: automake: drop Makefile dependency for the _xml.h target

On 28/10/16 19:12, Emil Velikov wrote: From: Emil Velikov There is nothing in here that would require it. Cc: mesa-sta...@lists.freedesktop.org Cc: Lionel Landwerlin Signed-off-by: Emil Velikov --- Not sure why we got that dependency in the first place, Lionel ? Some of the Makefile's cont

Re: [Mesa-dev] [PATCH 1/2] configure.ac: fold xxd's -i within XXD

On Fri, Oct 28, 2016 at 11:12 AM, Emil Velikov wrote: > From: Emil Velikov > > Otherwise we get annoying messages like the following when xxd is > missing. > > /bin/sh: line 2: -i: command not found That error is better than what we'd get after this patch. "cat ... | >> ..." looks like it genera

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

Removing the entire hunk causes build failures on CrOS mesa. Refer to this for more information: http://stackoverflow.com/questions/17055279/autotools-for-pthreads-not-setting-correct-linker-flags We can do one of the following: (1) Keep as is, with special case for android (2) Set PTHREAD_LIBS

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

On 28 October 2016 at 18:24, Matt Turner wrote: > On Fri, Oct 28, 2016 at 8:06 AM, Emil Velikov > wrote: >> On 27 October 2016 at 17:06, Gurchetan Singh >> wrote: >>> In Android, the pthreads libs are in bionic. When building >>> Mesa for Android with the autotools workflow, we shouldn't >>> s

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

On 28 October 2016 at 19:35, Gurchetan Singh wrote: > Removing the entire hunk causes build failures on CrOS mesa. Refer to this > for more information: > > http://stackoverflow.com/questions/17055279/autotools-for-pthreads-not-setting-correct-linker-flags > > We can do one of the following: > >

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

https://bugs.freedesktop.org/show_bug.cgi?id=98428 --- Comment #6 from ajax at nwnk dot net --- (In reply to Emil Velikov from comment #5) > Are old xservers (ones which includes their own glapi dispatch) + glapi > linked dri modules going to work ? Who cares? Anyone still running 1.14 is alrea

Re: [Mesa-dev] [PATCH 19/25] intel/blorp: Add a clear_attachments entrypoint

On Sat, Oct 22, 2016 at 10:50:50AM -0700, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp.h | 11 +++ > src/intel/blorp/blorp_clear.c | 162 > +- > src/intel/blorp/blorp_priv.h | 1 + > 3 files changed, 172 insertions(+), 2 deletions(-) > > d

Re: [Mesa-dev] [PATCH 21/25] anv/blorp: Break the guts of alloc_binding_table into a shared helper

On Sat, Oct 22, 2016 at 10:50:52AM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_blorp.c | 24 > src/intel/vulkan/anv_private.h | 5 + > src/intel/vulkan/genX_blorp_exec.c | 18 ++ > 3 files changed, 31 insertions(+), 16 deletions

Re: [Mesa-dev] [PATCH 21/25] anv/blorp: Break the guts of alloc_binding_table into a shared helper

On Fri, Oct 28, 2016 at 10:27:02PM +0300, Pohjolainen, Topi wrote: > On Sat, Oct 22, 2016 at 10:50:52AM -0700, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_blorp.c | 24 > > src/intel/vulkan/anv_private.h | 5 + > > src/intel/vulkan/genX_blorp_exec

Re: [Mesa-dev] [PATCH 2/2] intel/genxml: automake: drop Makefile dependency for the _xml.h target

On 28 October 2016 at 19:18, Lionel Landwerlin wrote: > On 28/10/16 19:12, Emil Velikov wrote: >> >> From: Emil Velikov >> >> There is nothing in here that would require it. >> >> Cc: mesa-sta...@lists.freedesktop.org >> Cc: Lionel Landwerlin >> Signed-off-by: Emil Velikov >> --- >> Not sure wh

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 Stefano Cipriani changed: What|Removed |Added CC||cip9...@gmail.com -- You are receivi

Re: [Mesa-dev] [PATCH 2/2] intel/genxml: automake: drop Makefile dependency for the _xml.h target

On 28 October 2016 at 20:55, Emil Velikov wrote: > On 28 October 2016 at 19:18, Lionel Landwerlin > wrote: >> On 28/10/16 19:12, Emil Velikov wrote: >>> >>> From: Emil Velikov >>> >>> There is nothing in here that would require it. >>> >>> Cc: mesa-sta...@lists.freedesktop.org >>> Cc: Lionel Lan

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

I'm confused what the desired cleanup is. Do you want 1) PKG_CHECK_MODULES(PTHREAD, [pthread]) in configure.ac or 2) All references to PTHREAD_LIBS in the configure.ac and the makefiles to be removed. In the cases where this breaks the build, PTHREAD_CFLAGS should be added to the AM_LDFLAGS. O

[Mesa-dev] [RFC 00/11] i965: Remove our dependence on nir_shader::info

Timothy's attempts to extract shader_info from nir_shader got me thinking, "What if shader_info were simply a byproduct of compilation?" His last patch series made nir_shader::info just a pointer to gl_program::info in most cases, so why don't we go all the way and just say that the shader_info li

[Mesa-dev] [RFC 05/11] i965/vec4: Make generate_assembly take an explicit shader_info parameter

--- src/mesa/drivers/dri/i965/brw_shader.cpp | 2 +- src/mesa/drivers/dri/i965/brw_vec4.cpp| 4 ++-- src/mesa/drivers/dri/i965/brw_vec4.h | 2 +- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 10 +- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cp

[Mesa-dev] [RFC 06/11] i965/compiler: Take an explicit shader_info parameter in compile_vs

--- src/intel/vulkan/anv_pipeline.c | 2 +- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_nir.c | 3 ++- src/mesa/drivers/dri/i965/brw_nir.h | 2 +- src/mesa/drivers/dri/i965/brw_vec4.cpp | 20 ++-- src/mesa/drivers/dri/i965/

[Mesa-dev] [RFC 04/11] i965/vec4: Use the new info field instead of nir->info

--- src/mesa/drivers/dri/i965/brw_vec4.cpp| 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp| 8 src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp| 6 +++--- src/mesa/drivers/dri/i965/gen6_gs_visitor.cp

[Mesa-dev] [RFC 10/11] i965/compiler: Take an explicit shader_info parameter in compile_fs

--- src/intel/blorp/blorp.c | 4 ++-- src/intel/vulkan/anv_pipeline.c | 2 +- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 33 src/mesa/drivers/dri/i965/brw_wm.c | 2 +- 5 files chang

[Mesa-dev] [RFC 08/11] i965/compiler: Take an explicit shader_info parameter in compile_tes

--- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_shader.cpp | 26 +- src/mesa/drivers/dri/i965/brw_tes.c | 3 ++- 3 files changed, 16 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_compiler.h b/src/mesa/dr

[Mesa-dev] [RFC 01/11] i965: Pull shader_info out of gl_program rather than nir_shader

This commit modifies all of the state upload and codegen code to pull the shader_info out of gl_program rather than nir_shader. In the GL driver, the pointer in nir_shader just points to gl_program::shader_info anyway so there's no real point in pulling it from the nir_shader. --- src/mesa/driver

[Mesa-dev] [RFC 07/11] i965/compiler: Take an explicit shader_info parameter in compile_tcs

--- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_tcs.c| 3 ++- src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp | 28 ++-- 3 files changed, 17 insertions(+), 15 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_compiler.h b/src

[Mesa-dev] [RFC 03/11] i965/fs: Use the new info field instead of nir->info

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 44 ++-- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 18 ++-- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 12 src/mesa/drivers/dri/i965/brw_wm_iz.cpp | 2 +- 4 files changed, 38 insertions(+), 3

[Mesa-dev] [RFC 02/11] i965/shader: Add an explicit shader_info field

We also go through all the pain of plumbing it through all the constructors here so we don't have to later. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 10 +- src/mesa/drivers/dri/i965/brw_fs.h| 2 ++ src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 6 -

[Mesa-dev] [RFC 09/11] i965/compiler: Take an explicit shader_info parameter in compile_gs

--- src/intel/vulkan/anv_pipeline.c | 2 +- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_gs.c| 2 +- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 39 --- 4 files changed, 23 insertions(+), 21

[Mesa-dev] [RFC 11/11] i965/compiler: Take an explicit shader_info parameter in compile_cs

--- src/intel/vulkan/anv_pipeline.c| 2 +- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_cs.c | 4 ++-- src/mesa/drivers/dri/i965/brw_fs.cpp | 25 + src/mesa/drivers/dri/i965/brw_nir.h

[Mesa-dev] [PATCH] svga: collect stats for time spent in svga_context_finish()

This should have appeared with commit "svga: add guest statistic gathering interface" from August 4, but was somehow lost. --- src/gallium/drivers/svga/svga_context.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/svga/svga_context.c b/src/gallium/drivers/svga/svga_co

  1   2   >