I'm confused what the desired cleanup is. Do you want 1) PKG_CHECK_MODULES(PTHREAD, [pthread]) in configure.ac or 2) All references to PTHREAD_LIBS in the configure.ac and the makefiles to be removed. In the cases where this breaks the build, PTHREAD_CFLAGS should be added to the AM_LDFLAGS.
On Fri, Oct 28, 2016 at 11:59 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 28 October 2016 at 19:35, Gurchetan Singh > <gurchetansi...@chromium.org> wrote: > > Removing the entire hunk causes build failures on CrOS mesa. Refer to > this > > for more information: > > > > http://stackoverflow.com/questions/17055279/autotools-for- > pthreads-not-setting-correct-linker-flags > > > > We can do one of the following: > > > > (1) Keep as is, with special case for android > > (2) Set PTHREAD_LIBS=$PTHREAD_CFLAGS in configure.ac > > (3) Do a giant sed to convert PTHREAD_LIBS to PTHREAD_CFLAGS in the > entire > > tree > > > > Any strong preferences??? > > > As mentioned before - I'm pretty sure we have places where we've > forgot the cflags/libs. > > It's an issue on our end, so instead of working around it (by using > PTHREAD_CFLAGS as PTHREAD_LIBS) we could fix it. > Can you please give it a try ? > > Thanks > Emil >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
