On 28 October 2016 at 19:18, Lionel Landwerlin
<lionel.g.landwer...@intel.com> wrote:
> On 28/10/16 19:12, Emil Velikov wrote:
>>
>> From: Emil Velikov <emil.veli...@collabora.com>
>>
>> There is nothing in here that would require it.
>>
>> Cc: mesa-sta...@lists.freedesktop.org
>> Cc: Lionel Landwerlin <lionel.g.landwer...@intel.com>
>> Signed-off-by: Emil Velikov <emil.veli...@collabora.com>
>> ---
>> Not sure why we got that dependency in the first place, Lionel ?
>
>
> Some of the Makefile's content ends up in the header (the last echo line of
> this patch).
> If someone changes that, it's nice not to have to cleanup all the intel
> directory
>
Valid point. At the same time, this applies to every rule [we have in
mesa] and we don't bother anywhere else.
I'm kind of split, bth.
Mildly related: does the following read too cryptic ? It achieves the
exact same purpose the current code :-)
+ $(AM_V_GEN) $(XXD) -i $< >> $@; \
+ $(SED) -i -e '1 s,^.*$$,static const uint8_t $(*F)_xml[] = {,;$$ d' $@
Thanks
Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
