Re: [Mesa-dev] [PATCH] r600/cayman: looks like cmpxchg moved to Z

2017-11-27 Thread Constantine Kharlamov
On понедельник, 27 ноября 2017 г. 9:41:35 MSK Dave Airlie wrote: > From: Dave Airlie > > On cayman it appears the cmp component is now in Z. > > Fixes: > arb_shader_image_load_store-dead-fragments on cayman. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/r600/r600_shader.c | 7 +++

Re: [Mesa-dev] [RFC v5 08/19] egl/x11: Re-allocate buffers if format is suboptimal

2017-11-07 Thread Constantine Kharlamov
[snip] > @@ -372,10 +372,22 @@ dri3_handle_present_event(struct loader_dri3_drawable > *draw, > switch (ce->mode) { > case XCB_PRESENT_COMPLETE_MODE_FLIP: > draw->flipping = true; > +for (int b = 0; b < sizeof(draw->buffers) / > sizeof(draw->buffers[0]

Re: [Mesa-dev] [PATCH 02/27] mesa: add support for memory object creation/import/delete

2017-07-19 Thread Constantine Kharlamov
On 13.07.2017 01:45, Andres Rodriguez wrote: > Used by EXT_external_objects and EXT_external_objects_fd > > Signed-off-by: Andres Rodriguez > --- > src/mesa/drivers/common/driverfuncs.c | 4 + > src/mesa/main/dd.h| 36 + > src/mesa/main/externalobjects.c | 14

[Mesa-dev] [PATCH 0/2] r600_asm.c trivial cleanups

2017-07-16 Thread Constantine Kharlamov
It was a part of some other work I had to abandon. It really eases understanding the code. The 2 patches are only build-tested, but they're small code-level trivia, so it should be fine. Constantine Kharlamov (2): r600g: remove unused args, and one unneeded forward declaration

[Mesa-dev] [PATCH 1/2] r600g: remove unused "bc" args, and one unneeded forward declaration

2017-07-16 Thread Constantine Kharlamov
To ease review just highlight "bc," string. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_asm.c | 85 + 1 file changed, 40 insertions(+), 45 deletions(-) diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/dr

[Mesa-dev] [PATCH 2/2] r600g: constify some args at r600_asm.c

2017-07-16 Thread Constantine Kharlamov
Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_asm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/drivers/r600/r600_asm.c index f333e7769a..f5c0e80919 100644 --- a/src/gallium/drivers

Re: [Mesa-dev] [PATCH 2/3 v2] r600g: take into account offset to system inputs at tgsi_interp_egcm()

2017-06-26 Thread Constantine Kharlamov
anks for the feedback! > On 24 June 2017 at 15:06, Constantine Kharlamov wrote: >> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=100785 > s/Fixes/Bugzilla/ and keep this above the s-o-b/r-b/other tags. > > Should this fix land in the stable releases - see > htt

Re: [Mesa-dev] [PATCH 2/3 v2] r600g: take into account offset to system inputs at tgsi_interp_egcm()

2017-06-24 Thread Constantine Kharlamov
: Constantine Kharlamov --- src/gallium/drivers/r600/r600_shader.c | 8 src/gallium/drivers/r600/r600_shader.h | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 156dba085d

[Mesa-dev] [PATCH 3/3] r600g: fix crash when file in R600_TRACE doesn't exist

2017-06-24 Thread Constantine Kharlamov
…and print error in such case. Which probably is not a rare event btw because fopen doesn't expand ~ to $HOME. Also get rid of unused "bool ret" variable. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_hw_context.c | 9 + 1 file changed, 5 i

[Mesa-dev] [PATCH 2/3] r600g: take into account offset to system inputs at tgsi_interp_egcm()

2017-06-24 Thread Constantine Kharlamov
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=100785 Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_shader.c | 8 src/gallium/drivers/r600/r600_shader.h | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/r600

[Mesa-dev] [PATCH 0/3] r600g: small fixes

2017-06-24 Thread Constantine Kharlamov
rivia, so there shouldn't be problems. Constantine Kharlamov (3): r600g: get rid of trailing whitespace r600g: take into account offset to system inputs at tgsi_interp_egcm() r600g: fix crash when file in R600_TRACE doesn't exist src/gallium/drivers/r600/r600_hw_context.c |

[Mesa-dev] [PATCH 1/3] r600g: get rid of trailing whitespace

2017-06-24 Thread Constantine Kharlamov
Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_shader.c | 44 +- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index bdaf28ced2..156dba085d

Re: [Mesa-dev] [PATCH] [RFC] r600g: do not pick TGSI input registers at random

2017-06-20 Thread Constantine Kharlamov
Omg, nvm, it was a copy-paste error (the "input[i]"), I should've written a follow up mail. The real problem remains to be seen. Alright, later then. 20.06.2017, 10:04, "Constantine Kharlamov" : > 20.06.2017, 08:34, "Constantine Kharlamov" : >>

Re: [Mesa-dev] [PATCH] [RFC] r600g: do not pick TGSI input registers at random

2017-06-20 Thread Constantine Kharlamov
20.06.2017, 08:34, "Constantine Kharlamov" : > This was discussed on IRC, there was much confusion, and overall there was a > belief like the bug in some place other. A few minutes ago I was writing a > follow-up in mail because I'll have trouble replying today. > &

Re: [Mesa-dev] [PATCH] [RFC] r600g: do not pick TGSI input registers at random

2017-06-19 Thread Constantine Kharlamov
I added, at the "0" index. Numerically TGSI_FILE_OUTPUT is "3", so it's not a default value, it was deliberately assigned. Pure accident :D On 19.06.2017 12:57, Constantine Kharlamov wrote: > tgsi_declaration() configures inputs. Then tgsi_interp_egcm() uses one > of the

[Mesa-dev] [PATCH] [RFC] r600g: do not pick TGSI input registers at random

2017-06-19 Thread Constantine Kharlamov
e input register unconfigured. In release version it'd return -ECANCELED — the other possible fail I found in the function is -ENOMEM, so I don't know if there's a better value. That said, I don't think it matters much either — there's a unique print+assert.

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB registerupdates

2017-05-03 Thread Constantine Kharlamov
On 03.05.2017 12:31, Marc Dietrich wrote: > Hi Constantine, > > Am Mittwoch, 3. Mai 2017, 05:48:14 CEST schrieb Constantine Kharlamov: >> On 03.05.2017 00:50, Constantine Kharlamov wrote: >>> On 28.04.2017 10:57, Marc Dietrich wrote: >>>> Hi Constantine, >

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB registerupdates

2017-05-02 Thread Constantine Kharlamov
On 03.05.2017 00:50, Constantine Kharlamov wrote: > On 28.04.2017 10:57, Marc Dietrich wrote: >> Hi Constantine, >> >> >> Am Donnerstag, 27. April 2017, 21:04:37 CEST schrieb Constantine Kharlamov: >>> Please, could you try this patch. The c

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB registerupdates

2017-05-02 Thread Constantine Kharlamov
On 28.04.2017 10:57, Marc Dietrich wrote: > Hi Constantine, > > > Am Donnerstag, 27. April 2017, 21:04:37 CEST schrieb Constantine Kharlamov: >> Please, could you try this patch. The change is: I'm setting dirty_zsbuf in >> r600_bind_blend_state_internal() as well.

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB registerupdates

2017-04-28 Thread Constantine Kharlamov
On 28.04.2017 21:19, Marc Dietrich wrote: > Am Freitag, 28. April 2017, 16:53:55 CEST schrieb Dieter Nützel: >> I'm running this, too. >> But alone. 4/4 didn't apply anylonger ;-) >> >> NO glitches on NI/Turks XT (6670). >> >> I had tested 'Heaven' and 'Valley' even with the former patch version. >

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB registerupdates

2017-04-27 Thread Constantine Kharlamov
On 27.04.2017 11:32, Marc Dietrich wrote: > Am Donnerstag, 27. April 2017, 10:05:32 CEST schrieb Marc Dietrich: >> Am Mittwoch, 26. April 2017, 19:48:46 CEST schrieb Constantine Kharlamov: >>> On 26.04.2017 17:51, Marc Dietrich wrote: >>>> Am Mittwoch, 26. Apr

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-27 Thread Constantine Kharlamov
27.04.2017, 13:26, "Emil Velikov" : > Hi Constantine, > > I'm not familiar with r600, so mostly a drive-by idea/nit. I'm not familiar with graphics :P Well, perhaps a little now. > On 25 April 2017 at 12:59, Constantine Kharlamov wrote: > >

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB registerupdates

2017-04-27 Thread Constantine Kharlamov
27.04.2017, 11:32, "Marc Dietrich" : > Am Donnerstag, 27. April 2017, 10:05:32 CEST schrieb Marc Dietrich: >>  Am Mittwoch, 26. April 2017, 19:48:46 CEST schrieb Constantine Kharlamov: >>  > On 26.04.2017 17:51, Marc Dietrich wrote: >>  > > Am Mittwoc

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-26 Thread Constantine Kharlamov
On 26.04.2017 17:51, Marc Dietrich wrote: > Am Mittwoch, 26. April 2017, 16:36:39 CEST schrieb Constantine Kharlamov: >> HEAD recently have triggered a bug in sb compiler, so, just for the safe >> case, can you tell if reverting this commit >> >

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-26 Thread Constantine Kharlamov
17:23, Marc Dietrich wrote: > Am Mittwoch, 26. April 2017, 16:16:35 CEST schrieb Constantine Kharlamov: >> Thank you for testing! What is "UH4" btw? > > old GL3.3 benchmark Unigine Heaven 4.0 > > https://benchmark.unigine.com/heaven > > Marc > >&g

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-26 Thread Constantine Kharlamov
Thank you for testing! What is "UH4" btw? On 26.04.2017 17:03, Marc Dietrich wrote: > Am Dienstag, 25. April 2017, 13:59:44 CEST schrieb Constantine Kharlamov: >> Split out of "avoid redundant CB register updates" for easier review. >> >> Signed-off-by: Co

Re: [Mesa-dev] [PATCH 4/4] r600g: avoid redundant CB updates

2017-04-25 Thread Constantine Kharlamov
On 25.04.2017 14:59, Constantine Kharlamov wrote: > It finishes the work started by 0c2eed0edec, quoting: > >> The main idea is to avoid setting CB_COLORi_INFO = 0 for i>0 repeatedly >> when those colorbuffers aren't used. This is mainly for glamor. > > After 0

[Mesa-dev] [PATCH 4/4] r600g: avoid redundant CB updates

2017-04-25 Thread Constantine Kharlamov
in Kane&Lynch2. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/evergreen_state.c | 15 +-- src/gallium/drivers/r600/r600_blit.c | 3 ++- src/gallium/drivers/r600/r600_hw_context.c | 1 + src/gallium/drivers/r600/r600_pipe.h | 1

[Mesa-dev] [PATCH 3/4] r600g: remove unused sbcl env. variable

2017-04-25 Thread Constantine Kharlamov
sb-based optimization was only used for older LLVM, whose support was removed in 100796c15c3a1467d03abc424e6f1494da02f376 "gallium/radeon: drop support for LLVM 3.5". As of now sbcl variable doesn't do anything. Signed-off-by: Constantine Kharlamov Tested-by: Dieter Nützel -

[Mesa-dev] [PATCH 2/4] r600g/radeonsi: trivial cleanups

2017-04-25 Thread Constantine Kharlamov
constified some variables, moved two variable declarations into the cycle where they're used, and removed trailing whitespace. Signed-off-by: Constantine Kharlamov Tested-by: Dieter Nützel --- src/gallium/drivers/r600/evergreen_state.c | 4 +-- src/gallium/drivers/r600/r600_blit.c

[Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

2017-04-25 Thread Constantine Kharlamov
Split out of "avoid redundant CB register updates" for easier review. Signed-off-by: Constantine Kharlamov Tested-by: Dieter Nützel --- src/gallium/drivers/r600/evergreen_state.c | 76 +++- src/gallium/drivers/r600/r600_blit.c | 1 + src/gallium/dr

[Mesa-dev] [PATCH 0/4 v2] small r600g improvements

2017-04-25 Thread Constantine Kharlamov
No regressions with piglit. 1,2, and 3 patches without changes, tested by Dieter, 4 is the new one. Constantine Kharlamov (4): r600g: avoid redundant DB register updates r600g/radeonsi: trivial cleanups r600g: remove unused sbcl env. variable r600g: avoid redundant CB updates src

Re: [Mesa-dev] [PATCH 3/3] r600g: remove unused sbcl env. variable

2017-04-24 Thread Constantine Kharlamov
ay, Yea ;-) > > Dieter > > Am 23.04.2017 23:36, schrieb Constantine Kharlamov: >> sb-based optimization was only used for older LLVM, whose support was removed >> in 100796c15c3a1467d03abc424e6f1494da02f376 "gallium/radeon: drop support for >> LLVM 3.5"

[Mesa-dev] [PATCH 1/3] r600g: avoid redundant DB register updates

2017-04-23 Thread Constantine Kharlamov
Split out of "avoid redundant CB register updates" for easier review. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/evergreen_state.c | 76 +++- src/gallium/drivers/r600/r600_blit.c | 1 + src/gallium/drivers/r600/r600_hw_contex

[Mesa-dev] [PATCH 0/3] small r600g improvements

2017-04-23 Thread Constantine Kharlamov
d-fbo-extended-blend -auto Constantine Kharlamov (3): r600g: avoid redundant DB register updates r600g/radeonsi: trivial cleanups r600g: remove unused sbcl env. variable src/gallium/drivers/r600/evergreen_state.c | 80 +++- src/gallium/drivers/r600/r600_blit.c

[Mesa-dev] [PATCH 2/3] r600g/radeonsi: trivial cleanups

2017-04-23 Thread Constantine Kharlamov
constified some variables, moved two variable declarations into the cycle where they're used, and removed trailing whitespace. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/evergreen_state.c | 4 +-- src/gallium/drivers/r600/r600_blit.c | 4 +-- src/gallium/dr

[Mesa-dev] [PATCH 3/3] r600g: remove unused sbcl env. variable

2017-04-23 Thread Constantine Kharlamov
sb-based optimization was only used for older LLVM, whose support was removed in 100796c15c3a1467d03abc424e6f1494da02f376 "gallium/radeon: drop support for LLVM 3.5". Since then sbcl variable doesn't do anything. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r

[Mesa-dev] [PATCH] r600g: update dirty_level_mask after the 1-st draw after FB change

2017-04-13 Thread Constantine Kharlamov
Ported from radeonsi. Testing with Kane&Lynch2 shows ≈1k skipped updates per frame on average. No piglit changes with tests/gpu.py, gbm mode. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/evergreen_state.c | 1 + src/gallium/drivers/r600/r600_pipe.h | 1 +

Re: [Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

2017-04-12 Thread Constantine Kharlamov
On 12.04.2017 23:03, Markus Trippelsdorf wrote: > On 2017.04.12 at 20:45 +0100, Emil Velikov wrote: >> On 12 April 2017 at 20:34, Constantine Kharlamov wrote: >> >>>> I suspect this breaks because r600 more often fails to >>>> compile some shaders, >>

Re: [Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

2017-04-12 Thread Constantine Kharlamov
On 12.04.2017 22:21, Dave Airlie wrote: > On 13 April 2017 at 03:39, Constantine Kharlamov wrote: >> On 12.04.2017 18:53, Marek Olšák wrote: >>> On Wed, Apr 12, 2017 at 4:44 PM, Markus Trippelsdorf >>> wrote: >>>> On 2017.04.10 at 22:48 +0200, Marek Olšák

Re: [Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

2017-04-12 Thread Constantine Kharlamov
On 12.04.2017 18:53, Marek Olšák wrote: > On Wed, Apr 12, 2017 at 4:44 PM, Markus Trippelsdorf > wrote: >> On 2017.04.10 at 22:48 +0200, Marek Olšák wrote: >>> Pushed the series, thanks! >>> >>> Marek >>> >>> On Mon, Apr 10, 2017 at 10:

[Mesa-dev] [PATCH 0/3 v3] r600g: shader logic improvements

2017-04-10 Thread Constantine Kharlamov
of the logic, I gave up. v3: 1-st patch: get the check for null tes and gs back, while I haven't figured out the best way to move stride assignment into r600_update_derived_state() (as it is in radeonsi). 2,3 are the same, already reviewed, and rebased against th

[Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

2017-04-10 Thread Constantine Kharlamov
: added a check I missed because of a macros using a prefix to choose a shader. Signed-off-by: Constantine Kharlamov Reviewed-by: Marek Olšák --- src/gallium/drivers/r600/r600_pipe.c | 9 - src/gallium/drivers/r600/r600_pipe.h | 3 -- src/gallium/drivers/r600/r600_state_common.c

[Mesa-dev] [PATCH 2/3] r600g: add draw_vbo check for a NULL pixel shader

2017-04-10 Thread Constantine Kharlamov
Taken from radeonsi, required to remove dummy pixel shader in the next patch Signed-off-by: Constantine Kharlamov Reviewed-by: Marek Olšák --- src/gallium/drivers/r600/evergreen_state.c | 1 + src/gallium/drivers/r600/r600_pipe.h | 1 + src/gallium/drivers/r600/r600_state.c

[Mesa-dev] [PATCH 1/3 v3] r600g: skip repeating vs, gs, and tes shader binds

2017-04-10 Thread Constantine Kharlamov
rived_state() (as it is in radeonsi). Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_state_common.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r600_state_commo

Re: [Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

2017-04-10 Thread Constantine Kharlamov
stops), but draw_vbo() never actually sees null > ps. > > v2: added a check I missed because of a macros using a prefix to choose > a shader. > > Signed-off-by: Constantine Kharlamov > --- > src/gallium/drivers/r600/r600_pipe.c | 9 - > src/gallium/drivers/

[Mesa-dev] [PATCH 2/3] r600g: add draw_vbo check for a NULL pixel shader

2017-04-09 Thread Constantine Kharlamov
Taken from radeonsi, required to remove dummy pixel shader in the next patch Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/evergreen_state.c | 1 + src/gallium/drivers/r600/r600_pipe.h | 1 + src/gallium/drivers/r600/r600_state.c| 3 ++- src/gallium/drivers

[Mesa-dev] [PATCH 1/3 v2] r600g: skip repeating vs, gs, and tes shader binds

2017-04-09 Thread Constantine Kharlamov
ones occurs rarely enough to not get into per-frame counter at all, so I just gonna say: it happens. v2: I've occasionally removed an empty line, don't do this. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_state_common.c | 12 +++- 1 file changed, 7 i

[Mesa-dev] [PATCH 0/3 v2] r600g: shader logic improvements

2017-04-09 Thread Constantine Kharlamov
of the logic, I gave up. Constantine Kharlamov (3): r600g: skip repeating vs, gs, and tes shader binds r600g: add draw_vbo check for a NULL pixel shader r600g: get rid of dummy pixel shader src/gallium/drivers/r600/evergreen_state.c | 1 + src/gallium/drivers/r600/r600_pipe.c

[Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader

2017-04-09 Thread Constantine Kharlamov
: added a check I missed because of a macros using a prefix to choose a shader. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_pipe.c | 9 - src/gallium/drivers/r600/r600_pipe.h | 3 -- src/gallium/drivers/r600/r600_state_common.c | 58

[Mesa-dev] [PATCH 1/3 v3] r600g: skip repeating vs, gs, and tes shader binds

2017-04-09 Thread Constantine Kharlamov
ones occurs rarely enough to not get into per-frame counter at all, so I just gonna say: it happens. v2: I've occasionally removed an empty line, don't do this. v3: fix the title for the mail to get stacked with its series Signed-off-by: Constantine Kharlamov --- src/galli

[Mesa-dev] [PATCH v2] r600g: skip repeating vs, gs, and tes shader binds

2017-04-09 Thread Constantine Kharlamov
ones occurs rarely enough to not get into per-frame counter at all, so I just gonna say: it happens. v2: I've occasionally removed an empty line, don't do this. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_state_common.c | 12 +++- 1 file changed, 7 i

[Mesa-dev] [PATCH 3/3] r600g: get rid of dummy pixel shader

2017-04-09 Thread Constantine Kharlamov
-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_pipe.c | 9 - src/gallium/drivers/r600/r600_pipe.h | 3 --- src/gallium/drivers/r600/r600_state_common.c | 17 - 3 files changed, 8 insertions(+), 21 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 2/3] r600g: add draw_vbo check for a NULL pixel shader

2017-04-09 Thread Constantine Kharlamov
Taken from radeonsi, required to remove dummy pixel shader in the next patch Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/evergreen_state.c | 1 + src/gallium/drivers/r600/r600_pipe.h | 1 + src/gallium/drivers/r600/r600_state.c| 3 ++- src/gallium/drivers

[Mesa-dev] [PATCH 1/3] r600g: skip repeating vs, gs, and tes shader binds

2017-04-09 Thread Constantine Kharlamov
nding vertex ones occurs rarely enough to not get into per-frame counter at all, so I just gonna say: it happens. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_state_common.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH 0/3] r600g: shader logic improvements

2017-04-09 Thread Constantine Kharlamov
Although I didn't see a staticstically significant change in GTAⅣ benchmark, it seem to have reduced stall for opening the door from a house to the outer world at the first savepoint. No changes in gpu.py tests of piglit in gbm mode. Constantine Kharlamov (3): r600g: skip repeating vs, gs

Re: [Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

2017-04-08 Thread Constantine Kharlamov
On 08.04.2017 19:37, Marek Olšák wrote: > On Sat, Apr 8, 2017 at 12:53 AM, Gustaw Smolarczyk > wrote: >> 2017-04-07 23:56 GMT+02:00 Marek Olšák : >>> On Fri, Apr 7, 2017 at 6:54 PM, Gustaw Smolarczyk >>> wrote: 2017-04-07 16:31 GMT+02:00 Marek Olšák : > On Thu, Mar 30, 2017 at 8:09 PM,

[Mesa-dev] [PATCH 3/4] r600g: extract a code into a r600_emit_rasterizer_prim_state()

2017-04-02 Thread Constantine Kharlamov
Also change gs_output_prim type: unsigned → pipe_prim_type. The idea of the code is mostly taken from radeonsi. The new code operating on prev/curr rast_primitives saves ≈15 reloads of PA_SC_LINE_STIPPLE per frame in Kane&Lynch2 Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/

[Mesa-dev] [PATCH 0/4] r600_state_common small improvements

2017-04-02 Thread Constantine Kharlamov
sole purpose of just describing the acc. enum. Piglit-tested with tests/gpu.py in gbm mode, no changes. P.S. I don't have commit access. Constantine Kharlamov (4): r600g: remove duplicate memset by using a pointer, and constify args r600g/radeonsi: use the correct types (taken fro

[Mesa-dev] [PATCH 1/4] r600g: remove duplicate memset by using a pointer, and constify args

2017-04-02 Thread Constantine Kharlamov
Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_state_common.c | 41 +--- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r600_state_common.c index 096caed8d3

[Mesa-dev] [PATCH 4/4] r600g: check rasterizer primitive states like in radeonsi

2017-04-02 Thread Constantine Kharlamov
Specifically, non-line primitives skipped, and defaulting to reset on each packet. The skip of non-line primitives saves ≈110 resetting of PA_SC_LINE_STIPPLE register per frame in Kane&Lynch2. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_state_common.c

[Mesa-dev] [PATCH 2/4] r600g/radeonsi: use the correct types (taken from pipe_draw_info)

2017-04-02 Thread Constantine Kharlamov
Note: si_shader.h has also "type" variable that should be changed to "enum pipe_prim_type", however it triggers a bunch of warnings about unhandled switches, so due not knowing the correct way to handle them, I decided to leave it as is. Signed-off-by: Constantine Kharlam

Re: [Mesa-dev] [PATCH 4/5] r600g: use a clever alignment for index buffer uploads

2017-04-01 Thread Constantine Kharlamov
fetches. > > Marek > > > On Tue, Mar 28, 2017 at 9:33 PM, Marek Olšák wrote: >> BTW, I don't know if tcc_cache_line_size has the correct value for >> pre-GCN chips. >> >> Marek >> >> On Sun, Mar 26, 2017 at 5:36 PM, Constantine Kha

Re: [Mesa-dev] [PATCH 4/5] r600g: use a clever alignment for index buffer uploads

2017-03-28 Thread Constantine Kharlamov
Ok, I can look it up. Is there some docs where I find the right alignment value? On 28.03.2017 22:33, Marek Olšák wrote: > BTW, I don't know if tcc_cache_line_size has the correct value for > pre-GCN chips. > > Marek > > On Sun, Mar 26, 2017 at 5:36 PM, Constantine Kharla

[Mesa-dev] [PATCH 1/5] r600g: Use separate index_bias variable

2017-03-26 Thread Constantine Kharlamov
Needed to get rid of a separate struct allocation in the next patch, because the one in argument is a constant, and don't allow changing its fields. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_state_common.c | 8 +--- 1 file changed, 5 insertions(+), 3 dele

[Mesa-dev] [PATCH 5/5] r600g: use a clever alignment for index buffer uploads 2

2017-03-26 Thread Constantine Kharlamov
Stolen from radeonsi Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_pipe.h | 15 +++ src/gallium/drivers/r600/r600_state_common.c | 8 +--- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.h b

[Mesa-dev] [PATCH 4/5] r600g: use a clever alignment for index buffer uploads

2017-03-26 Thread Constantine Kharlamov
Stolen from radeonsi Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_state_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r600_state_common.c index 961e04e9db

[Mesa-dev] [PATCH 2/5] r600g: Remove intermediate assignment of pipe_draw_info

2017-03-26 Thread Constantine Kharlamov
It removes a need to copy whole struct every call for no reason. Comparing objdump -d output for original and this patch compiled with -O2, shows reduce of the function by 16 bytes. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_state_common.c | 101

[Mesa-dev] [PATCH 3/5] r600g: Add more (un)likely functions

2017-03-26 Thread Constantine Kharlamov
1-st is obvious because of assert, 2-nd stolen frmo si_draw_vbo(), and 3-rd is just a small refactoring. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_state_common.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/r600

[Mesa-dev] [PATCH 0/5] Small r600_draw_vbo optimizations

2017-03-26 Thread Constantine Kharlamov
ommit it is). Constantine Kharlamov (5): r600g: Use separate index_bias variable r600g: Remove intermediate assignment of pipe_draw_info r600g: Add some more (un)likely functions r600g: use a clever alignment for index buffer uploads r600g: use a clever alignment for index buffer uplo

Re: [Mesa-dev] [PATCH] r600g/sb: Fix memory leak by reworking uses list (rebased)

2017-03-20 Thread Constantine Kharlamov
I resend it, my prev. rebase was apparently sent through Thunderbird, which even with plain text having set managed to screw this up. It's the last drop, I better off return to KMail. Anyway just saying that I resend it. For unknown reason the version2 rebase didn't have you in CC, even though I

[Mesa-dev] [PATCH v2] r600g/sb: Fix memory leak by reworking uses list (rebased)

2017-03-20 Thread Constantine Kharlamov
The author is Heiko Przybyl(CC'ing), the patch is rebased on top of Bartosz Tomczyk's one per Dieter Nützel's comment. Tested-by: Constantine Charlamov v2: Resend the patch again through git-email. The prev. rebase was sent through Thunderbird, which screwed up tab characters, making the patch n

Re: [Mesa-dev] [PATCH v2 1/2] r600g: make condition clearer

2017-03-20 Thread Constantine Kharlamov
way, looks good. > Dieter > > PS ...Dieter's comment... is enough ;-) > > Am 20.03.2017 13:19, schrieb Constantine Kharlamov: >> The second check in the old code looked pretty much unreachable, esp. >> because it's not obvious that "max_entries" could

Re: [Mesa-dev] [PATCH] r600g/sb: Fix memory leak by reworking uses list (rebased)

2017-03-20 Thread Constantine Kharlamov
On 20.03.2017 14:53, Dieter Nützel wrote: > Hello Constantine, > > rebase again, please? > Shouldn't we try to land? Sorry, forgot to addres this. Yes, the patch is nice, I am running the system with the patch since its first revision, everything is fine. > Thanks, > Dieter > > Am 23.02.2017 2

Re: [Mesa-dev] [PATCH] r600g/sb: Fix memory leak by reworking uses list (rebased)

2017-03-20 Thread Constantine Kharlamov
The patch still applies to master, rebase is unneeded. On 20.03.2017 14:53, Dieter Nützel wrote: > Hello Constantine, > > rebase again, please? > Shouldn't we try to land? > > Thanks, > Dieter > > Am 23.02.2017 22:00, schrieb Constantine Charlamov: >> The author is Heiko Przybyl(CC'ing), the pa

Re: [Mesa-dev] [PATCH 1/2] r600: make condition clearer

2017-03-20 Thread Constantine Kharlamov
t; 1/2 > Acked-by: Dieter Nützel > > @Marek: > There are several r600/r600g patches/fixes floating around. > I'll try to test all and who is responsible for them (r600g) and commit them > later on? > > Greetings, > Dieter > > Am 19.03.2017 14:53, schrieb Constan

[Mesa-dev] [PATCH v2 1/2] r600g: make condition clearer

2017-03-20 Thread Constantine Kharlamov
n clear. v2: s/r600/r600g in the title, and per Dieter Nützel's comment wrap lines of condition. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_asm.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/r600/r600_

[Mesa-dev] [PATCH v2 2/2] r600g: update sb documentation

2017-03-20 Thread Constantine Kharlamov
v2: s/r600/r600g in the title Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/sb/notes.markdown | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/sb/notes.markdown b/src/gallium/drivers/r600/sb/notes.markdown index

[Mesa-dev] [PATCH 2/2] r600: update sb documentation

2017-03-19 Thread Constantine Kharlamov
Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/sb/notes.markdown | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/sb/notes.markdown b/src/gallium/drivers/r600/sb/notes.markdown index 056497754a..63c010883d 100644 --- a/src

[Mesa-dev] [PATCH 1/2] r600: make condition clearer

2017-03-19 Thread Constantine Kharlamov
clear. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_asm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/drivers/r600/r600_asm.c index f85993d451..f8d6883551 100644 --- a/src/galli

Re: [Mesa-dev] [PATCH 12/24] radeonsi: set readnone on reads from read-only memory

2017-03-10 Thread Constantine Kharlamov
On 26.02.2017 02:58, Marek Olšák wrote: > From: Marek Olšák > > --- > src/amd/common/ac_llvm_build.c | 11 +-- > src/amd/common/ac_llvm_build.h | 3 ++- > src/gallium/drivers/radeonsi/si_shader.c | 20 ++-- > 3 files changed, 21 insertions(+), 13 del

Re: [Mesa-dev] merged/mega *_dri.so files?

2017-03-09 Thread Constantine Kharlamov
09.03.2017, 07:29, "Brian Paul" : > I just noticed something: > > $ ls -l lib/*_dri.so > -rwxr-xr-x 8 brianp users 43779971 Mar 8 20:59 lib/i915_dri.so* > -rwxr-xr-x 8 brianp users 43779971 Mar 8 20:59 lib/i965_dri.so* > -rwxr-xr-x 8 brianp users 43779971 Mar 8 20:59 lib/nouveau_vieux_dri.so* > -rw